Page MenuHomePhabricator

Search input field contains parameter with alias twice after deleting it
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • create a template that contains a parameter with an alias but without a label
  • go into visual editor to edit this template
  • click on add more information
  • delete the parameter with the trash icon
  • click on add more information again

What happens?:

you see now the parameter twice - once with its primary name and once with its alias

Screenshot from 2021-06-30 11-08-51.png (422×923 px, 38 KB)

What should have happened instead?:

the parameter should only be displayed one with its primary name

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedBUG REPORTawight
OpenNone
OpenNone
ResolvedWMDE-Fisch
Resolvedawight
DeclinedNone
ResolvedNone
InvalidNone
Resolvedthiemowmde
Resolvedlilients_WMDE
InvalidNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedAndrew-WMDE
ResolvedNone
ResolvedNone
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedLena_WMDE
ResolvedNone
Resolvedawight
ResolvedAndrew-WMDE
InvalidNone
Resolvedthiemowmde
ResolvedBUG REPORTWMDE-Fisch
ResolvedBUG REPORTthiemowmde
ResolvedWMDE-Fisch
OpenBUG REPORTNone
ResolvedECohen_WMDE
OpenNone

Event Timeline

Change 702330 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Skip aliases when filling params from template

https://gerrit.wikimedia.org/r/702330

Change 702329 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix spec.fillFromTemplate() not skipping aliases any more

https://gerrit.wikimedia.org/r/702329

Change 702329 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix spec.fillFromTemplate() not skipping aliases any more

https://gerrit.wikimedia.org/r/702329