Page MenuHomePhabricator

drop an upload from the mismatch store based on its ID
Closed, ResolvedPublic5 Estimated Story Points

Description

As a mismatch store admin I want to be able to remove a complete upload from the store in order to remove uploads that turned out to be faulty.

Problem:
Cases might arise where we want to drop a complete upload from the store. We need to make this possible for an admin of the store (aka the Mismatch Finder team). Potential scenarios where this could happen:

  • an institution provides us with a mismatch file and we import it. After a while editors start complaining that the mismatches are not useful. After some digging we find out that the comparisons they've done were wrong, invalidating a large percentage of the mismatches in the upload

BDD
GIVEN an upload ID
WHEN requested
THEN an admin can drop the complete upload from the database

Acceptance criteria:

  • we have some way to drop a complete upload based on its ID

Notes:

  • non-reversible is ok
  • it is ok if even mismatches that were already reviewed are dropped
  • should be done via ssh
  • submission of review decisions for dropped uploads lead to an error (already implemented generic error message is ok) (see T295990)

Event Timeline

Lydia_Pintscher renamed this task from drop an upload from the database to drop an upload from the mismatch store based on its ID.Jun 30 2021, 10:57 AM
Lydia_Pintscher set the point value for this task to 5.

Estimation Notes:

  • We can make this happen by creating an additional artisan script to drop imports and mismatches by id
karapayneWMDE set the point value for this task to 5.Nov 2 2021, 3:31 PM

Notes from task breakdown:

  • add a new artisan command to drop an import by its ID
  • when an import is dropped, all of the associated mismatches are dropped as well

Can someone give me a quick hint how I would drop an upload now so I can test it?

Silvan and I went over it and it works beautifully \o/

TODO left for me: get toolforge account set up and added to the project.