Page MenuHomePhabricator

[wmf.12-regression] mobile - Suggested edits initial load is not functional
Closed, ResolvedPublic

Description

  1. Create an account on mobile testwiki wmf.12 or use "Restore all default settings (in all sections)" and then enable the Homepage.
  2. Click on a user name to go to Special:Homepage - SE module will never display the image/article title
    Screen Shot 2021-06-30 at 3.05.17 PM.png (1×806 px, 140 KB)
  3. Click on the SE card - the SE module loads but the UI is incorrectly displayed: the filters do not indicate the default and navigational arrows are not working.

Screen Shot 2021-06-30 at 3.05.34 PM.png (1×992 px, 105 KB)

The following error is displayed and the UI is unresponsive:

Uncaught TypeError: Cannot read property 'token' of undefined
 at NewcomerTaskLogger.log
 at SuggestedEditsModule.logCardData
 at SuggestedEditsModule.showCard
 at initSuggestedTasks
  1. Clicking on the filters (without selection any of the filters) will incorrectly display - "No suggestions found", but the filters will have a correct display of per-selected (default) filters.
    Screen Shot 2021-06-30 at 3.05.49 PM.png (1×838 px, 100 KB)
  2. Reloading the page will fix the issue.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 702608 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Quick fix for T285906

https://gerrit.wikimedia.org/r/702608

Tgr edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Tgr moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Not properly fixed yet but this makes the error non-user-visible.

Change 702616 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702616

Change 702608 abandoned by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] Quick fix for T285906

Reason:

Done differently in Ia21aeea8866e4d

https://gerrit.wikimedia.org/r/702608

Change 702403 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.11] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702403

Change 702404 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702404

Change 702403 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.11] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702403

Change 702404 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702404

Mentioned in SAL (#wikimedia-operations) [2021-07-01T12:20:40Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.11/extensions/GrowthExperiments/: Backport: [[gerrit:702401|Welcome tour: Mark as complete when notice is shown (T284800)]] [[gerrit:702403|SuggestedEdits: Return default JS data as 'noresults' (T285906)]] (duration: 01m 09s)

Mentioned in SAL (#wikimedia-operations) [2021-07-01T12:22:56Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/GrowthExperiments/: Backport: [[gerrit:702402|Welcome tour: Mark as complete when notice is shown (T284800)]] [[gerrit:702404|SuggestedEdits: Return default JS data as 'noresults' (T285906)]] (duration: 01m 08s)

Change 702616 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702616

With the patch, a "No suggestions found" page shows up but then is replaced by tasks as the API request finished. It's slightly confusing but doesn't require reloading. We should probably show a loading screen instead, but that seems nontrivial and we probably don't want to try doing it in time for the pilot.

Checked in testwiki wmf.14 - as noted in the comment above, "No suggestions found" is briefly shown; otherwise the fix(es) are in place.