Page MenuHomePhabricator
Create Task
Maniphest T285906

[wmf.12-regression] mobile - Suggested edits initial load is not functional
Closed, ResolvedPublic
Actions

Assigned To
Tgr
Authored By
Etonkovidova
Jun 30 2021, 10:18 PM
Tags
Referenced Files
F34533589: Screen Shot 2021-06-30 at 3.05.49 PM.png
Jun 30 2021, 10:18 PM
F34533586: Screen Shot 2021-06-30 at 3.05.34 PM.png
Jun 30 2021, 10:18 PM
F34533581: Screen Shot 2021-06-30 at 3.05.17 PM.png
Jun 30 2021, 10:18 PM
Subscribers
Aklapper
Etonkovidova
kostajh
• mewoph
MMiller_WMF
Tgr
Urbanecm_WMF

Description

  1. Create an account on mobile testwiki wmf.12 or use "Restore all default settings (in all sections)" and then enable the Homepage.
  2. Click on a user name to go to Special:Homepage - SE module will never display the image/article title
    Screen Shot 2021-06-30 at 3.05.17 PM.png (1×806 px, 140 KB)
  3. Click on the SE card - the SE module loads but the UI is incorrectly displayed: the filters do not indicate the default and navigational arrows are not working.

Screen Shot 2021-06-30 at 3.05.34 PM.png (1×992 px, 105 KB)

The following error is displayed and the UI is unresponsive:

Uncaught TypeError: Cannot read property 'token' of undefined
 at NewcomerTaskLogger.log
 at SuggestedEditsModule.logCardData
 at SuggestedEditsModule.showCard
 at initSuggestedTasks
  1. Clicking on the filters (without selection any of the filters) will incorrectly display - "No suggestions found", but the filters will have a correct display of per-selected (default) filters.
    Screen Shot 2021-06-30 at 3.05.49 PM.png (1×838 px, 100 KB)
  2. Reloading the page will fix the issue.

Details

SubjectRepoBranchLines +/-
SuggestedEdits: Return default JS data as 'noresults'mediawiki/extensions/GrowthExperimentsmaster+1 -1
SuggestedEdits: Return default JS data as 'noresults'mediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.11+1 -1
SuggestedEdits: Return default JS data as 'noresults'mediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.12+1 -1
Quick fix for T285906mediawiki/extensions/GrowthExperimentsmaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jun 30 2021, 10:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 30 2021, 10:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a project: Mobile.Jun 30 2021, 11:56 PM
Jdlrobson moved this task from Needs triage to Growth on the Mobile board.Jun 30 2021, 11:58 PM
gerritbot added a comment.Jul 1 2021, 10:52 AM

Change 702608 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Quick fix for T285906

https://gerrit.wikimedia.org/r/702608

gerritbot added a project: Patch-For-Review.Jul 1 2021, 10:52 AM
Tgr claimed this task.Jul 1 2021, 10:53 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Not properly fixed yet but this makes the error non-user-visible.

gerritbot added a comment.Jul 1 2021, 11:07 AM

Change 702616 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702616

gerritbot added a comment.Jul 1 2021, 11:33 AM

Change 702608 abandoned by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] Quick fix for T285906

Reason:

Done differently in Ia21aeea8866e4d

https://gerrit.wikimedia.org/r/702608

gerritbot added a comment.Jul 1 2021, 11:34 AM

Change 702403 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.11] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702403

gerritbot added a comment.Jul 1 2021, 11:34 AM

Change 702404 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702404

gerritbot added a comment.Jul 1 2021, 11:58 AM

Change 702403 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.11] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702403

gerritbot added a comment.Jul 1 2021, 11:59 AM

Change 702404 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702404

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 1 2021, 12:00 PM
Stashbot mentioned this in T284800: Account creation: URL parameters.Jul 1 2021, 12:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-01T12:20:40Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.11/extensions/GrowthExperiments/: Backport: [[gerrit:702401|Welcome tour: Mark as complete when notice is shown (T284800)]] [[gerrit:702403|SuggestedEdits: Return default JS data as 'noresults' (T285906)]] (duration: 01m 09s)

Stashbot added a comment.Jul 1 2021, 12:22 PM

Mentioned in SAL (#wikimedia-operations) [2021-07-01T12:22:56Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/GrowthExperiments/: Backport: [[gerrit:702402|Welcome tour: Mark as complete when notice is shown (T284800)]] [[gerrit:702404|SuggestedEdits: Return default JS data as 'noresults' (T285906)]] (duration: 01m 08s)

gerritbot added a comment.Jul 1 2021, 12:45 PM

Change 702616 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Return default JS data as 'noresults'

https://gerrit.wikimedia.org/r/702616

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 1 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2021, 1:10 PM
Tgr added a comment.Jul 1 2021, 3:09 PM

With the patch, a "No suggestions found" page shows up but then is replaced by tasks as the API request finished. It's slightly confusing but doesn't require reloading. We should probably show a loading screen instead, but that seems nontrivial and we probably don't want to try doing it in time for the pilot.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 2 2021, 8:05 AM
Etonkovidova closed this task as Resolved.Jul 13 2021, 9:40 PM

Checked in testwiki wmf.14 - as noted in the comment above, "No suggestions found" is briefly shown; otherwise the fix(es) are in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL