Page MenuHomePhabricator

Accessiblity audit
Closed, ResolvedPublic

Assigned To
Authored By
MattCleinman
Jun 30 2021, 11:15 PM
Referenced Files
F34550299: List_item_image_description_and_size.jpg
Jul 13 2021, 11:21 PM
F34550312: SE_contribution_category_button.jpg
Jul 13 2021, 11:21 PM
F34550301: SE_contribution_back_button.jpg
Jul 13 2021, 11:21 PM
F34550306: SE_add_translate_button.jpg
Jul 13 2021, 11:21 PM
F34550303: Activity_title.jpg
Jul 13 2021, 11:21 PM
F34550311: OTD_year_label.jpg
Jul 13 2021, 11:21 PM
F34550305: Talk_page_comments.jpg
Jul 13 2021, 11:21 PM
F34550309: OTD_view_pager_indicators.jpg
Jul 13 2021, 11:21 PM
Tokens
"Like" token, awarded by Volker_E.

Description

Check (focusing on newer features) for accessibility support.

Possibly also use accessibility scanner to help with this: T268216: Consider suggestions provided by Google's Accessibility Scanner.

Event Timeline

Hi @schoenbaechler,

Here are the findings from Google's Accessibility scanner app and mostly are focusing on missing descriptions and small labels or buttons.

There are some other suggestions such as text contrast or icon color contrast may not be applied here and it requires your input. For a quick check, please download Google's Accessibility scanner app to check.

Please let me know your suggestions on the following findings, and I will work on them, thanks!

Edits feed(Suggested edits)
SE_image_label.jpg (2×1 px, 685 KB)
Image requires description.
SE_image_label(1).jpg (2×1 px, 502 KB)
Image requires description.
SE_publish_button.jpg (2×1 px, 224 KB)
Publish button needs larger size (48dp).
Contributions
SE_contribution_category_button.jpg (2×1 px, 314 KB)
Category buttons needs larger size.
SE_contribution_back_button.jpg (2×1 px, 259 KB)
Back button requires button label.
Edits
SE_top_panel_button.jpg (2×1 px, 362 KB)
Top label clickable area needs larger size (long press to trigger).
SE_add_translate_button.jpg (2×1 px, 335 KB)
The tasks buttons have the same name (add/translate).
General
Activity_title.jpg (2×1 px, 233 KB)
Activities titles have the exact same names on bottom navigation bar buttons.
List_item_image_description_and_size.jpg (2×1 px, 208 KB)
List item image requires description, and make the image not clickable.
Feed_more_button.jpg (2×1 px, 315 KB)
More button needs larger size.
On this day
OTD_year_label.jpg (2×1 px, 390 KB)
Year label clickable area needs larger size.
OTD_view_pager_indicators.jpg (2×1 px, 312 KB)
View pager indicators needs larger size.
Watchlist
Watchlist_username_button.jpg (2×1 px, 324 KB)
Username label has the same name.
Watchlist_top_category_buttons.jpg (2×1 px, 311 KB)
Top category button needs larger size.
Watchlist_prev_next_button.jpg (2×1 px, 255 KB)
Next / previous buttons need larger size.
Watchlist_more_button.jpg (2×1 px, 169 KB)
More button requires description

Talk page

Talk_page_comments.jpg (2×1 px, 265 KB)
Comments need minimum height.

Hey Cooltey, I haven’t forgotten about this but added it to my list of things to process when I’m back on July 26. Excited to make the app more accessible with you! 🚀

Thanks for the hard work on this @cooltey!

Edits feed(Suggested edits)
SE_image_label.jpg (2×1 px, 685 KB)
Image requires description.
SE_image_label(1).jpg (2×1 px, 502 KB)
Image requires description.

For the alt text, please use the following:

  1. Use structured caption from Commons
  2. If not available, use unstructured description from commons
  3. If not available, use Wikipedia’s image description
SE_publish_button.jpg (2×1 px, 224 KB)
Publish button needs larger size (48dp).

Keep the button’s size but increase it’s tap target to meet the 48dp minimum (in this case → add invisible 2dp padding).

Contributions
SE_contribution_category_button.jpg (2×1 px, 314 KB)
Category buttons needs larger size.

Keep the button’s size but increase it’s tap target to meet the 48dp minimum (add padding).

SE_contribution_back_button.jpg (2×1 px, 259 KB)
Back button requires button label.

Add a label (consider translatewiki).

Edits
SE_top_panel_button.jpg (2×1 px, 362 KB)
Top label clickable area needs larger size (long press to trigger).

Add top and bottom padding to the clickable area to meet a 48dp height.

SE_add_translate_button.jpg (2×1 px, 335 KB)
The tasks buttons have the same name (add/translate).

Use the right terminology/label for each button.

General
Activity_title.jpg (2×1 px, 233 KB)
Activities titles have the exact same names on bottom navigation bar buttons.

Is this an accessibility issue? I think design and label consistency with the bottom navigation is a good thing here. The label in the bottom navigation is small and could be cut off.

List_item_image_description_and_size.jpg (2×1 px, 208 KB)
List item image requires description, and make the image not clickable.

For the alt text, please use the following:

  1. Use structured caption from Commons
  2. If not available, use unstructured description from commons
  3. If not available, use Wikipedia’s image description

I think the image should be clickable but have the same tap target as the entire list item (1 call to action).

Feed_more_button.jpg (2×1 px, 315 KB)
More button needs larger size.

Increase its padding to at least 12dp (the icon is 24dp + 12dp on each side = 48dp)

On this day
OTD_year_label.jpg (2×1 px, 390 KB)
Year label clickable area needs larger size.

Use top and bottom padding of the entire area to increase its tap target to at least 48dp. Please do not alternate the text’s line height.

OTD_view_pager_indicators.jpg (2×1 px, 312 KB)
View pager indicators needs larger size.

I think it’s fine like that as it’s “swipeable”. The dots are not intended to be tapped here.

Watchlist
Watchlist_username_button.jpg (2×1 px, 324 KB)
Username label has the same name.

What does that mean exactly? Should we, e.g. use User profile page: Cooltey to provide more context?

Watchlist_top_category_buttons.jpg (2×1 px, 311 KB)
Top category button needs larger size.

Increase the button’s invisible padding (to meet 48dp) but keep it’s visual size as is.

Watchlist_prev_next_button.jpg (2×1 px, 255 KB)
Next / previous buttons need larger size.

Increase its padding to at least 12dp (the icon is 24dp + 12dp on each side = 48dp)

Watchlist_more_button.jpg (2×1 px, 169 KB)
More button requires description

Use the same description/label as in other places where the button is used, e.g. “More menu item”

Talk page

Talk_page_comments.jpg (2×1 px, 265 KB)
Comments need minimum height.

I don’t think this one’s feasible, I think we have a similar issue for links in Wikipedia articles. The least we could do though is use a line height, that improves the link’s tap target. In this case, it seems like 14sp is used. Let’s use font_group_3 to increase it’s tap target height to 21sp.


cc @Volker_E to make the accessibility work for Android more visible!

Thanks @schoenbaechler

In T285911#7284944, @schoenbaechler wrote:

Thanks for the hard work on this @cooltey!

Edits feed(Suggested edits)
SE_image_label.jpg (2×1 px, 685 KB)
Image requires description.
SE_image_label(1).jpg (2×1 px, 502 KB)
Image requires description.

For the alt text, please use the following:

  1. Use structured caption from Commons
  2. If not available, use unstructured description from commons
  3. If not available, use Wikipedia’s image description

If we want to get the description above, it will take extra API calls for each image, it should be fine to just use "Image of [Title]", does that sounds good to you?

General
Activity_title.jpg (2×1 px, 233 KB)
Activities titles have the exact same names on bottom navigation bar buttons.

Is this an accessibility issue? I think design and label consistency with the bottom navigation is a good thing here. The label in the bottom navigation is small and could be cut off.

It makes sense to me.

List_item_image_description_and_size.jpg (2×1 px, 208 KB)
List item image requires description, and make the image not clickable.

For the alt text, please use the following:

I think the image should be clickable but have the same tap target as the entire list item (1 call to action).

The same thing as above and done.

OTD_view_pager_indicators.jpg (2×1 px, 312 KB)
View pager indicators needs larger size.

I think it’s fine like that as it’s “swipeable”. The dots are not intended to be tapped here.

It makes sense to me.

Watchlist
Watchlist_username_button.jpg (2×1 px, 324 KB)
Username label has the same name.

What does that mean exactly? Should we, e.g. use User profile page: Cooltey to provide more context?

I update the content description to "Talk: [User name]" and it should be fine for rest of other items.

Talk page

Talk_page_comments.jpg (2×1 px, 265 KB)
Comments need minimum height.

I don’t think this one’s feasible, I think we have a similar issue for links in Wikipedia articles. The least we could do though is use a line height, that improves the link’s tap target. In this case, it seems like 14sp is used. Let’s use font_group_3 to increase it’s tap target height to 21sp.

You are correct. I'll leave the text as it is.

All good to go from my end @cooltey — the suggestion to use Image of [Title] is fine too — if it translates well? Maybe just Image: [Title] works better in multiple languages? Thanks!

In T285911#7321110, @schoenbaechler wrote:

All good to go from my end @cooltey — the suggestion to use Image of [Title] is fine too — if it translates well? Maybe just Image: [Title] works better in multiple languages? Thanks!

Sounds good. I can do that :)

Moving this to QA signoff. @ABorbaWMF → You’ll find the base your review in this comment: T285911#7284944. Thanks a lot!