Page MenuHomePhabricator

Template parameter search: partial match blocks adding undocumented parameter
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • insert a new template with visual editor
  • use the add more information element to insert a documented parameter ("Foo") and an undocumented parameter ("Test")
  • delete both
  • try to insert the undocumented one again

What happens?:
The documented parameter "Foo" is being highlighted (beause it contains "Test" in the description) and it is not possible to create an undocumented parameter "tes" (click to view screencast).

Peek 2021-07-01 11-54.gif (754×991 px, 503 KB)

What should have happened instead?:
The matching parameter "Test" should appear at the top and it should allow adding a new undocumented parameter "tes".

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedBUG REPORTawight
OpenNone
OpenNone
ResolvedWMDE-Fisch
Resolvedawight
DeclinedNone
ResolvedNone
InvalidNone
Resolvedthiemowmde
Resolvedlilients_WMDE
InvalidNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedAndrew-WMDE
ResolvedNone
ResolvedNone
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedLena_WMDE
ResolvedNone
Resolvedawight
ResolvedAndrew-WMDE
InvalidNone
Resolvedthiemowmde
ResolvedBUG REPORTthiemowmde
ResolvedBUG REPORTthiemowmde
ResolvedWMDE-Fisch
OpenBUG REPORTNone
ResolvedECohen_WMDE
OpenNone

Event Timeline

Change 702643 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [POC] Fix parameter search being to relaxed on unknown params

https://gerrit.wikimedia.org/r/702643

thiemowmde renamed this task from Search input field patches wrong parameter to Template parameter search: partial match blocks adding undocumented parameter.Jul 1 2021, 12:35 PM
thiemowmde added a subscriber: thiemowmde.
WMDE-Fisch set the point value for this task to 2.Jul 2 2021, 7:30 AM

Change 702643 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix parameter search being to relaxed on unknown params

https://gerrit.wikimedia.org/r/702643

To better surface the now always present result at the top of the suggestion, that let's you add an undocumented parameter, we decided to set change the style of the descriptive text underneath Unknown field by putting it into parenthesis and formatting it italic.