Adopt the solution outlined at T285285.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Lock selection to a single side in diffs | mediawiki/core | master | +127 -42 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • NRodriguez | T287177 [EPIC] Copy and Paste from Diffs | |||
| Resolved | BUG REPORT | Daimona | T290731 Support diffs copy and paste for RTL languages | ||
| Resolved | • NRodriguez | T285857 Deploy wikidiff2 1.13.0 | |||
| Resolved | Release | WMDE-Fisch | T285856 Release new version of wikidiff2 with side-locking selection | ||
| Resolved | Feature | Daimona | T285793 Lock selection to a single side in wikidiff2 | ||
| Resolved | Feature | Daimona | T285956 Lock selection to a single side in TableDiffFormatter |
Event Timeline
Comment Actions
Change 701104 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Lock selection to a single side in diffs
Comment Actions
Change 701104 merged by jenkins-bot:
[mediawiki/core@master] Lock selection to a single side in diffs
Comment Actions
Merged! QA notes: This is not testable on the beta cluster or in prod. You'll have to test on your local machine or use Patch Demo.
That said, the JavaScript changes included with https://gerrit.wikimedia.org/r/701104 will go live on Beta and prod and loaded on diff pages. This JavaScript isn't supposed to have any effect yet, since it looks for CSS classes that won't exist until T285857 is resolved, but I thought I'd let you know so you can check for any weirdness. The changes involved here have to do with selecting text.
Comment Actions
I have tested this very briefly on https://test.wikipedia.org (e.g. https://test.wikipedia.org/w/index.php?title=Main_Page&action=historysubmit&type=revision&diff=470140&oldid=448939).
I have not noticed any visual differences after these changes.
There seems to be some weird behaviour when trying to perform some actions with the mouse (as outlined in T288421).
I have tried a few keyboard shortcuts for selecting text (e.g. shift+arrow key, ctrl+shift+arrow, shift+end) and these seem to work as I would expect them to.
More thorough testing will be done when T285857 is complete.
Test Environment: https://test.wikipedia.org MediaWiki 1.37.0-wmf.17 (rMW730ddbb90c6f) 18:07, 5 August 2021.
Test Browser: Firefox 78
Comment Actions
@dom_walden and @Daimona i am having a hard time understanding if the scope of this change should allow me to just select one column using my mouse to select on the page-- or if that's something that will be able to test once we release T285857? Thanks and sorry about the confusion!
When I test on the test.wikipedia.org I still select both columns when I try to copy and paste from the diff, but they do indeed paste as coherent text with each column coming after the other. Lmk if that's the scope of this work. thanks all!
Comment Actions
Yep, this change allows you to select just one column, but it's not testable in production (testwiki and beta included). The only way to test it currently is to do that locally, or use something like patchdemo. I've created https://patchdemo.wmflabs.org/wikis/4e717c5832/wiki/Main_Page for you to be able to test it easily.