Page MenuHomePhabricator
Create Task
Maniphest T285967

Add a link: title in link inspector is misaligned on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable link recommendations
  • Go to Special:Homepage
  • Click on task card

What happens?:

Screen Shot 2021-07-01 at 9.49.20 AM.png (1×626 px, 338 KB)

Details

SubjectRepoBranchLines +/-
Add a link: fix title alignment in link inspector alignment (mobile)mediawiki/extensions/GrowthExperimentsmaster+6 -0
Customize query in gerrit

Event Timeline

• mewoph created this task.Jul 1 2021, 4:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2021, 4:52 PM
• mewoph claimed this task.Jul 1 2021, 4:52 PM
• mewoph moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph added a comment.Jul 1 2021, 5:30 PM

This was working before since it implicitly relied on display: block from Minerva, which is no longer there in the latest version.

gerritbot added a comment.Jul 1 2021, 5:39 PM

Change 702703 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: fix title alignment in link inspector alignment (mobile)

https://gerrit.wikimedia.org/r/702703

gerritbot added a project: Patch-For-Review.Jul 1 2021, 5:39 PM
• mewoph moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 1 2021, 5:40 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 2 2021, 8:23 AM
gerritbot added a comment.Jul 2 2021, 8:42 AM

Change 702703 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: fix title alignment in link inspector alignment (mobile)

https://gerrit.wikimedia.org/r/702703

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 2 2021, 9:11 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 2 2021, 11:16 PM
Etonkovidova subscribed.

Checked in betalabs - the issue is fixed:

Screen Shot 2021-07-02 at 4.14.52 PM.png (1×848 px, 202 KB)

kostajh moved this task from Backlog to Done / QA on the Add-Link board.Jul 8 2021, 5:08 PM
Etonkovidova closed this task as Resolved.Jul 13 2021, 9:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL