Page MenuHomePhabricator
Create Task
Maniphest T285978

AbuseFilterCachingParser: PHP Warning: mb_strpos(): Offset not contained in string
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: mb_strpos(): Offset not contained in string
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(1272)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(1272): mb_strpos(string, string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(721): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->funcStrPos(array)
#3 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(480): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->callFunc(string, array)
#4 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(1458): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#5 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(590): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->maybeDiscardNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#6 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(599): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#7 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(670): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#8 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(577): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#9 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(568): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#10 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(568): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#11 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(568): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#12 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(568): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#13 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(1458): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#14 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(573): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->maybeDiscardNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#15 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(411): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode)
#16 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(337): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->evalTree(MediaWiki\Extension\AbuseFilter\Parser\AFPSyntaxTree)
#17 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(278): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->intEval(string)
#18 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Parser/AbuseFilterCachingParser.php(295): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->checkSyntaxThrow(string)
#19 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/View/AbuseFilterViewTestBatch.php(220): MediaWiki\Extension\AbuseFilter\Parser\AbuseFilterCachingParser->checkSyntax(string)
#20 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/View/AbuseFilterViewTestBatch.php(208): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewTestBatch->doTest()
#21 /srv/mediawiki/php-1.37.0-wmf.12/extensions/AbuseFilter/includes/Special/SpecialAbuseFilter.php(167): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewTestBatch->show()
#22 /srv/mediawiki/php-1.37.0-wmf.12/includes/specialpage/SpecialPage.php(646): MediaWiki\Extension\AbuseFilter\Special\SpecialAbuseFilter->execute(string)
#23 /srv/mediawiki/php-1.37.0-wmf.12/includes/specialpage/SpecialPageFactory.php(1362): SpecialPage->run(string)
#24 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#25 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(917): MediaWiki->performRequest()
#26 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(551): MediaWiki->main()
#27 /srv/mediawiki/php-1.37.0-wmf.12/index.php(53): MediaWiki->run()
#28 /srv/mediawiki/php-1.37.0-wmf.12/index.php(46): wfIndexMain()
#29 /srv/mediawiki/w/index.php(3): require(string)
#30 {main}
Impact

Unclear.

Notes

6 of these since deploy of 1.37.0-wmf.12 (T281153) to all wikis at 19:45 UTC.

cc: @DannyS712 since I notice a recent commit there.

Details

Request URL
https://ja.wikipedia.org/wiki/%E7%89%B9%E5%88%A5:%E4%B8%8D%E6%AD%A3%E5%88%A9%E7%94%A8%E3%83%95%E3%82%A3%E3%83%AB%E3%82%BF%E3%83%BC/test
ProjectBranchLines +/-Subject
mediawiki/extensions/AbuseFiltermaster+8 -2Avoid passing invalid offset to mb_strpos
mediawiki/extensions/AbuseFilterwmf/1.37.0-wmf.12+8 -2Avoid passing invalid offset to mb_strpos
mediawiki/extensions/AbuseFilterwmf/1.37.0-wmf.13+8 -2Avoid passing invalid offset to mb_strpos
Customize query in gerrit

Related Objects

Event Timeline

brennen created this task.Jul 1 2021, 8:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2021, 8:19 PM
brennen added a project: Platform Engineering.Jul 1 2021, 8:20 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
Zabe added a subscriber: Zabe.Jul 1 2021, 9:08 PM
Daimona claimed this task.Jul 2 2021, 11:04 AM
Daimona moved this task from Untriaged to Older on the Wikimedia-production-error board.
gerritbot added a comment.Jul 2 2021, 11:13 AM

Change 702915 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] Avoid passing invalid offset to mb_strpos

https://gerrit.wikimedia.org/r/702915

gerritbot added a project: Patch-For-Review.Jul 2 2021, 11:13 AM
dancy added a subscriber: dancy.Jul 12 2021, 4:07 PM
dancy added a comment.Jul 12 2021, 4:18 PM

Hi @Daimona. Can you prepare a cherry pick of the fix for wmf/1.37.0-wmf.12?

gerritbot added a comment.Jul 12 2021, 4:27 PM

Change 703902 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@wmf/1.37.0-wmf.13] Avoid passing invalid offset to mb_strpos

https://gerrit.wikimedia.org/r/703902

Daimona added a comment.Jul 12 2021, 4:27 PM
In T285978#7206208, @dancy wrote:

Hi @Daimona. Can you prepare a cherry pick of the fix for wmf/1.37.0-wmf.12?

Yup, done.

Zabe added a comment.Jul 12 2021, 4:28 PM
In T285978#7206223, @Daimona wrote:
In T285978#7206208, @dancy wrote:

Hi @Daimona. Can you prepare a cherry pick of the fix for wmf/1.37.0-wmf.12?

Yup, done.

Your patch is for wmf.13, not wmf.12.

gerritbot added a comment.Jul 12 2021, 5:23 PM

Change 703904 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@wmf/1.37.0-wmf.12] Avoid passing invalid offset to mb_strpos

https://gerrit.wikimedia.org/r/703904

Daimona added a comment.Jul 12 2021, 5:24 PM
In T285978#7206225, @Zabe wrote:
In T285978#7206223, @Daimona wrote:
In T285978#7206208, @dancy wrote:

Hi @Daimona. Can you prepare a cherry pick of the fix for wmf/1.37.0-wmf.12?

Yup, done.

Your patch is for wmf.13, not wmf.12.

Whoops, fixed. I've left the other one around in case it will be necessary later.

BPirkle edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Jul 13 2021, 5:33 PM
dancy added a comment.Jul 14 2021, 3:43 PM

What's a good way to test this change?

Daimona added a comment.Jul 14 2021, 3:48 PM
In T285978#7212494, @dancy wrote:

What's a good way to test this change?

Going to Special:AbuseFilter/tools, writing strpos( "foo", "o", 123456 ) === -1 in the big text field, hitting "Evaluate", and making sure that no PHP warning is emitted (on logstash). This is also what caused the reported issue in the first place: somebody using that interface to test code. Unfortunately, it's impossible to get any feedback on-wiki because this is just a warning in PHP 7.2-7.4.

dancy added a comment.Jul 14 2021, 3:51 PM
In T285978#7212530, @Daimona wrote:
In T285978#7212494, @dancy wrote:

What's a good way to test this change?

Going to Special:AbuseFilter/tools, writing strpos( "foo", "o", 123456 ) === -1 in the big text field, hitting "Evaluate", and making sure that no PHP warning is emitted (on logstash). This is also what caused the reported issue in the first place: somebody using that interface to test code. Unfortunately, it's impossible to get any feedback on-wiki because this is just a warning in PHP 7.2-7.4.

Looks like my Wikipedia account doesn't have permission to do that so I'll send you a note when the change has been deployed to mwdebug servers and I'll ask you to test.

gerritbot added a comment.Jul 15 2021, 12:59 AM

Change 703902 abandoned by DannyS712:

[mediawiki/extensions/AbuseFilter@wmf/1.37.0-wmf.13] Avoid passing invalid offset to mb_strpos

Reason:

1.37.0-wmf.13 was cancelled due to WMF holiday, see https://wikitech.wikimedia.org/wiki/Deployments/Yearly_calendar and T281154

https://gerrit.wikimedia.org/r/703902

Krinkle added a subscriber: Krinkle.Jul 15 2021, 3:00 AM

(Just noting here for intra-task record that this could have been verified in Beta Cluster already if it weren't for Logstash being down there as of last quarter. Ref T233134.)

thcipriani added a subscriber: thcipriani.Aug 11 2021, 6:37 PM

Note: this is still happening as of 1.37.0-wmf.17 at a rate of about 10/day -- concentrated on jawiki right now.

gerritbot added a comment.Aug 18 2021, 6:45 PM

Change 702915 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Avoid passing invalid offset to mb_strpos

https://gerrit.wikimedia.org/r/702915

gerritbot added a comment.Aug 18 2021, 6:45 PM

Change 703904 abandoned by Daimona Eaytoy:

[mediawiki/extensions/AbuseFilter@wmf/1.37.0-wmf.12] Avoid passing invalid offset to mb_strpos

Reason:

https://gerrit.wikimedia.org/r/703904

Daimona closed this task as Resolved.Aug 18 2021, 6:45 PM
Daimona removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 18 2021, 7:00 PM
dancy reopened this task as Open.Aug 25 2021, 7:07 PM

A couple of these were seen today. Still jawiki. Most recent request id: cc0ef11e-249b-4683-81da-f0649099bc64

Daimona added a comment.Aug 25 2021, 7:16 PM
In T285978#7309946, @dancy wrote:

A couple of these were seen today. Still jawiki. Most recent request id: cc0ef11e-249b-4683-81da-f0649099bc64

Jawiki is still on wmf.19, isn't it?

dancy added a comment.Aug 25 2021, 7:20 PM
In T285978#7309983, @Daimona wrote:
In T285978#7309946, @dancy wrote:

A couple of these were seen today. Still jawiki. Most recent request id: cc0ef11e-249b-4683-81da-f0649099bc64

Jawiki is still on wmf.19, isn't it?

Yes. Is the issue expected to be fixed in .20?

Krinkle added a comment.Aug 26 2021, 1:22 AM

I believe so. Change 702915 merged last Wednesday and says "Included in: master, wmf/1.37.0-wmf.20" (and doesn't appear to have been backported).

Daimona added a comment.Aug 26 2021, 10:59 AM

Confirming that. We can leave this open until .20 is rolled out everywhere.

dancy mentioned this in T281161: 1.37.0-wmf.20 deployment blockers.Aug 26 2021, 10:07 PM
dancy closed this task as Resolved.Aug 27 2021, 2:39 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL