Page MenuHomePhabricator
Create Task
Maniphest T286110

Remove language URL parameter in "Translate this page" link
Closed, ResolvedPublicBUG REPORT
Actions

Description

At the top of any translatable page (example), there is a “Translate this page” small text which links to Special:Translate?group=page-PAGE_NAME&language=USELANG&action=page&filter= where PAGE_NAME is the name of the page, and USELANG is the user interface language code (example).

If MediaWiki interface is in French, language parameter is: &language=fr.
If MediaWiki interface is in English, language parameter is: &language=en.

This parameter is useless, because it automatically defaults to MediaWiki interface language when it is not set.

It is sometimes problematic, when page authors want to share this “translate” link: they share a link which will display a warning message: “The source language of this group is English. Please select another language to translate into.” because they have written the page in their own language (same than for their user interface).

Most of links shared to Translators-l have this issue.

Outcome

Removed the language attribute from the "Translate this page" link on the translatable page.

Details

SubjectRepoBranchLines +/-
Remove language attribute for Translate link on source pagemediawiki/extensions/Translatemaster+5 -3
Customize query in gerrit

Event Timeline

Pols12 created this task.Jul 3 2021, 12:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2021, 12:49 PM
Aklapper renamed this task from Remove language URL parameter in Translate this pagel link to Remove language URL parameter in "Translate this page" link.Jul 4 2021, 8:21 AM
abi_ subscribed.Jul 14 2021, 5:04 AM

We discussed this and we think it would make sense to have USELANG be the language of the translation page being viewed, so clicking on the "Translate this page" link when viewing the French translation would set USELANG to be fr. For the source translation page, we could skip USELANG altogether.

Tacsipacsi subscribed.Jul 14 2021, 1:12 PM

For translated pages, this is already the case: the translate link of m:Wikimedia movement/de contains language=de regardless of the UI language.

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Jul 19 2021, 10:53 AM
Pols12 added a comment.Jul 30 2021, 12:54 AM

Given the “Translate this page” link is copied from source page in most cases, I have no opposition to use translation language code for language parameter value in translated pages (it is already the case, as Tacsipacsi said).
If this parameter is removed in link in source page, this is sufficient for me. 🙂

Pginer-WMF triaged this task as Medium priority.Sep 7 2021, 9:13 AM
Pginer-WMF added a project: Language-Team (Language-2021-July-September).
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2021-July-September) board.
gerritbot added a comment.Sep 13 2021, 7:15 AM

Change 720664 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Remove language attribute for Translate link on source page

https://gerrit.wikimedia.org/r/720664

gerritbot added a project: Patch-For-Review.Sep 13 2021, 7:15 AM
abi_ claimed this task.Sep 13 2021, 7:15 AM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2021-July-September) board.
gerritbot added a comment.Sep 13 2021, 12:18 PM

Change 720664 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove language attribute for Translate link on source page

https://gerrit.wikimedia.org/r/720664

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 13 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 13 2021, 1:10 PM
abi_ closed this task as Resolved.Sep 15 2021, 4:32 PM
abi_ moved this task from In Review to Done on the Language-Team (Language-2021-July-September) board.

This is deployed on translatewiki.net and tested.

image.png (657×1 px, 179 KB)

abi_ updated the task description. (Show Details)Sep 15 2021, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL