Page MenuHomePhabricator
Create Task
Maniphest T286139

Remove WikiPage::doEditContent in 1.39
Closed, ResolvedPublic
Actions

Description

Hard deprecated in 1.37, see T255507: WikiPage::doEditContent falls back to $wgUser
Deployed callers have already been updated to avoid needing this fallback, though ideally non-deployed extensions will also be updated

Details

SubjectRepoBranchLines +/-
Remove deprecated WikiPage::doEditContent()mediawiki/coremaster+9 -178
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/Formsmaster+14 -4
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/LinkFiltermaster+11 -4
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/Videomaster+15 -5
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/FanBoxesmaster+13 -2
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/OfflineImportLexiconmaster+6 -1
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/MassEditRegexmaster+2 -1
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/ConfirmAccountmaster+5 -5
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/ImageRatingmaster+10 -4
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/SplitPrivateWikimaster+28 -12
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/SpamDiffToolmaster+6 -1
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/PrivateDomainsmaster+2 -1
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/PhabTaskGraphmaster+17 -4
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/PollNYmaster+13 -4
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/Patrollermaster+15 -5
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/NewsTickermaster+6 -1
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/CloneDiffmaster+8 -2
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/AutoCreateCategoryPagesmaster+6 -1
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/Athenamaster+2 -2
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/Formmaster+15 -5
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/BlogPagemaster+13 -4
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/SocialProfilemaster+65 -23
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/CommentStreamsmaster+0 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 changed the task status from Open to Stalled.Jul 4 2021, 12:06 AM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Untriaged to Not yet on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.

Stalled, cannot be actioned until 1.38

DannyS712 mentioned this in T255507: WikiPage::doEditContent falls back to $wgUser.Jul 4 2021, 12:07 AM
Aklapper renamed this task from Remove WikiPage::doEditContent to Remove WikiPage::doEditContent in 1.38.Jul 19 2021, 11:31 PM
Jdforrester-WMF added a project: MW-1.39-release.Mar 2 2022, 11:07 PM
Jdforrester-WMF subscribed.

Let's postpone this to 1.39.

Jdforrester-WMF renamed this task from Remove WikiPage::doEditContent in 1.38 to Remove WikiPage::doEditContent in 1.39.Mar 2 2022, 11:07 PM
Reedy moved this task from Blocker to To deprecate or remove on the MW-1.39-release board.Mar 3 2022, 6:18 PM
DannyS712 changed the task status from Stalled to In Progress.May 18 2022, 9:24 PM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.May 18 2022, 9:25 PM

Change 792664 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Remove deprecated WikiPage::doEditContent()

https://gerrit.wikimedia.org/r/792664

gerritbot added a project: Patch-For-Review.May 18 2022, 9:25 PM
gerritbot added a comment.May 25 2022, 10:41 PM

Change 799393 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CommentStreams@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799393

gerritbot added a comment.May 25 2022, 10:42 PM

Change 799393 abandoned by DannyS712:

[mediawiki/extensions/CommentStreams@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

Reason:

not calling WikiPage::doEditContent(), but rather a CommentStreamsUtils method

https://gerrit.wikimedia.org/r/799393

gerritbot added a comment.May 25 2022, 10:44 PM

Change 799394 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/SocialProfile@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799394

gerritbot added a comment.May 25 2022, 10:54 PM

Change 799395 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Athena@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799395

gerritbot added a comment.May 25 2022, 10:57 PM

Change 799396 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/AutoCreateCategoryPages@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799396

gerritbot added a comment.May 25 2022, 11:00 PM

Change 799397 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/BlogPage@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799397

gerritbot added a comment.May 25 2022, 11:02 PM

Change 799398 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/CloneDiff@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799398

gerritbot added a comment.May 25 2022, 11:08 PM

Change 799399 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Form@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799399

gerritbot added a comment.May 25 2022, 11:11 PM

Change 799400 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/NewsTicker@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799400

gerritbot added a comment.May 25 2022, 11:19 PM

Change 799401 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Patroller@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799401

gerritbot added a comment.May 25 2022, 11:22 PM

Change 799402 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PhabTaskGraph@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799402

gerritbot added a comment.May 25 2022, 11:37 PM

Change 799394 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799394

DannyS712 mentioned this in rESPR8d5ddc93324a: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:37 PM
gerritbot added a comment.May 25 2022, 11:38 PM

Change 799397 merged by jenkins-bot:

[mediawiki/extensions/BlogPage@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799397

gerritbot added a comment.May 25 2022, 11:38 PM

Change 799399 merged by jenkins-bot:

[mediawiki/extensions/Form@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799399

DannyS712 mentioned this in rEFOR1d879b450d67: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:40 PM
gerritbot added a comment.May 25 2022, 11:44 PM

Change 799403 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PollNY@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799403

gerritbot added a comment.May 25 2022, 11:46 PM

Change 799404 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/PrivateDomains@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799404

gerritbot added a comment.May 25 2022, 11:46 PM

Change 799395 merged by jenkins-bot:

[mediawiki/extensions/Athena@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799395

gerritbot added a comment.May 25 2022, 11:47 PM

Change 799396 merged by jenkins-bot:

[mediawiki/extensions/AutoCreateCategoryPages@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799396

DannyS712 mentioned this in rEATH0d5afa8c40e1: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:47 PM
gerritbot added a comment.May 25 2022, 11:47 PM

Change 799398 merged by jenkins-bot:

[mediawiki/extensions/CloneDiff@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799398

gerritbot added a comment.May 25 2022, 11:47 PM

Change 799405 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/SpamDiffTool@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799405

gerritbot added a comment.May 25 2022, 11:49 PM

Change 799400 merged by jenkins-bot:

[mediawiki/extensions/NewsTicker@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799400

gerritbot added a comment.May 25 2022, 11:49 PM

Change 799401 merged by jenkins-bot:

[mediawiki/extensions/Patroller@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799401

gerritbot added a comment.May 25 2022, 11:49 PM

Change 799446 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/SplitPrivateWiki@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799446

gerritbot added a comment.May 25 2022, 11:49 PM

Change 799403 merged by jenkins-bot:

[mediawiki/extensions/PollNY@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799403

DannyS712 mentioned this in rEPATafe0b97df50d: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:50 PM
gerritbot added a comment.May 25 2022, 11:50 PM

Change 799402 merged by jenkins-bot:

[mediawiki/extensions/PhabTaskGraph@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799402

gerritbot added a comment.May 25 2022, 11:50 PM

Change 799404 merged by jenkins-bot:

[mediawiki/extensions/PrivateDomains@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799404

DannyS712 mentioned this in rEPTG1b0c8554753f: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:51 PM
DannyS712 mentioned this in rEPRD081bdd93ab98: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:53 PM
DannyS712 mentioned this in rENWTc98c5898ee4a: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 25 2022, 11:56 PM
gerritbot added a comment.May 25 2022, 11:56 PM

Change 799405 merged by jenkins-bot:

[mediawiki/extensions/SpamDiffTool@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799405

gerritbot added a comment.May 25 2022, 11:56 PM

Change 799446 merged by jenkins-bot:

[mediawiki/extensions/SplitPrivateWiki@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799446

gerritbot added a comment.May 26 2022, 12:00 AM

Change 799447 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/ImageRating@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799447

DannyS712 mentioned this in rEACP6c714ebc4462: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 26 2022, 12:00 AM
DannyS712 mentioned this in rECDI5941baaffecb: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 26 2022, 12:09 AM
gerritbot added a comment.May 26 2022, 12:10 AM

Change 799447 merged by jenkins-bot:

[mediawiki/extensions/ImageRating@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799447

DannyS712 mentioned this in rEIMR8bc15a114978: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 26 2022, 12:12 AM
gerritbot added a comment.May 26 2022, 12:13 AM

Change 799448 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/ConfirmAccount@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799448

gerritbot added a comment.May 26 2022, 12:15 AM

Change 799449 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MassEditRegex@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799449

gerritbot added a comment.May 26 2022, 12:18 AM

Change 799450 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/OfflineImportLexicon@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799450

gerritbot added a comment.May 26 2022, 12:20 AM

Change 799451 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Video@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799451

gerritbot added a comment.May 26 2022, 12:23 AM

Change 799448 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799448

gerritbot added a comment.May 26 2022, 12:24 AM

Change 799449 merged by jenkins-bot:

[mediawiki/extensions/MassEditRegex@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799449

gerritbot added a comment.May 26 2022, 12:25 AM

Change 799450 merged by jenkins-bot:

[mediawiki/extensions/OfflineImportLexicon@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799450

DannyS712 mentioned this in rECACe2003e237ec9: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 26 2022, 12:25 AM
gerritbot added a comment.May 26 2022, 12:25 AM

Change 799452 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/FanBoxes@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799452

DannyS712 mentioned this in rEOIL2d5e2a49460c: Use WikiPage::doUserEditContent() instead of ::doEditContent().May 26 2022, 12:28 AM
gerritbot added a comment.May 26 2022, 12:29 AM

Change 799453 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/LinkFilter@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799453

gerritbot added a comment.May 26 2022, 12:31 AM

Change 799454 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Forms@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799454

gerritbot added a comment.May 26 2022, 12:39 AM

Change 799452 merged by Jack Phoenix:

[mediawiki/extensions/FanBoxes@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799452

gerritbot added a comment.May 26 2022, 12:42 AM

Change 799451 merged by Jack Phoenix:

[mediawiki/extensions/Video@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799451

gerritbot added a comment.May 26 2022, 12:47 AM

Change 799453 merged by jenkins-bot:

[mediawiki/extensions/LinkFilter@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/799453

gerritbot added a comment.Jun 3 2022, 11:58 PM

Change 792664 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated WikiPage::doEditContent()

https://gerrit.wikimedia.org/r/792664

DannyS712 closed this task as Resolved.Jun 3 2022, 11:59 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 4 2022, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL