Maniphest T286141

Make watchlistUtils non-static
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	DannyS712
	Jul 4 2021, 2:59 AM

Tags

Referenced Files

None

Subscribers

Description

Should be a proper class instead of a bunch of static methods
Will make it easier to address T274599: Allow uncollapsing grouped results which will likely require more logic in watchlistUtils that needs to know about the site (currently we just pass the site around where needed)

Details

	Subject	Repo	Branch	Lines +/-
	Make watchlistUtils non-static	mediawiki/extensions/GlobalWatchlist	master	+69 -57

Customize query in gerrit

Related Objects

Mentioned In: rEGLWd6ec0ae260c1: Make watchlistUtils non-static
T273526: Links in edit summaries should also open in separate tabs
T286309: Links in tags should also open in separate tabs
T286268: Reduce duplication between jQuery/OOUI and Vue versions of the display
Mentioned Here: T274599: Allow uncollapsing grouped results

Event Timeline

DannyS712 created this task.Jul 4 2021, 2:59 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 4 2021, 2:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.Jul 4 2021, 2:59 AM

DannyS712 set the point value for this task to 5.

Change 702954 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] Make watchlistUtils non-static

https://gerrit.wikimedia.org/r/702954

gerritbot added a project: Patch-For-Review.Jul 4 2021, 3:00 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jul 4 2021, 3:40 AM

DannyS712 mentioned this in T286268: Reduce duplication between jQuery/OOUI and Vue versions of the display.Jul 6 2021, 11:57 PM

DannyS712 mentioned this in T286309: Links in tags should also open in separate tabs.Jul 7 2021, 11:06 PM

DannyS712 mentioned this in T273526: Links in edit summaries should also open in separate tabs.

Change 702954 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Make watchlistUtils non-static

https://gerrit.wikimedia.org/r/702954

jenkins-bot mentioned this in rEGLWd6ec0ae260c1: Make watchlistUtils non-static.Jul 13 2021, 10:51 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 13 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2021, 11:10 PM

DannyS712 closed this task as Resolved.Jul 13 2021, 11:32 PM

DannyS712 claimed this task.

DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.

DannyS712 set Final Story Points to 6.