Page MenuHomePhabricator
Create Task
Maniphest T286199

Create a source and type dispatching EntityUrlLookup
Closed, ResolvedPublic
Actions

Description

Use ServiceBySourceAndTypeDispatcher

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FP: make TypeDispatchingUrlLookup source awaremediawiki/extensions/Wikibasemaster+204 -136
FP: make EntitySourceLookup check for sub entity typesmediawiki/extensions/Wikibasemaster+58 -7
Explicitly define URL_LOOKUP_CALLBACKmediawiki/extensions/WikibaseLexememaster+13 -3
Explicitly define URL_LOOKUP_CALLBACKmediawiki/extensions/WikibaseMediaInfomaster+5 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jul 5 2021, 1:10 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 5 2021, 1:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jakob_WMDE updated the task description. (Show Details)Jul 5 2021, 1:10 PM
Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.
gerritbot added a comment.Jul 6 2021, 10:07 AM

Change 703392 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Explicitly define URL_LOOKUP_CALLBACK

https://gerrit.wikimedia.org/r/703392

gerritbot added a project: Patch-For-Review.Jul 6 2021, 10:07 AM

Change 703393 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseMediaInfo@master] Explicitly define URL_LOOKUP_CALLBACK

https://gerrit.wikimedia.org/r/703393

gerritbot added a comment.Jul 6 2021, 10:16 AM

Change 703394 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: make TypeDispatchingUrlLookup source aware

https://gerrit.wikimedia.org/r/703394

gerritbot added a comment.Jul 6 2021, 1:20 PM

Change 703434 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: make EntitySourceLookup check for sub entity types

https://gerrit.wikimedia.org/r/703434

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 6 2021, 3:12 PM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 2); removed Wikibase - Federated Properties (Federation v2 - Sprint 1).Jul 7 2021, 9:05 AM
• Samantha_Alipio_WMDE moved this task from To do to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.
gerritbot added a comment.Jul 7 2021, 12:39 PM

Change 703393 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Explicitly define URL_LOOKUP_CALLBACK

https://gerrit.wikimedia.org/r/703393

gerritbot added a comment.Jul 7 2021, 12:40 PM

Change 703392 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Explicitly define URL_LOOKUP_CALLBACK

https://gerrit.wikimedia.org/r/703392

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 7 2021, 1:00 PM
gerritbot added a comment.Jul 7 2021, 2:57 PM

Change 703434 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: make EntitySourceLookup check for sub entity types

https://gerrit.wikimedia.org/r/703434

gerritbot added a comment.Jul 7 2021, 3:01 PM

Change 703394 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: make TypeDispatchingUrlLookup source aware

https://gerrit.wikimedia.org/r/703394

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 8 2021, 2:09 PM
Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits