| Eileenmcnaughton | |
| Jul 6 2021, 3:15 AM |
| F34540371: image.png | |
| Jul 6 2021, 3:15 AM |
I was looking at some weird / ugly code we have for adding tags & it seems the only place it's used is from the 'Generic Individuals' & 'Generic Orgs' and I've never heard someone say they use them
@MDemosWMF do you think some of the imports on this list can be REMOVED as obsolete
Hi @Eileenmcnaughton thanks for looking into this. The generic individuals import is used for the checks that come in through citibank and are usually 'autopay' setups. I'm not sure about that generic organization though - @RLewis are you familiar with this one at all?
The ones that I use are:
Bitpay
Citibank Individuals
Engage
Fidelity
Foreign Checks
Generic Individuals
@RLewis are you familiar with the others (beside Benevity which I know you use):
Citibank
Coinbase Merchant Orders
Generic Organizations
JP Morgan
Paypal EFT
Square
Stripe
Trilogy
I wouldn't want to say for sure if those are obsolete since I don't have the historical knowledge - @RLewis if any jump out at you as no longer in use please let us know. I'm not certain if anyone else uses these. Thank you!
@Eileenmcnaughton and @MDemosWMF thanks for checking on this, agreed with Melanie on the generic individuals. I think the generic org one was used similarly to the generic individuals but i don't use that one at all.
JP Morgan was an old one for our international wires import, I think this is obsolete
Paypal EFT - I'm not sure on this one either I think it's an old one for the AmzonSmile files we used to import but we don't anymore
Coinbase Merchant Orders - check with Pats or Evelyn on this one
Square - unsure
Stripe - check with Jerry for events
Trilogy - same check with Jerry for events
OK - I've compiled the list & some data about them below
@EMartin & @Ppena - you were mentioned above - do either of you use the imports for CoinbaseMerchantOrders or Paypal EFT? In both cases they were written around 2015 & the code has not been touched since so I believe them to be obsolete
@jkim_wikimedia - can you confirm which imports you still use? There are 3 that we think you might...
@LeanneS it seems that you were the last person who knew about CitiBank, Generic Organizations, JP Morgan. and possibly Square...
@Ejegg - can you check the last 4....
| Import | Owner | Relevant phab |
| Benevity | @RLewis | T115044 |
| Bitpay | @MDemosWMF | T192953 |
| Citibank | Remove? Confirm with @LeanneS | T179339 |
| Citibank - individuals | @MDemosWMF | T217390 |
| Engage | @MDemosWMF | T286520 |
| CoinbaseMerchantOrders | Remove | last edited 2015 - issue FR #1771 seems pre-phab |
| Fidelity | @MDemosWMF | T275445 |
| Foreign checks | @MDemosWMF | (FR #1497) |
| Generic Individuals | @MDemosWMF | T147521 |
| Generic Organizations | Recent use by @MDemosWMF - originally for DAF imports for @RLewis | T88836 |
| JP Morgan | Remove? Confirm with @LeanneS | T131802 |
| Paypal EFT | Remove | last edited 2015 - issue FR #1371 seems pre-phab |
| Square | ? originally form @MBeat33 - @LeanneS also involved - does @jkim_wikimedia | use it? T92582 |
| Stripe | @Jsimmonds - used for donations made at event | T267255 |
| Trilogy | @Jsimmonds - used for donations made via event emails | T114155 |
| ContributionConversion | Remove FR-tech - drush script by awight | (FR #1180) drush cmd to convert non-recurring contributions to recurring |
| ImportRefund | Remove FR-tech - drush script by @Ejegg | T142312 drush cmd to import refunds |
| import_chargebacks | Remove FR-tech - drush script by awight | last touched T124842 to make compatible with CiviCRM 4.6 |
| import_chargebacks | Remove FR-tech - drush script by awight | T88836 |
@JSimmons - can you take a look at the imports Eileen has mentioned for Jerry as I think they might all be event related?
Change 784772 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove coinbase from offline2civicrm
Change 784773 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove Paypal EFT from offline2civicrm
@Eileenmcnaughton @RLewis Trilogy is used for donations made via event emails. Stripe is used for events made during events (virtual and in-person). We do not use Square at events.
@Eileenmcnaughton We haven't used those last 4 scripts in the past 5 years, so I think they can be deleted. Looks like they shouldn't be all that complicated to recreate in Civi-native code if we ever need them again.
Change 785951 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove make_recurring batch file
Change 785952 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] drush import_refunds script
Change 785953 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove import_chargebacks drush script
Change 785954 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove import_checks drush script
I've put up patches to remove
So far all the comments above suggest to me I can also remove
I think @LeanneS has been pinged as possibly knowing about those - so just wanting to check in with you @LeanneS if you can recall anything that might suggest those 4 are not obsolete
Change 785953 merged by Eileen:
[wikimedia/fundraising/crm@master] Remove import_chargebacks drush script
Change 785954 merged by Eileen:
[wikimedia/fundraising/crm@master] Remove import_checks drush script
Change 784772 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove coinbase from offline2civicrm
Change 784773 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove Paypal EFT from offline2civicrm
@Ejegg checked the offline2civicrm log table & the 4 in question have not been used since 2018:
Square
Citibank
JP Morgan
Generic Organizations
Change 786441 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove SquareFile import
Change 786443 had a related patch set uploaded (by Eileen; author: Eileen):
[wikimedia/fundraising/crm@master] Remove CitiBank import (keep Citibank Individuals)
Change 785952 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] drush import_refunds script
Change 786441 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove SquareFile import
Change 786443 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove CitiBank import (keep Citibank Individuals)
Change 785951 merged by Eileen:
[wikimedia/fundraising/crm@master] Remove make_recurring batch file
@Eileenmcnaughton Sorry I'm catching up after being away. Confirming those 4 imports aren't in use anymore.