Page MenuHomePhabricator
Create Task
Maniphest T286262

Missing space between checkbox and label on Special:Watchlist
Closed, ResolvedPublic
Actions

Description

  1. Ensure the "Loads Watchlist without filters search or highlighting functionality." option is enabled on Special:Preferences.
  2. Open Special:Watchlist.
  3. Observe the form controls

Actual

Screenshot 2021-07-06 at 21.14.48.png (1,930×1,290 px, 522 KB)

This looks crammed and is a regression. I haven't tested watchlist with this configuration in a while, so it might have regressed up to a couple of months ago already.

Related:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Watchlist: Add space in filters checkboxmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jul 6 2021, 8:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2021, 8:16 PM
Krinkle renamed this task from Hidding space between checkbox and label on Special:Watchlist to Missing space between checkbox and label on Special:Watchlist.Jul 6 2021, 8:16 PM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.Jul 9 2021, 12:24 PM
kostajh added a project: good first task.
kostajh subscribed.

Growth-Team could look at patches for this, but I'm not sure that we have time to prioritize looking into it.

• mepps subscribed.Jul 14 2021, 4:49 PM

@kostajh @Krinkle I put up this patch that fixes it for the page. I'm not sure if we wanted a change in Html::check? In this case, my patch handles the space the same way it's handled in the rest of the class.

gerritbot added a comment.Jul 15 2021, 12:53 AM

Change 704568 had a related patch set uploaded (by DannyS712; author: Mepps):

[mediawiki/core@master] Watchlist: Add space in filters checkbox

https://gerrit.wikimedia.org/r/704568

gerritbot added a project: Patch-For-Review.Jul 15 2021, 12:53 AM
gerritbot added a comment.Nov 1 2021, 12:49 PM

Change 704568 had a related patch set uploaded (by Kosta Harlan; author: Mepps):

[mediawiki/core@master] Watchlist: Add space in filters checkbox

https://gerrit.wikimedia.org/r/704568

kostajh triaged this task as Low priority.Nov 1 2021, 12:51 PM
kostajh edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.
kostajh moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 1 2021, 1:10 PM

Change 704568 merged by jenkins-bot:

[mediawiki/core@master] Watchlist: Add space in filters checkbox

https://gerrit.wikimedia.org/r/704568

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 1 2021, 2:00 PM
Etonkovidova closed this task as Resolved.Nov 5 2021, 6:30 PM
Etonkovidova claimed this task.
Etonkovidova subscribed.

Checked Watchlist (also RC/Related changes) on wmf.7 on several wikis - en, ru, he, el, bn - the space is added.

Screen Shot 2021-11-05 at 11.20.06 AM.png (2,884×376 px, 113 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits