Page MenuHomePhabricator

Missing space between checkbox and label on Special:Watchlist
Closed, ResolvedPublic

Description

  1. Ensure the "Loads Watchlist without filters search or highlighting functionality." option is enabled on Special:Preferences.
  2. Open Special:Watchlist.
  3. Observe the form controls

Actual

Screenshot 2021-07-06 at 21.14.48.png (1×1 px, 522 KB)

This looks crammed and is a regression. I haven't tested watchlist with this configuration in a while, so it might have regressed up to a couple of months ago already.

Related:

Event Timeline

Krinkle renamed this task from Hidding space between checkbox and label on Special:Watchlist to Missing space between checkbox and label on Special:Watchlist.Jul 6 2021, 8:16 PM
kostajh added a project: good first task.
kostajh added a subscriber: kostajh.

Growth-Team could look at patches for this, but I'm not sure that we have time to prioritize looking into it.

@kostajh @Krinkle I put up this patch that fixes it for the page. I'm not sure if we wanted a change in Html::check? In this case, my patch handles the space the same way it's handled in the rest of the class.

Change 704568 had a related patch set uploaded (by DannyS712; author: Mepps):

[mediawiki/core@master] Watchlist: Add space in filters checkbox

https://gerrit.wikimedia.org/r/704568

Change 704568 had a related patch set uploaded (by Kosta Harlan; author: Mepps):

[mediawiki/core@master] Watchlist: Add space in filters checkbox

https://gerrit.wikimedia.org/r/704568

kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
kostajh moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.

Change 704568 merged by jenkins-bot:

[mediawiki/core@master] Watchlist: Add space in filters checkbox

https://gerrit.wikimedia.org/r/704568

Etonkovidova claimed this task.
Etonkovidova added a subscriber: Etonkovidova.

Checked Watchlist (also RC/Related changes) on wmf.7 on several wikis - en, ru, he, el, bn - the space is added.

Screen Shot 2021-11-05 at 11.20.06 AM.png (376×2 px, 113 KB)