Page MenuHomePhabricator
Create Task
Maniphest T286297

WikibaseMediaInfo StatementWidget uses messages from another ResourceLoader module
Closed, ResolvedPublic
Actions

Description

The StatementWidget class is defined in the wikibase.mediainfo.statements ResourceLoader module, but uses messages such as wikibasemediainfo-filepage-edit and wikibasemediainfo-filepage-edit-depicts, which are part of the wikibase.mediainfo.filePageDisplay module. Since the statements module doesn’t depend on the filePageDisplay module (in fact, filePageDisplay depends on statements), this means that other modules which import the statements module but not the filePageDisplay module will have missing messages in the UI.

This was reported to me as a bug in the AC/DC gadget, but I imagine it could also start happening in WikibaseMediaInfo, e.g. in the post-upload step of the UploadWizard. (Though currently it seems like the affected messages aren’t used in that case.)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
explicitly declare 2 message dependencies in wikibase.mediainfo.statementsmediawiki/extensions/WikibaseMediaInfowmf/1.38.0-wmf.5+2 -0
explicitly declare 2 message dependencies in wikibase.mediainfo.statementsmediawiki/extensions/WikibaseMediaInfomaster+2 -0
Customize query in gerrit

Event Timeline

LucasWerkmeister created this task.Jul 7 2021, 5:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2021, 5:21 PM
LucasWerkmeister added a comment.Jul 7 2021, 5:30 PM

Worked around this in AC/DC by loading the other ResourceLoader module as well (commit, on-wiki diff).

AntiCompositeNumber subscribed.Oct 18 2021, 2:05 AM

The workaround in AC/DC of loading wikibase.mediainfo.filePageDisplay causes an error on all non-file pages, because that module tries to infuse the MediaInfo tabs, but can't find any.

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptOct 18 2021, 2:05 AM
gerritbot added a comment.Oct 18 2021, 2:31 AM

Change 731307 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):

[mediawiki/extensions/WikibaseMediaInfo@master] explicitly declare 2 message dependencies in wikibase.mediainfo.statements

https://gerrit.wikimedia.org/r/731307

gerritbot added a project: Patch-For-Review.Oct 18 2021, 2:31 AM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 18 2021, 4:40 PM
CBogen moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.
Cparle moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 20 2021, 11:43 AM
gerritbot added a comment.Oct 20 2021, 7:49 PM

Change 731307 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] explicitly declare 2 message dependencies in wikibase.mediainfo.statements

https://gerrit.wikimedia.org/r/731307

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 20 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 20 2021, 8:10 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 22 2021, 12:45 AM
Etonkovidova subscribed.

Will check on commons wmf.6.

AntiCompositeNumber added a comment.Oct 22 2021, 3:58 PM

Using the JavaScript console on any non-file page (like https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page)

> mw.loader.getState("wikibase.mediainfo.statements")
"registered"
> mw.messages.get("wikibasemediainfo-filepage-edit")
null
> mw.messages.get("wikibasemediainfo-filepage-edit-depicts")
null
> mw.loader.load("wikibase.mediainfo.statements")
undefined
> mw.loader.getState("wikibase.mediainfo.statements")
"ready"
> mw.messages.get("wikibasemediainfo-filepage-edit")
"Edit"
> mw.messages.get("wikibasemediainfo-filepage-edit-depicts")
"Edit depicts"

Compared to Commons currently:

> mw.loader.getState("wikibase.mediainfo.statements")
"registered"
> mw.messages.get("wikibasemediainfo-filepage-edit")
null
> mw.messages.get("wikibasemediainfo-filepage-edit-depicts")
null
> mw.loader.load("wikibase.mediainfo.statements")
undefined
> mw.loader.getState("wikibase.mediainfo.statements")
"ready"
> mw.messages.get("wikibasemediainfo-filepage-edit")
null
> mw.messages.get("wikibasemediainfo-filepage-edit-depicts")
null
LucasWerkmeister added a comment.Oct 22 2021, 5:43 PM

AC/DC is not present in betalabs

You can manually load AC/DC there (see the README), and it looks like the message is loaded now. AC/DC version with my workaround reverted, on production:

Screenshot 2021-10-22 at 19-42-36 Blank page - Wikimedia Commons.png (797×1 px, 41 KB)

And on Beta:
Screenshot 2021-10-22 at 19-42-59 Blank page - Wikimedia Commons BETA.png (797×1 px, 37 KB)

gerritbot added a comment.Oct 25 2021, 5:26 PM

Change 734310 had a related patch set uploaded (by AntiCompositeNumber; author: AntiCompositeNumber):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.38.0-wmf.5] explicitly declare 2 message dependencies in wikibase.mediainfo.statements

https://gerrit.wikimedia.org/r/734310

gerritbot added a project: Patch-For-Review.Oct 25 2021, 5:26 PM
gerritbot added a comment.Oct 25 2021, 7:02 PM

Change 734310 abandoned by Jforrester:

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.38.0-wmf.5] explicitly declare 2 message dependencies in wikibase.mediainfo.statements

Reason:

Let's just go with the train.

https://gerrit.wikimedia.org/r/734310

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2021, 7:10 PM
Etonkovidova closed this task as Resolved.Oct 27 2021, 10:39 PM
Etonkovidova claimed this task.

Thanks @LucasWerkmeister and @AntiCompositeNumber for comments & testing tips!

Checked in commons wmf.6 - seems to be ok.

mw.loader.getState("wikibase.mediainfo.statements")
'ready'
mw.messages.get("wikibasemediainfo-filepage-edit")
'(wikibasemediainfo-filepage-edit)'
mw.messages.get("wikibasemediainfo-filepage-edit-depicts")
'(wikibasemediainfo-filepage-edit-depicts)'
mw.loader.load("wikibase.mediainfo.statements")
undefined
 mw.loader.getState("wikibase.mediainfo.statements")
'ready'
mw.messages.get("wikibasemediainfo-filepage-edit")
'(wikibasemediainfo-filepage-edit)'
mw.messages.get("wikibasemediainfo-filepage-edit-depicts")
'(wikibasemediainfo-filepage-edit-depicts)'
LucasWerkmeister added a comment.Nov 10 2021, 9:16 PM

Thanks! I reverted the workaround in AC/DC and everything still seems to be working.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits