Page MenuHomePhabricator
Create Task
Maniphest T286367

Make ApiEntityLookup work with FederatedPropertyId
Closed, ResolvedPublic
Actions

Description

ApiEntityLookup was created in Federated Properties v1 for fetching federated property data. We have since introduced FederatedPropertyId which are serialized as URIs instead of P-ids. ApiEntityLookup needs to be changed to *only* accept FederatedPropertyIds, and also needs to strip away the conceptBaseUri prefix of ids that it sends to the remote Wikibase's API, i.e. when fetching data for a federated property id http://wikidata.org/entity/P123 it should request data for P123 from the remote API.

Details

SubjectRepoBranchLines +/-
FP: Make ApiEntityLookup work with FederatedPropertyIdmediawiki/extensions/Wikibasemaster+269 -127
FP: use EntityIdParser in FormatSnakValuemediawiki/extensions/Wikibasemaster+51 -6
[WIP] Make ApiEntityLookup work with FederatedPropertyIdmediawiki/extensions/Wikibasemaster+50 -16
FP: Add Wikibase repo settings for federated properties prefixmediawiki/extensions/Wikibasemaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jul 9 2021, 8:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2021, 8:01 AM
Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 9 2021, 9:33 AM
Rosalie_WMDE claimed this task.Jul 9 2021, 11:43 AM
gerritbot added a comment.Jul 12 2021, 2:12 PM

Change 704121 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] FP:Add Wikibase repo settings for federated properties prefix

https://gerrit.wikimedia.org/r/704121

gerritbot added a project: Patch-For-Review.Jul 12 2021, 2:12 PM
gerritbot added a comment.Jul 13 2021, 10:39 AM

Change 704310 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] [WIP] Make ApiEntityLookup work with FederatedPropertyId

https://gerrit.wikimedia.org/r/704310

gerritbot added a comment.Jul 13 2021, 10:53 AM

Change 704121 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] FP: Add Wikibase repo settings for federated properties prefix

https://gerrit.wikimedia.org/r/704121

gerritbot added a comment.Jul 13 2021, 12:22 PM

Change 704121 abandoned by Rosalie Perside (WMDE):

[mediawiki/extensions/Wikibase@master] FP: Add Wikibase repo settings for federated properties prefix

Reason:

invalid

https://gerrit.wikimedia.org/r/704121

gerritbot added a comment.Jul 13 2021, 1:47 PM

Change 704310 abandoned by Rosalie Perside (WMDE):

[mediawiki/extensions/Wikibase@master] [WIP] Make ApiEntityLookup work with FederatedPropertyId

Reason:

https://gerrit.wikimedia.org/r/704310

gerritbot added a comment.Jul 13 2021, 3:51 PM

Change 704361 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Make ApiEntityLookup work with FederatedPropertyId

https://gerrit.wikimedia.org/r/704361

Jakob_WMDE mentioned this in T286717: Decide how to handle PropertyId vs FederatedPropertyId in Property-specific services.Jul 15 2021, 12:58 PM
gerritbot added a comment.Jul 16 2021, 11:00 AM

Change 704939 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: use EntityIdParser in FormatSnakValue

https://gerrit.wikimedia.org/r/704939

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 16 2021, 2:32 PM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 19 2021, 2:50 PM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 20 2021, 7:08 AM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 20 2021, 7:27 AM
gerritbot added a comment.Jul 20 2021, 8:06 AM

Change 704939 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: use EntityIdParser in FormatSnakValue

https://gerrit.wikimedia.org/r/704939

gerritbot added a comment.Jul 20 2021, 8:45 AM

Change 704361 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Make ApiEntityLookup work with FederatedPropertyId

https://gerrit.wikimedia.org/r/704361

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 20 2021, 9:00 AM
Jakob_WMDE moved this task from Doing to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 20 2021, 9:18 AM
Addshore closed this task as Resolved.Aug 24 2021, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL