Page MenuHomePhabricator
Create Task
Maniphest T286381

Drop fineGrainedLuaTracking config
Closed, ResolvedPublic
Actions

Description

It's set to true everywhere and has been working just fine for years now, we should just drop it.

Details

SubjectRepoBranchLines +/-
client: Drop fineGrainedLuaTracking optionmediawiki/extensions/Wikibasemaster+13 -73
Customize query in gerrit

Event Timeline

Ladsgroup created this task.Jul 9 2021, 8:57 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 9 2021, 8:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 9 2021, 9:15 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.
gerritbot added a comment.Jul 12 2021, 4:53 AM

Change 703952 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] client: Drop fineGrainedLuaTracking option

https://gerrit.wikimedia.org/r/703952

gerritbot added a project: Patch-For-Review.Jul 12 2021, 4:53 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 12 2021, 4:53 AM
Lucas_Werkmeister_WMDE subscribed.Jul 12 2021, 10:50 AM

It's set to true everywhere and has been working just fine for years now, we should just drop it.

Everywhere in Wikimedia production, maybe…

I think this should be a product decision.

Ladsgroup added a comment.Jul 12 2021, 12:10 PM

It's default in Wikibase as well. Plus not many third party installations use wikibase client altogether.

Lydia_Pintscher added subscribers: • Samantha_Alipio_WMDE, Lydia_Pintscher.Jul 12 2021, 1:43 PM

Yeah for Wikimedia we can drop it.
For the rest of the Wikibase users: @Samantha_Alipio_WMDE that's your decision. My recommendation would be to remove the feature flag completely from our codebase.

Addshore subscribed.Jul 26 2021, 2:03 PM

Going to go ahead and merge the thing and I'll check with Sam when she is back later in the week, but I'm pretty sure removing this will be fine.
Can always revert if not :)

gerritbot added a comment.Jul 26 2021, 2:51 PM

Change 703952 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Drop fineGrainedLuaTracking option

https://gerrit.wikimedia.org/r/703952

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 26 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 26 2021, 3:11 PM
Addshore closed this task as Resolved.Jul 26 2021, 4:15 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL