Page MenuHomePhabricator
Create Task
Maniphest T286391

ProofreadPage: Index CSS has lower specificity than templates own TemplateStyles
Closed, ResolvedPublicBUG REPORT
Actions

Description

Because the index CSS is declared first on the output pages, it has lower specificity than any CSS declared by templates' own TemplateStyles CSS.

This means that if the index CSS uses a plain class name, it will be "beaten" by the default TemplateStyles.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Index CSS: Apply a wrapper class to CSSmediawiki/extensions/ProofreadPagemaster+3 -2
Customize query in gerrit

Event Timeline

Inductiveload created this task.Jul 10 2021, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2021, 1:26 PM
Inductiveload renamed this task from ProofreadPage: Index CSS has lower speciificity than templates to ProofreadPage: Index CSS has lower specificity than templates own TemplateStyles.Jul 10 2021, 1:27 PM
Inductiveload claimed this task.
Inductiveload added a project: ProofreadPage.
gerritbot added a comment.Jul 10 2021, 2:18 PM

Change 703885 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] Index CSS: Apply a wrapper class to CSS

https://gerrit.wikimedia.org/r/703885

gerritbot added a project: Patch-For-Review.Jul 10 2021, 2:18 PM
gerritbot added a comment.Jul 10 2021, 3:06 PM

Change 703885 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Index CSS: Apply a wrapper class to CSS

https://gerrit.wikimedia.org/r/703885

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2021, 3:10 PM
Inductiveload added a project: User-Inductiveload.Jul 10 2021, 3:12 PM
Inductiveload moved this task from Inbox/backlog to To test on the User-Inductiveload board.
Inductiveload moved this task from To test to Waiting for review/deploy/action on the User-Inductiveload board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 10 2021, 4:00 PM
Inductiveload closed this task as Resolved.Jul 18 2021, 6:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits