Page MenuHomePhabricator
Create Task
Maniphest T286490

PHP Deprecated: Deprecated cross-wiki access to MediaWiki\User\UserIdentityValue. Expected: the local wiki, Actual: 'enwiki'. Pass expected $wikiId. [Called from MediaWiki\User\UserIdentityValue::getId]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Deprecated cross-wiki access to MediaWiki\User\UserIdentityValue. Expected: the local wiki, Actual: 'enwiki'. Pass expected $wikiId. [Called from MediaWiki\User\UserIdentityValue::getId]
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.12/includes/user/UserIdentityValue.php(146)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, string, array)
#1 /srv/mediawiki/php-1.37.0-wmf.12/includes/debug/MWDebug.php(376): trigger_error(string, integer)
#2 /srv/mediawiki/php-1.37.0-wmf.12/includes/debug/MWDebug.php(352): MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.37.0-wmf.12/includes/GlobalFunctions.php(1030): MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.12/includes/dao/WikiAwareEntityTrait.php(78): wfDeprecatedMsg(string, string)
#5 /srv/mediawiki/php-1.37.0-wmf.12/includes/user/UserIdentityValue.php(146): MediaWiki\User\UserIdentityValue->deprecateInvalidCrossWiki(boolean, string)
#6 /srv/mediawiki/php-1.37.0-wmf.12/includes/user/UserFactory.php(177): MediaWiki\User\UserIdentityValue->getId()
#7 /srv/mediawiki/php-1.37.0-wmf.12/includes/block/BlockUtils.php(86): MediaWiki\User\UserFactory->newFromUserIdentity(MediaWiki\User\UserIdentityValue)
#8 /srv/mediawiki/php-1.37.0-wmf.12/includes/block/AbstractBlock.php(446): MediaWiki\Block\BlockUtils->parseBlockTarget(MediaWiki\User\UserIdentityValue)
#9 /srv/mediawiki/php-1.37.0-wmf.12/includes/block/AbstractBlock.php(103): MediaWiki\Block\AbstractBlock->setTarget(MediaWiki\User\UserIdentityValue)
#10 /srv/mediawiki/php-1.37.0-wmf.12/includes/block/DatabaseBlock.php(103): MediaWiki\Block\AbstractBlock->__construct(array)
#11 /srv/mediawiki/php-1.37.0-wmf.12/extensions/CentralAuth/includes/CentralAuthUser.php(1947): MediaWiki\Block\DatabaseBlock->__construct(array)
#12 /srv/mediawiki/php-1.37.0-wmf.12/extensions/CentralAuth/includes/CentralAuthUser.php(1881): CentralAuthUser->doLocalSuppression(boolean, string, string, string)
#13 /srv/mediawiki/php-1.37.0-wmf.12/extensions/CentralAuth/includes/CentralAuthUser.php(1859): CentralAuthUser->doCrosswikiSuppression(boolean, string, string)
#14 /srv/mediawiki/php-1.37.0-wmf.12/extensions/CentralAuth/includes/CentralAuthUser.php(1810): CentralAuthUser->suppress(string, string)
#15 /srv/mediawiki/php-1.37.0-wmf.12/extensions/CentralAuth/includes/specials/SpecialCentralAuth.php(245): CentralAuthUser->adminLockHide(boolean, string, string, RequestContext)
#16 /srv/mediawiki/php-1.37.0-wmf.12/extensions/CentralAuth/includes/specials/SpecialCentralAuth.php(143): SpecialCentralAuth->doSubmit()
#17 /srv/mediawiki/php-1.37.0-wmf.12/includes/specialpage/SpecialPage.php(646): SpecialCentralAuth->execute(NULL)
#18 /srv/mediawiki/php-1.37.0-wmf.12/includes/specialpage/SpecialPageFactory.php(1362): SpecialPage->run(NULL)
#19 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#20 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(917): MediaWiki->performRequest()
#21 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(551): MediaWiki->main()
#22 /srv/mediawiki/php-1.37.0-wmf.12/index.php(53): MediaWiki->run()
#23 /srv/mediawiki/php-1.37.0-wmf.12/index.php(46): wfIndexMain()
#24 /srv/mediawiki/w/index.php(3): require(string)
#25 {main}
Impact

Unclear.

Notes

Low volume but persistent. Happening since at least 1.37.0-wmf.9

Details

Request URL
https://meta.wikimedia.org/w/index.php?title=*&target=*
SubjectRepoBranchLines +/-
Convert BlockUtils::parseBlockTarget to UserIdentitymediawiki/corewmf/1.37.0-wmf.15+125 -96
Convert BlockUtils::parseBlockTarget to UserIdentitymediawiki/coremaster+125 -96
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Jul 12 2021, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2021, 4:48 PM
Zabe subscribed.EditedJul 12 2021, 5:30 PM

This looks very similar to T277687 and T281972.

Krinkle added a parent task: T281156: 1.37.0-wmf.15 deployment blockers.Jul 13 2021, 12:38 AM
Krinkle subscribed.

Per policy, unexpected hard deprecations in production block the next train by default.

Krinkle added a project: Platform Engineering.Jul 13 2021, 12:38 AM
DannyS712 triaged this task as Unbreak Now! priority.Jul 13 2021, 2:25 AM
DannyS712 subscribed.

Train blocker

• Pchelolo lowered the priority of this task from Unbreak Now! to Medium.Jul 13 2021, 2:26 AM
• Pchelolo subscribed.

It's a next train blocker. So, 'Unbreak in a week' is a proper priority :)

• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed Platform Engineering.Jul 13 2021, 2:26 AM
• Pchelolo added a comment.Jul 13 2021, 2:36 AM

This is yet another instance of cross-wiki blocking having issues, but in this case BlockUtils::parseBlockTarget returns User even though it doesn't need the result to be User, UserIdentity is enough. Since it's a cross-wiki block and we now emit deprecation warnings when cross-wiki User objects are created - this happens.

Need to make BlockUtils::parseBlockTarget just return UserIdentity - a few places where this class is used are all in core and most of them are totally satisfied with UserIdentity.

RhinosF1 subscribed.Jul 13 2021, 6:47 AM
Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 14 2021, 6:49 PM
gerritbot added a comment.Jul 15 2021, 11:37 PM

Change 704868 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Convert BlockUtils::parseBlockTarget to UserIdentity

https://gerrit.wikimedia.org/r/704868

gerritbot added a project: Patch-For-Review.Jul 15 2021, 11:37 PM
dancy unsubscribed.Jul 16 2021, 3:22 PM
dancy raised the priority of this task from Medium to Unbreak Now!.Jul 20 2021, 7:31 PM

Status changed to UBN since this is blocking this week's train now.

• Pchelolo added a comment.Jul 20 2021, 7:35 PM

The patch is under review for this, and it is pretty close to being done - needs last round of updates by @Zabe However, this is a deprecation warning with a fix that is more risky then the problem. Definitely too risky to backport.

I propose to bump this one more train and make it a blocker for the next train - that will be safer. There's no user impact, and back porting can actually break things for real. Sorry we didn't manage to merge it in time.

gerritbot added a comment.Jul 20 2021, 9:54 PM

Change 704868 merged by jenkins-bot:

[mediawiki/core@master] Convert BlockUtils::parseBlockTarget to UserIdentity

https://gerrit.wikimedia.org/r/704868

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 20 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 20 2021, 10:10 PM
gerritbot added a comment.Jul 21 2021, 8:13 AM

Change 705758 had a related patch set uploaded (by Hashar; author: Zabe):

[mediawiki/core@wmf/1.37.0-wmf.15] Convert BlockUtils::parseBlockTarget to UserIdentity

https://gerrit.wikimedia.org/r/705758

gerritbot added a project: Patch-For-Review.Jul 21 2021, 8:13 AM
daniel edited parent tasks, added: T281157: 1.37.0-wmf.16 deployment blockers; removed: T281156: 1.37.0-wmf.15 deployment blockers.Jul 21 2021, 9:16 AM
gerritbot added a comment.Jul 21 2021, 9:36 AM

Change 705758 abandoned by Hashar:

[mediawiki/core@wmf/1.37.0-wmf.15] Convert BlockUtils::parseBlockTarget to UserIdentity

Reason:

Thanks !

https://gerrit.wikimedia.org/r/705758

hashar subscribed.Jul 21 2021, 9:38 AM

I was clueless and proposed a backport. I had missed Piotr comment:

However, this is a deprecation warning with a fix that is more risky then the problem. Definitely too risky to backport.

Zabe removed a project: Patch-For-Review.Jul 21 2021, 10:36 PM
• Pchelolo lowered the priority of this task from Unbreak Now! to Medium.Jul 22 2021, 2:15 AM
taavi subscribed.Jul 27 2021, 12:09 PM

I don't think this is a blocker anymore, as the patch was merged to master last week?

• Pchelolo removed a parent task: T281157: 1.37.0-wmf.16 deployment blockers.Jul 27 2021, 1:03 PM
• Pchelolo moved this task from Unsorted pile to On the train on the Platform Team Workboards (MW Expedition) board.
Zabe claimed this task.Jul 31 2021, 2:34 PM

This should be fixed. Could someone with logstash access check?

• Pchelolo closed this task as Resolved.Jul 31 2021, 2:51 PM

This specific one was fixed. There's a new one, but it was also already fixed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/705769

Zabe merged a task: T287630: PHP Deprecated: Deprecated cross-wiki access to MediaWiki\User\UserIdentityValue. Expected: the local wiki, Actual: 'loginwiki'. Pass expected $wikiId. [Called from MediaWiki\User\UserIdentityValue::getId].Jan 20 2022, 2:03 PM
Zabe added subscribers: • mmodell, brennen, dancy.
Umherirrender mentioned this in T353620: Wikimedia\Assert\PreconditionException: Expected MediaWiki\Block\AbstractBlock to belong to the local wiki, but it belongs to 'commonswiki'.Dec 19 2023, 8:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits