Page MenuHomePhabricator
Create Task
Maniphest T286574

Regression (commons/wikidata): ULS preferences tool link cannot be opened when compact languages disabled
Closed, ResolvedPublic
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jul 13 2021, 4:22 PM
Tags
Referenced Files
F34571712: Screen Shot 2021-07-31 at 10.26.36 PM.png
Aug 1 2021, 5:29 AM
F34571714: Screen Shot 2021-07-31 at 10.27.14 PM.png
Aug 1 2021, 5:29 AM
F34564138: Screen Shot 2021-07-26 at 7.34.12 AM.png
Jul 26 2021, 2:35 PM
F34564135: Screen Shot 2021-07-26 at 7.32.36 AM.png
Jul 26 2021, 2:35 PM
F34550000: Screen Shot 2021-07-13 at 9.21.30 AM.png
Jul 13 2021, 4:22 PM
F34550002: Screen Shot 2021-07-13 at 9.22.03 AM.png
Jul 13 2021, 4:22 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
Nikerabbit

Description

Screen Shot 2021-07-13 at 9.21.30 AM.png (794×1 px, 144 KB)

  • Go to preferences and disable the compact languages button

Screen Shot 2021-07-13 at 9.22.03 AM.png (300×1 px, 45 KB)

  • Click language button again
  • Expected: See dialog per step 1
  • Actual: The hash fragment changes and no overlay opens

QA Results - Beta

ACStatusDetails
1✅T286574#7236431 , T286574#7237884

QA Results - Prod

ACStatusDetails
1✅T286574#7250582

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UniversalLanguageSelectormaster+125 -107Fix regressions in ULS entry point setup
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 13 2021, 4:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2021, 4:22 PM
Nikerabbit added a subscriber: Nikerabbit.Jul 13 2021, 7:11 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/701496 should fix this too.

gerritbot added a comment.Jul 13 2021, 7:16 PM

Change 701496 had a related patch set uploaded (by Jdlrobson; author: Nikerabbit):

[mediawiki/extensions/UniversalLanguageSelector@master] Fix regressions in ULS entry point setup

https://gerrit.wikimedia.org/r/701496

gerritbot added a project: Patch-For-Review.Jul 13 2021, 7:17 PM
Jdlrobson added a comment.Jul 13 2021, 7:17 PM
In T286574#7209802, @Nikerabbit wrote:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/701496 should fix this too.

Yep. Just confirmed. Thanks for pointing that out!

Jdlrobson added a project: Readers-Web-Backlog (Kanbanana-FY-2020-21).Jul 13 2021, 7:17 PM
Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Blocked on T286459

Aklapper added a subtask: T286459: Turn off A/B test for language switching on pilot wikis.Jul 15 2021, 8:04 AM
ovasileva triaged this task as Medium priority.Jul 15 2021, 1:01 PM
Jdlrobson claimed this task.Jul 15 2021, 4:15 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jul 16 2021, 7:05 PM
Jdlrobson moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jul 16 2021, 7:23 PM

Change 701496 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Fix regressions in ULS entry point setup

https://gerrit.wikimedia.org/r/701496

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 16 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 16 2021, 8:10 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.EditedJul 26 2021, 2:35 PM
Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ✅ Pass
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Screen Shot 2021-07-26 at 7.32.36 AM.png (815×1 px, 208 KB)

  • Go to preferences and disable the compact languages button
  • Click language button again
  • ✅ AC1: Expected: See dialog per step 1

Screen Shot 2021-07-26 at 7.34.12 AM.png (777×1 px, 254 KB)

@Jdlrobson Is this what is expected?

Edtadros updated the task description. (Show Details)Jul 26 2021, 2:36 PM
Edtadros updated the task description. (Show Details)
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jul 26 2021, 9:28 PM

Yep that's a pass!

Edtadros updated the task description. (Show Details)Jul 29 2021, 4:36 PM
Edtadros moved this task from QA to QA in Prod on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Thanks!

nray closed subtask T286459: Turn off A/B test for language switching on pilot wikis as Resolved.Jul 29 2021, 11:35 PM
Edtadros reassigned this task from Edtadros to ovasileva.Aug 1 2021, 5:29 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Test Result - Prod

Status: ✅ Pass
Environment: commons
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Screen Shot 2021-07-31 at 10.26.36 PM.png (582×978 px, 212 KB)

  • Go to preferences and disable the compact languages button
  • Click language button again
  • ✅ AC1: Expected: See dialog per step 1

Screen Shot 2021-07-31 at 10.27.14 PM.png (582×978 px, 114 KB)

Edtadros updated the task description. (Show Details)Aug 1 2021, 5:29 AM
ovasileva closed this task as Resolved.Aug 2 2021, 4:09 PM

All done here

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL