Page MenuHomePhabricator
Create Task
Maniphest T286576

Replace UserOptionsManager hooks
Closed, ResolvedPublic
Actions

Description

UserOptionsManager calls 3 hooks:

  • onUserResetAllOptions - according to codesearch, this hook is never used, so we can just deprecate it.
  • onUserLoadOptions( User $user, array &$options ) - can just replace $user typehint with UserIdentity
  • onUserSaveOptions( User $user, array &$newOptions, array $originalOptions ) - this one is tricky. In order to fulfill the requirements of the parent task, we need to pass 'modifiedOptions' instead of newOptions. And $user parameter should become UserIdentity

Details

SubjectRepoBranchLines +/-
Replace deprecated UserLoadOptionHookmediawiki/extensions/Echomaster+3 -3
Introduce new hooks for UserOptionsManagermediawiki/coremaster+208 -22
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Jul 13 2021, 5:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2021, 5:04 PM
gerritbot added a comment.Jul 13 2021, 9:06 PM

Change 704425 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] Introduce new hooks for UserOptionsManager

https://gerrit.wikimedia.org/r/704425

gerritbot added a project: Patch-For-Review.Jul 13 2021, 9:06 PM
• Pchelolo mentioned this in T286521: Deadlock found when trying to get lock (UserOptionsManager::saveOptionsQuery).Jul 19 2021, 11:58 PM
gerritbot added a comment.Jul 21 2021, 1:52 PM

Change 704425 merged by jenkins-bot:

[mediawiki/core@master] Introduce new hooks for UserOptionsManager

https://gerrit.wikimedia.org/r/704425

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 21 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 21 2021, 2:10 PM
gerritbot added a comment.Jul 26 2021, 4:28 PM

Change 708136 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/Echo@master] Replace deprecated UserLoadOptionHook

https://gerrit.wikimedia.org/r/708136

gerritbot added a project: Patch-For-Review.Jul 26 2021, 4:28 PM
tchin closed subtask T287397: Adjust onSaveUserOptions method signature as Resolved.Jul 27 2021, 1:20 PM
• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Jul 27 2021, 2:19 PM
tchin moved this task from UserStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Jul 29 2021, 1:56 PM
gerritbot added a comment.Aug 3 2021, 2:44 PM

Change 708136 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace deprecated UserLoadOptionHook

https://gerrit.wikimedia.org/r/708136

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Aug 3 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 3 2021, 3:10 PM
• Pchelolo moved this task from Doing to Waiting for release on the Platform Team Workboards (MW Expedition) board.Aug 12 2021, 1:33 PM
tchin moved this task from Waiting for release to On the train on the Platform Team Workboards (MW Expedition) board.Aug 12 2021, 1:33 PM
tchin closed this task as Resolved.Aug 18 2021, 1:08 PM
tchin claimed this task.
tchin closed subtask T287409: Replace deprecated UserSaveOptions hook in deployed extensions as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL