Page MenuHomePhabricator

Donors to newcomers: campaign Special:CreateAccount& redirects to regular Special:CreateAccount after clicking on a lang link
Closed, ResolvedPublic

Description

  1. Special:CreateAccount with &campaign=growth-advancement-test-2021&geEnabled=1 parameter has links to switch to different languages:
    Screen Shot 2021-07-13 at 11.07.46 AM.png (1×1 px, 437 KB)
  2. Clicking on any links will redirect a user to a regular Special:CreateAccount

The desired behavior would be:

  • clicking on language links will switch the UI lang and will keep the Special:CreateAccount with the campaign parameter.

e.g. the screenshot below is done with &uselang=es (of course, the text should be displayed in Spanish if a language is switched to Spanish):
https://test.wikipedia.org/w/index.php?title=Special:CreateAccount&campaign=growth-advancement-test-2021&geEnabled=1&uselang=es

Screen Shot 2021-07-13 at 11.10.19 AM.png (1×2 px, 491 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 704414 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector

https://gerrit.wikimedia.org/r/704414

Change 704414 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector

https://gerrit.wikimedia.org/r/704414

Change 704371 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector

https://gerrit.wikimedia.org/r/704371

Change 704372 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.14] SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector

https://gerrit.wikimedia.org/r/704372

FTR, in Slack, we decided to remove the language selector from the campaign account creation endpoint, as the messages won't be translated to non-campaign languages anyway. I'll backport the patch in the nearest window.

Change 704371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.12] SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector

https://gerrit.wikimedia.org/r/704371

Change 704372 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.14] SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector

https://gerrit.wikimedia.org/r/704372

Mentioned in SAL (#wikimedia-operations) [2021-07-13T23:24:58Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.12/extensions/GrowthExperiments/includes/Specials/SpecialCreateAccountCampaign.php: f3627361ff558c89d4a4452ff24b3457f46a4f46: SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector (T286587) (duration: 02m 07s)

Mentioned in SAL (#wikimedia-operations) [2021-07-13T23:27:24Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.14/extensions/GrowthExperiments/includes/Specials/SpecialCreateAccountCampaign.php: f3627361ff558c89d4a4452ff24b3457f46a4f46: SpecialCreateAccountCampaign: Ignore $wgLoginLanguageSelector (T286587) (duration: 02m 08s)

Change was deployed, LGTM in prod. Leaving for @Etonkovidova to verify.

Checked on eswiki, ptwiki, testwiki - works as expected.

I wonder if core (LoginSignupSpecialPage::makeLanguageSelectorLink()) should be fixed to preserve query parameters.