Page MenuHomePhabricator
Create Task
Maniphest T286602

Cleanup onwiki usages of action=query&meta=userinfo&uiprop=preferencestoken
Open, LowPublic
Actions

Description

Note: Some of these may be false positives and don't need correcting as they may just be strings or variable names, not actually resulting in API queries...

reedy@deploy1002:~$ mwgrep --user preferencestoken
commonswiki         User:Firefly/2021 Gadget-EnhancedPOTY.js
commonswiki         User:Leaderboard/Gadget-EnhancedPOTY.js
commonswiki         User:Odisha1/WLEI.js
commonswiki         User:Tucoxn/common.js

(total: 4, shown: 4)
reedy@deploy1002:~$ mwgrep --no-private preferencestoken
commonswiki         MediaWiki:Gadget-EnhancedPOTY.js

(total: 1, shown: 1)
reedy@deploy1002:~$

Related Objects
Search...

Event Timeline

Reedy created this task.Jul 13 2021, 7:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2021, 7:40 PM
Reedy renamed this task from Cleanup onwiki usages of preferencestoken to Cleanup onwiki usages of action=query&meta=userinfo&uiprop=preferencestoken.Jul 13 2021, 7:46 PM
Reedy added a project: Commons.Jul 19 2021, 2:59 PM
Meow moved this task from Incoming to Thumbnail and file renderings on the Commons board.Jul 28 2021, 9:00 AM
Meow moved this task from Thumbnail and file renderings to Incoming on the Commons board.Jul 28 2021, 9:03 AM
Reedy triaged this task as Low priority.Jul 30 2021, 12:27 AM
Reedy updated the task description. (Show Details)Jul 31 2021, 2:51 PM
Reedy updated the task description. (Show Details)Sep 18 2021, 1:58 PM
Legoktm added subscribers: AntiCompositeNumber, zhuyifei1999, Legoktm.Sep 21 2021, 8:25 PM

@AntiCompositeNumber @zhuyifei1999 is https://commons.wikimedia.org/wiki/MediaWiki:Gadget-EnhancedPOTY.js what's currently in use for POTY voting? It's still using the deprecated and very-soon-to-be-removed preferencestoken

AntiCompositeNumber added a subscriber: Firefly.Sep 22 2021, 2:06 AM

The script is in use, but I'm not sure if it actually uses the preferencestoken anymore. It looks to me like the token is retrieved and stored but not used. @Firefly is maintaining it now, they might know more.

Firefly added a comment.Sep 23 2021, 9:54 AM

I don't believe it actually uses the preferencestoken either - the change to the API certainly doesn't appear to have broken anything. I'll submit a patch to remove the retrieval.

Legoktm added a comment.Sep 23 2021, 5:19 PM
In T286602#7373762, @Firefly wrote:

I don't believe it actually uses the preferencestoken either - the change to the API certainly doesn't appear to have broken anything. I'll submit a patch to remove the retrieval.

Note that the API change hasn't actually been on Commons since POTY voting started (it was briefly last week, but IIRC voting started after). https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page will have the API change.

I ctrl+f'd through the script and couldn't find anywhere the tokens were used either.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL