Page MenuHomePhabricator
Create Task
Maniphest T286647

Regression: Search icon missing on mobile language switcher
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Pginer-WMF
Jul 14 2021, 1:32 PM
Tags
Referenced Files
F34588908: en.wikipedia.org_wiki_Albert_Einstein_useformat=mobile(iPhone X).png
Aug 10 2021, 12:01 AM
F34588906: en.wikipedia.beta.wmflabs.org_wiki_Albert_Einstein_useformat=mobile(iPhone X).png
Aug 10 2021, 12:01 AM
F34574056: Screen Shot 2021-08-02 at 2.20.28 PM.png
Aug 2 2021, 8:23 PM
F34574054: Screen Shot 2021-08-02 at 2.19.57 PM.png
Aug 2 2021, 8:23 PM
F34550857: en.m.wikipedia.org_wiki_Plants_in_space(Pixel 2) (1).png
Jul 14 2021, 1:32 PM
Subscribers
Aklapper
• alexhollender_WMF
cjming
Edtadros
Pginer-WMF
Volker_E

Description

When switching languages on mobile, I noticed that the option to "Search for a language" is missing the search icon:

en.m.wikipedia.org_wiki_Plants_in_space(Pixel 2) (1).png (1×1 px, 153 KB)

I recall there was a search icon before, so this may be a regression.

Developer notes

Fix should be straightforward. Add class "mw-ui-background-icon-search" to the search element

QA steps

Screen Shot 2021-08-02 at 2.19.57 PM.png (714×2 px, 93 KB)

Screen Shot 2021-08-02 at 2.20.28 PM.png (1×2 px, 167 KB)

QA Results - Beta

ACStatusDetails
1✅T286647#7271139

QA Results - Prod

ACStatusDetails
1✅T286647#7271141

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add search icon to mobile language switchermediawiki/extensions/MobileFrontendmaster+3 -3
Customize query in gerrit

Event Timeline

Pginer-WMF created this task.Jul 14 2021, 1:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2021, 1:32 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.Jul 14 2021, 3:28 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog-Archived board.
• alexhollender_WMF awarded a token.Jul 14 2021, 4:35 PM
ovasileva renamed this task from Search icon missing on mobile language switcher to Regression: Search icon missing on mobile language switcher.Jul 26 2021, 9:56 PM
ovasileva triaged this task as Medium priority.
ovasileva edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed Web-Team-Backlog-Archived.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 26 2021, 11:54 PM
LGoto set the point value for this task to 2.Jul 29 2021, 5:19 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
cjming claimed this task.Jul 30 2021, 8:52 PM
cjming moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
cjming moved this task from Blocked on Others to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Aug 2 2021, 5:30 PM
gerritbot added a comment.Aug 2 2021, 6:07 PM

Change 709517 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/MobileFrontend@master] Add search icon to mobile language switcher

https://gerrit.wikimedia.org/r/709517

gerritbot added a project: Patch-For-Review.Aug 2 2021, 6:07 PM
cjming removed cjming as the assignee of this task.Aug 2 2021, 6:35 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
cjming subscribed.
PatchDemoBot added a comment.Aug 2 2021, 6:56 PM

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d09e6411b5/w/

Jdlrobson assigned this task to Edtadros.Aug 2 2021, 7:51 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Aug 2 2021, 8:07 PM

Change 709517 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add search icon to mobile language switcher

https://gerrit.wikimedia.org/r/709517

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2021, 8:10 PM
cjming updated the task description. (Show Details)Aug 2 2021, 8:23 PM
LGoto edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived (Kanbanana-FY-2020-21).Aug 2 2021, 9:30 PM
LGoto moved this task from Needs Analysis to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Aug 10 2021, 12:01 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to the language switcher of a mobile page on the beta cluster - i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?useformat=mobile#/languages
✅ AC1: Note that Search for a language is preceded by a search icon

en.wikipedia.beta.wmflabs.org_wiki_Albert_Einstein_useformat=mobile(iPhone X).png (2×1 px, 96 KB)

Edtadros added a comment.Aug 10 2021, 12:01 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to the language switcher of a mobile page on the beta cluster - i.e. https://en.wikipedia.org/wiki/Albert_Einstein?useformat=mobile#/languages
✅ AC1: Note that Search for a language is preceded by a search icon

en.wikipedia.org_wiki_Albert_Einstein_useformat=mobile(iPhone X).png (2×1 px, 183 KB)

Edtadros updated the task description. (Show Details)Aug 10 2021, 12:03 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Edtadros reassigned this task from Edtadros to ovasileva.Aug 10 2021, 2:09 AM
Edtadros subscribed.
ovasileva closed this task as Resolved.Aug 10 2021, 4:27 PM

Icon is back, all done here!

PatchDemoBot added a comment.Aug 31 2021, 6:00 PM

Test wiki on Patch Demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d09e6411b5/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits