Page MenuHomePhabricator

Regression: Search icon missing on mobile language switcher
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

When switching languages on mobile, I noticed that the option to "Search for a language" is missing the search icon:

en.m.wikipedia.org_wiki_Plants_in_space(Pixel 2) (1).png (1×1 px, 153 KB)

I recall there was a search icon before, so this may be a regression.

Developer notes

Fix should be straightforward. Add class "mw-ui-background-icon-search" to the search element

QA steps

Screen Shot 2021-08-02 at 2.19.57 PM.png (714×2 px, 93 KB)

Screen Shot 2021-08-02 at 2.20.28 PM.png (1×2 px, 167 KB)

QA Results - Beta

ACStatusDetails
1T286647#7271139

QA Results - Prod

ACStatusDetails
1T286647#7271141

Event Timeline

ovasileva renamed this task from Search icon missing on mobile language switcher to Regression: Search icon missing on mobile language switcher.Jul 26 2021, 9:56 PM
ovasileva triaged this task as Medium priority.

Change 709517 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/MobileFrontend@master] Add search icon to mobile language switcher

https://gerrit.wikimedia.org/r/709517

cjming removed cjming as the assignee of this task.Aug 2 2021, 6:35 PM
cjming added a subscriber: cjming.

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/d09e6411b5/w/

Change 709517 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Add search icon to mobile language switcher

https://gerrit.wikimedia.org/r/709517

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to the language switcher of a mobile page on the beta cluster - i.e. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?useformat=mobile#/languages
✅ AC1: Note that Search for a language is preceded by a search icon

en.wikipedia.beta.wmflabs.org_wiki_Albert_Einstein_useformat=mobile(iPhone X).png (2×1 px, 96 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Navigate to the language switcher of a mobile page on the beta cluster - i.e. https://en.wikipedia.org/wiki/Albert_Einstein?useformat=mobile#/languages
✅ AC1: Note that Search for a language is preceded by a search icon

en.wikipedia.org_wiki_Albert_Einstein_useformat=mobile(iPhone X).png (2×1 px, 183 KB)

Icon is back, all done here!

Test wiki on Patch Demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d09e6411b5/w/