Page MenuHomePhabricator
Create Task
Maniphest T286672

Error: Call to a member function getInterwiki() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to a member function getInterwiki() on null
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.12/extensions/DoubleWiki/includes/DoubleWiki.php(88)
#0 /srv/mediawiki/php-1.37.0-wmf.12/extensions/DoubleWiki/includes/DoubleWiki.php(63): DoubleWiki->addMatchedText(OutputPage, string)
#1 /srv/mediawiki/php-1.37.0-wmf.12/includes/HookContainer/HookContainer.php(338): DoubleWiki::onOutputPageBeforeHTML(OutputPage, string)
#2 /srv/mediawiki/php-1.37.0-wmf.12/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#3 /srv/mediawiki/php-1.37.0-wmf.12/includes/HookContainer/HookRunner.php(2682): MediaWiki\HookContainer\HookContainer->run(string, array)
#4 /srv/mediawiki/php-1.37.0-wmf.12/includes/OutputPage.php(2019): MediaWiki\HookContainer\HookRunner->onOutputPageBeforeHTML(OutputPage, string)
#5 /srv/mediawiki/php-1.37.0-wmf.12/includes/OutputPage.php(2031): OutputPage->addParserOutputText(ParserOutput, array)
#6 /srv/mediawiki/php-1.37.0-wmf.12/includes/page/Article.php(797): OutputPage->addParserOutput(ParserOutput, array)
#7 /srv/mediawiki/php-1.37.0-wmf.12/includes/page/Article.php(651): Article->doOutputFromParserCache(ParserOutput, OutputPage, array)
#8 /srv/mediawiki/php-1.37.0-wmf.12/includes/page/Article.php(558): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#9 /srv/mediawiki/php-1.37.0-wmf.12/includes/page/CategoryPage.php(63): Article->view()
#10 /srv/mediawiki/php-1.37.0-wmf.12/includes/actions/ViewAction.php(74): CategoryPage->view()
#11 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(536): ViewAction->show()
#12 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(320): MediaWiki->performAction(MediaWiki\Extension\CategoryTree\CategoryTreeCategoryPage, Title)
#13 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(917): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.37.0-wmf.12/includes/MediaWiki.php(551): MediaWiki->main()
#15 /srv/mediawiki/php-1.37.0-wmf.12/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.37.0-wmf.12/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Impact

TBD.

Notes

It's iterating through the ParserOutput language links and finding an entry that is invalid according to the Title class.

https://gerrit.wikimedia.org/g/mediawiki/extensions/DoubleWiki/+/8adb93a1a4cc801cc83773b5a5fb91fcb9cec0ed/includes/DoubleWiki.php#88

Details

Request URL
https://fa.wikipedia.org/wiki/%D8%B1%D8%AF%D9%87:%D8%B3%DB%8C%D8%A7%D9%87%D9%87_%D9%82%D8%B1%D9%85%D8%B2_IUCN_%D8%A7%D8%B2_%DA%AF%D9%88%D9%86%D9%87%E2%80%8C%D9%87%D8%A7%DB%8C_%D8%AF%D8%B1_%D9%85%D8%B1%D8%B2_%D8%AA%D9%87%D8%AF%DB%8C%D8%AF?match=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Handle null from Title::newFromTextmediawiki/extensions/DoubleWikimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jul 14 2021, 6:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2021, 6:35 PM
Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 14 2021, 6:38 PM
Umherirrender subscribed.Aug 4 2021, 11:10 PM

Fresh parse of the langlinks with action=parse - https://fa.wikipedia.org/w/api.php?action=parse&page=%D8%B1%D8%AF%D9%87:%D8%B3%DB%8C%D8%A7%D9%87%D9%87_%D9%82%D8%B1%D9%85%D8%B2_IUCN_%D8%A7%D8%B2_%DA%AF%D9%88%D9%86%D9%87%E2%80%8C%D9%87%D8%A7%DB%8C_%D8%AF%D8%B1_%D9%85%D8%B1%D8%B2_%D8%AA%D9%87%D8%AF%DB%8C%D8%AF&prop=langlinks

{
    "lang": "ta",
    "*": "\u0baa\u0b95\u0bc1\u0baa\u0bcd\u0baa\u0bc1:\u0baa\u0ba9\u0bcd\u0ba9\u0bbe\u0b9f\u0bcd\u0b9f\u0bc1 \u0b87\u0baf\u0bb1\u0bcd\u0b95\u0bc8\u0baa\u0bcd \u0baa\u0bbe\u0ba4\u0bc1\u0b95\u0bbe\u0baa\u0bcd\u0baa\u0bc1\u0b9a\u0bcd \u0b9a\u0b99\u0bcd\u0b95\u0ba4\u0bcd\u0ba4\u0bbf\u0ba9\u0bcd \u0b9a\u0bc6\u0bae\u0bcd\u0baa\u0b9f\u0bcd\u0b9f\u0bbf\u0baf\u0bb2\u0bcd - \u0b85\u0b9a\u0bcd\u0b9a\u0bc1\u0bb1\u0bc1 \u0ba8\u0bbf\u0bb2\u0bc8\u0baf\u0bc8 \u0b85\u0ba3\u0bcd\u0bae\u0bbf\u0ba4\u0bcd\u0ba4 \u0b87\u0ba9\u0bae\u0bcd"
},

Getting information from the database - https://fa.wikipedia.org/w/api.php?action=query&&prop=langlinks&lllimit=max&titles=%D8%B1%D8%AF%D9%87:%D8%B3%DB%8C%D8%A7%D9%87%D9%87_%D9%82%D8%B1%D9%85%D8%B2_IUCN_%D8%A7%D8%B2_%DA%AF%D9%88%D9%86%D9%87%E2%80%8C%D9%87%D8%A7%DB%8C_%D8%AF%D8%B1_%D9%85%D8%B1%D8%B2_%D8%AA%D9%87%D8%AF%DB%8C%D8%AF

{
    "lang": "ta",
    "*": "\u0baa\u0b95\u0bc1\u0baa\u0bcd\u0baa\u0bc1:\u0baa\u0ba9\u0bcd\u0ba9\u0bbe\u0b9f\u0bcd\u0b9f\u0bc1 \u0b87\u0baf\u0bb1\u0bcd\u0b95\u0bc8\u0baa\u0bcd \u0baa\u0bbe\u0ba4\u0bc1\u0b95\u0bbe\u0baa\u0bcd\u0baa\u0bc1\u0b9a\u0bcd \u0b9a\u0b99\u0bcd\u0b95\u0ba4\u0bcd\u0ba4\u0bbf\u0ba9\u0bcd \u0b9a\u0bc6\u0bae\u0bcd\u0baa\u0b9f\u0bcd\u0b9f\u0bbf\u0baf\u0bb2\u0bcd - \u0b85\u0b9a\u0bcd\u0b9a\u0bc1\u0bb1\u0bc1 \u0ba8\u0bbf\u0bb2\u0bc8\u0baf\u0bc8 \u0b85\u0ba3\u0bcd\u0bae\u0bbf\u0ba4\u0bcd\u0ba4 \u0b87\u0ba9\ufffd"
},

The database has a UTF-8 replacement \ufffd which is invalid in titles. It is truncated to 255 bytes and gets the replacement.

Krinkle edited projects, added Platform Engineering; removed Release-Engineering-Team (Logspam).Aug 11 2021, 12:17 AM

Still seen. Tagging PE as this seems likely fall out from a Page or Title related refactor where something is perhaps now returning null instead of a quasi-valid Title. At the time of filing last month, these appeared relatively new (maybe one or two weeks back, I don't recall).

daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Aug 19 2021, 4:23 PM
Umherirrender unsubscribed.Jan 2 2022, 8:25 PM
brennen subscribed.Mar 3 2022, 7:58 PM

Still showing up in 1.38.0-wmf.24.

brennen added a project: User-brennen.Mar 3 2022, 7:58 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
thcipriani subscribed.Mar 17 2022, 3:36 PM

In case it's helpful:

  • Happening exclusively on fawiki
  • Happening close to once an hour recently
brennen mentioned this in T328074: DoubleWiki: Error: Call to a member function getInterwiki() on null.Jan 26 2023, 7:33 PM
Umherirrender mentioned this in T328882: Error: Call to a member function getInterwiki() on null.Feb 6 2023, 9:04 PM
Umherirrender merged a task: T328882: Error: Call to a member function getInterwiki() on null.
Umherirrender added subscribers: Ammarpad, Umherirrender.
Umherirrender merged a task: T328074: DoubleWiki: Error: Call to a member function getInterwiki() on null.Feb 6 2023, 9:11 PM
Umherirrender added a subscriber: • Agusbou2015.
gerritbot added a comment.Feb 6 2023, 9:22 PM

Change 886941 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DoubleWiki@master] Handle null from Title::newFromText

https://gerrit.wikimedia.org/r/886941

gerritbot added a project: Patch-For-Review.Feb 6 2023, 9:22 PM
gerritbot added a comment.Feb 8 2023, 7:18 PM

Change 886941 merged by jenkins-bot:

[mediawiki/extensions/DoubleWiki@master] Handle null from Title::newFromText

https://gerrit.wikimedia.org/r/886941

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 8 2023, 8:00 PM
Umherirrender closed this task as Resolved.Feb 10 2023, 7:43 PM
Umherirrender claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits