Page MenuHomePhabricator

Add php-luasandbox to dev-images used by mwcli
Closed, DeclinedPublic4 Estimated Story Points

Description

Install php-luasandbox on php dev-images

Background: https://www.mediawiki.org/wiki/LuaSandbox

Acceptance criteria:

  • php-luasandbox is installed for the following base images, which the php dev images are based on:
    • buster-php72
    • buster-php73
    • buster-php74
    • buster-php80
  • LuaSandbox shows up as a result of running phpinfo() and get_loaded_extensions() from a docker container created from the php dev images
  • New images published on the Wikimedia docker registry

Details

Other Assignee
jeena
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Draft: Add php-luasandboxrepos/releng/dev-images!9brennenwork/brennen/php-luasandboxmain
Customize query in GitLab

Event Timeline

jeena updated the task description. (Show Details)
brennen changed the task status from Open to In Progress.Oct 19 2021, 9:54 PM
brennen claimed this task.
brennen updated Other Assignee, added: jeena.

Work-in-progress from today's pairing session: https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/9

brennen triaged this task as Medium priority.Oct 19 2021, 9:55 PM
brennen changed the point value for this task from 1 to 4.
brennen changed the task status from In Progress to Stalled.Dec 8 2021, 4:09 PM
brennen removed brennen as the assignee of this task.
Addshore moved this task from Watching & Blocked to Review on the a Wikimedia CLI board.

Marking as declined, but also will note the below...

Considered, but I dont really want to maintain another set of images for mwcli.
Instead, inline with T298484: [mwcli docker] Document how to user Dockerfile overrides for mediawiki service there is functioanlity now to easily define custom Dockerfiles, and the mediawiki one at least has an example right now..