Page MenuHomePhabricator
Create Task
Maniphest T286688

[minor-wmf.14] MediaSearch - "sdms-did-you-mean" displays ' haswbstatement'
Closed, ResolvedPublic
Actions

Description

  1. On Special:MediaSearch enter search terms that would display "Did you mean", e.g. "pika" (https://commons.wikimedia.org/w/index.php?title=Special:MediaSearch&go=Go&type=image&search=pika)
  2. When Did you mean: pike will be displayed, click on one of the Community assessments filter - e.g. https://commons.wikimedia.org/w/index.php?title=Special:MediaSearch&go=Go&type=image&search=pika&assessment=valued-image

Did you mean: haswbstatement:P6731=Q63348040 pike will be displayed.

Screen Shot 2021-07-14 at 5.36.42 PM.png (1×1 px, 503 KB)

Note: Sometime "Did you mean" suggests modifications to the search terms that look unreasonable, e.g. searching for "dark roses" returns 6,602 results, yet "Did you mean dark robes" suggestion will be displayed that returns only 685 results.

Details

SubjectRepoBranchLines +/-
MediaSearch - "sdms-did-you-mean" displays ' haswbstatement'mediawiki/extensions/MediaSearchmaster+46 -15
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jul 14 2021, 11:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2021, 11:44 PM
Etonkovidova mentioned this in T279098: Fix MediaSearch to-dos.Jul 14 2021, 11:49 PM
Etonkovidova renamed this task from [minor-wmf.14] "sdms-did-you-mean" displays html when MediaSearch page is refreshed to [minor-wmf.14] MediaSearch - "sdms-did-you-mean" display issues.Jul 15 2021, 12:45 AM
Etonkovidova updated the task description. (Show Details)
Etonkovidova mentioned this in T266345: Determine how to migrate messages from WBMI to new MediaSearch extension.Jul 15 2021, 1:19 AM
AntiCompositeNumber added a project: SDAW-MediaSearch.Jul 15 2021, 1:22 AM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptJul 15 2021, 1:22 AM
Etonkovidova renamed this task from [minor-wmf.14] MediaSearch - "sdms-did-you-mean" display issues to [minor-wmf.14] MediaSearch - "sdms-did-you-mean" displays ' haswbstatement'.Jul 19 2021, 4:40 PM
Etonkovidova updated the task description. (Show Details)
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jul 19 2021, 4:43 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
SimoneThisDot subscribed.Jul 21 2021, 12:49 PM

I have investigated the task and found the issue being due to the haswbstatement not being filtered out on the Vue side.

There is a method the actions.js file called "extractSuggestedTerm". This method is failing to remove the extra filter fro the string, as the "filters" variable does not include the haswbstatement.

The proposed fix would be toL

  • enhance the extractSuggerstedTerm to also take care of filterValues.assessments
gerritbot added a comment.Jul 22 2021, 8:05 AM

Change 706313 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] MediaSearch - \"sdms-did-you-mean\" displays ' haswbstatement'

https://gerrit.wikimedia.org/r/706313

gerritbot added a project: Patch-For-Review.Jul 22 2021, 8:05 AM
SimoneThisDot claimed this task.Jul 22 2021, 8:06 AM
SimoneThisDot moved this task from Ready for Estimation to Code Review on the Structured-Data-Backlog (Current Work) board.

The following work has been completed

  • enhance the extractSuggerstedTerm in vue actions to work with filterValues.assessments
  • Enhance the extractSuggestedTerm in the PHP side to work with assessments

Tested scenarios:

  • Normal search with suggestion
  • PHP rendered search with "assessments"
  • VUE rendered search with "assessments"

bug: T286688
Change-Id: I3326f46d14183cddd61baf472236f8436c67bbf2

Meow moved this task from Incoming to Thumbnail and file renderings on the Commons board.Jul 28 2021, 9:00 AM
Meow moved this task from Thumbnail and file renderings to Incoming on the Commons board.Jul 28 2021, 9:03 AM
Seddon moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Aug 4 2021, 9:31 AM
gerritbot added a comment.Aug 4 2021, 9:51 AM

Change 706313 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] MediaSearch - \"sdms-did-you-mean\" displays ' haswbstatement'

https://gerrit.wikimedia.org/r/706313

• Jseddon mentioned this in rEMED9ce1edf9c036: MediaSearch - "sdms-did-you-mean" displays ' haswbstatement'.Aug 4 2021, 9:51 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 4 2021, 10:10 AM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Aug 6 2021, 12:07 AM
Etonkovidova closed this task as Resolved.Aug 12 2021, 12:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL