Page MenuHomePhabricator

Notification not sent when a comment is added in a sub-section of the topic one subscribed to
Closed, ResolvedPublic

Description

Notification is not sent when a comment is added in a sub-section of the topic one subscribed to.

This happens because the interface only allows you to subscribe to sections with level 2 headings, but we attempt to send notifications to subscribers of the closest heading, even if it's level 3 (or some other level).

Test case: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:T286736

For example, this problem would occur in discussions like this:

Event Timeline

Change 701542 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix notifications when new comment is under subheading

https://gerrit.wikimedia.org/r/701542

ppelberg added a subscriber: ppelberg.

Nice spot, Bartosz.

Change 701542 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix notifications when new comment is under subheading

https://gerrit.wikimedia.org/r/701542

ppelberg moved this task from High Priority to Low Priority on the Editing QA board.
ppelberg moved this task from Low Priority to High Priority on the Editing QA board.