| Pginer-WMF | |
| Jul 16 2021, 2:32 PM |
| F34925592: test.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&page=Moon&from=en&to=es&sx=true(iPhone SE).png | |
| Jan 21 2022, 11:23 AM |
| F34764504: image.png | |
| Nov 24 2021, 10:56 AM |
| F34553287: empty-reference-card.webm | |
| Jul 16 2021, 2:32 PM |
When editing a sentence with references in Section Translation, selecting the references shows a preview card as it is expected in Mobile Visual Editor. However, the card is shown empty.
I used as an example the translation of the "Formation" section of the Moon article from English to Spanish using Google Translate (example link). It seems to happen on all references but the video below shows the example for the first sentence of the section:
 |  |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T243495 [Epic] Support for Section Translation | |||
| Open | None | T295138 Support References in Section Translation | |||
| Open | None | T275492 Section Translation: Support for specific types of content | |||
| Resolved | santhosh | T286788 Reference card is initially shown empty in Section translation |
Change 741102 had a related patch set uploaded (by Santhosh; author: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Fix empty reference cards in visual editor
I debugged this issue and found that the preview element created by ve.ui.MWReferenceContextItem uses default arguments of ve.ui.MWPreviewElement. ve.ui.MWPreviewElement has useView configuration as false by default and causes not rendering the references from its DOM model as required for section translation.
As a workaround, I created a custom getRendering method in Section translation and use it as as override for ve.ui.MWReferenceContextItem.prototype.getRendering(see https://gerrit.wikimedia.org/r/741102). It fixed the issue, but I am not happy with this method as I am having a copy of ve.ui.MWReferenceContextItem.prototype.getRendering in SX detached from the updates in upstream.
@DLynch @matmarex Do you have any suggestions for better fix?
Change 741102 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix empty reference cards in visual editor
Great! The details are showing in the card:
As I was testing this I noticed that the links in the card try to leave the editor instead of opening on a new window. So users cannot actually check them (otherwise they would lose their work). I created a separate task for this: T299755: Clicking a link in the reference inspector leaves the editor
Change 760901 had a related patch set uploaded (by Santhosh; author: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX: Avoid empty reference cards when clicked
Change 760901 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX: Avoid empty reference cards when clicked