Page MenuHomePhabricator

Remove use of Grunt in RelatedArticles extension
Closed, ResolvedPublic

Description

RelatedArticles uses Grunt. This is unnecessary and inconsistent with our other repositories.

See T206462 for prior art on the how.

  • Gruntfile is removed.
  • grunt is no longer a dependency
  • grunt-eslint is no longer a dependency
  • grunt-stylelint is no longer a dependency
  • banana-checker is not using grunt (grunt-banana-checker can be retained as it works without)

Event Timeline

Jdlrobson triaged this task as Medium priority.Jul 20 2021, 7:07 PM

Hello there. Can I work on this task?

I have already cloned the repo from Gerrit, and uninstalled the necessary packages that are no longer a dependency. Please provide some guidance on committing and pushing my commit for review since I am fairly new to Gerrit and do not know my way around using Gerrit, but I am familiar with using git.

@Aacaldwell yes you can work on this task. I recommend using https://www.mediawiki.org/wiki/Gerrit/Tutorial for getting setup with Gerrit to push your change. You can use its associated talk page to ask any questions.

Change 709510 had a related patch set uploaded (by Acaldwell; author: Acaldwell):

[mediawiki/extensions/RelatedArticles@master] RelatedArticles uses Grunt. This package is unecessary and inconsistent with other repositories.

https://gerrit.wikimedia.org/r/709510

Change 709510 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] RelatedArticles uses Grunt. This package is unecessary and inconsistent with other repositories.

https://gerrit.wikimedia.org/r/709510

Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

Thank you @Aacaldwell ! Congratulations on your first merged Gerrit patch and becoming a MediaWiki developer!

Hopefully, this will be the first of many!

@Jdlrobson no problem! I'm already scouting for another task to do. :)

Perhaps https://phabricator.wikimedia.org/T284251 may be of interest if you want to continue working on this extension ? It requires some JavaScript knowledge.

I saw that task, but I'm researching how to use IntersectionObserver.

I already removed the module itself, but I had guessed that you would need the IntersectionObserver implemented in the same commit.