Page MenuHomePhabricator

Closing the Quickview via keyboard does not restore focus properly
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Navigate to Special:MediaSearch and search for something on the images tab
  • Use the keyboard to navigate to the search results grid (keep hitting TAB)
  • Hit enter to open the quickview once a particular search result is focused (will have a blue outline)
  • Focus is now moved to the "close" icon in the top-left corner of the quickview. Hit enter again to close the panel.

What happens?:
The panel closes, but focus is not restored to the originating search result in the grid

What should have happened instead?:
Users who close the quickview panel via keyboard interaction (*not* clicking the button with the mouse) should have their focus restored to the search result in the grid that they had previously focused on.

Event Timeline

Change 705031 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/MediaSearch@master] Ensure focus is restored when Quickview is closed via keyboard

https://gerrit.wikimedia.org/r/705031

Change 705031 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Ensure focus is restored when Quickview is closed via keyboard

https://gerrit.wikimedia.org/r/705031

Etonkovidova added a subscriber: Etonkovidova.

Checked in betalabs - works as expected.

Checked on commons wmf.16 - works as expected.