Page MenuHomePhabricator
Create Task
Maniphest T286909

Create source and type dispatching EntityArticleIdLookup
Closed, ResolvedPublic
Actions

Description

Make TypeDispatchingArticleIdLookup to also dispatch by source.
Get rid of the default lookup passed to that class.

Details

SubjectRepoBranchLines +/-
FP: make TypeDispatchingArticleIdLookup dispatch also by sourcemediawiki/extensions/Wikibasemaster+129 -117
Add ARTICLE_ID_LOOKUP_CALLBACK to entityTypeDefinitionsmediawiki/extensions/WikibaseLexememaster+17 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Jul 19 2021, 12:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2021, 12:48 PM
• Tonina_Zhelyazkova_WMDE edited parent tasks, added: T286276: Make wbsearchentities API work with local and remote properties; removed: T286719: Make wbsearchentities work for search by term.Jul 19 2021, 1:55 PM
• Tonina_Zhelyazkova_WMDE moved this task from Federation v2 - Sprint 2 to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.
• Tonina_Zhelyazkova_WMDE edited projects, added Wikibase - Federated Properties; removed Wikibase - Federated Properties (Federation v2 - Sprint 2).
• Tonina_Zhelyazkova_WMDE moved this task from Prioritized backlog (aka Ready to pick up) to Federation v2 - Sprint 3 on the Wikibase - Federated Properties board.Jul 28 2021, 12:16 PM
• Tonina_Zhelyazkova_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 3); removed Wikibase - Federated Properties.
Tarrow claimed this task.Jul 28 2021, 1:43 PM
Tarrow moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.
gerritbot added a comment.Jul 30 2021, 9:46 AM

Change 708985 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] FP: make TypeDispatchingArticleIdLookup dispatch also by source

https://gerrit.wikimedia.org/r/708985

gerritbot added a project: Patch-For-Review.Jul 30 2021, 9:46 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Aug 3 2021, 11:01 AM
Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Aug 3 2021, 12:58 PM
gerritbot added a comment.Aug 5 2021, 10:32 AM

Change 710233 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/WikibaseLexeme@master] Add ARTICLE_ID_LOOKUP_CALLBACK to entityTypeDefinitions

https://gerrit.wikimedia.org/r/710233

Tarrow moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Aug 5 2021, 10:43 AM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 4); removed Wikibase - Federated Properties (Federation v2 - Sprint 3).Aug 5 2021, 11:08 AM
• Samantha_Alipio_WMDE moved this task from To do to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.
gerritbot added a comment.Aug 6 2021, 9:15 AM

Change 710233 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add ARTICLE_ID_LOOKUP_CALLBACK to entityTypeDefinitions

https://gerrit.wikimedia.org/r/710233

gerritbot added a comment.Aug 6 2021, 9:15 AM

Change 708985 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: make TypeDispatchingArticleIdLookup dispatch also by source

https://gerrit.wikimedia.org/r/708985

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 6 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 6 2021, 10:10 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.Aug 6 2021, 10:57 AM
Addshore closed this task as Resolved.Aug 24 2021, 9:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL