Maniphest T286916

Change ApiEntitySearchHelper to work with FederatedPropertyId
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Tonina_Zhelyazkova_WMDE
	Jul 19 2021, 2:26 PM

Tags

Referenced Files

None

Subscribers

• Tonina_Zhelyazkova_WMDE

Description

ApiEntitySearchHelper currently creates PropertyIds in its results where we probably want to have FederatedPropertyIds.

Details

	Subject	Repo	Branch	Lines +/-
	FP: inject source into ApiEntitySearchHelper	mediawiki/extensions/Wikibase	master	+128 -47
	FP: Change ApiEntitySearchHelper to return results with FederatedPropertyId	mediawiki/extensions/Wikibase	master	+68 -9

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T286276 Make wbsearchentities API work with local and remote properties
		Resolved		Addshore	T286719 Make wbsearchentities work for search by term
		Resolved		Rosalie_WMDE	T286916 Change ApiEntitySearchHelper to work with FederatedPropertyId

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Jul 19 2021, 2:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2021, 2:26 PM

Rosalie_WMDE claimed this task.Jul 20 2021, 9:49 AM

Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.

Rosalie_WMDE updated the task description. (Show Details)Jul 20 2021, 10:09 AM

Change 705850 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] FP: Change ApiEntitySearchHelper to return results with FederatedPropertyId

https://gerrit.wikimedia.org/r/705850

gerritbot added a project: Patch-For-Review.Jul 21 2021, 10:20 AM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 21 2021, 10:49 AM

Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 21 2021, 12:46 PM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 3); removed Wikibase - Federated Properties (Federation v2 - Sprint 2).Jul 22 2021, 11:18 AM

• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 26 2021, 8:48 AM

Change 705850 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change ApiEntitySearchHelper to return results with FederatedPropertyId

https://gerrit.wikimedia.org/r/705850

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 27 2021, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2021, 9:10 AM

Change 708267 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: inject source into ApiEntitySearchHelper

https://gerrit.wikimedia.org/r/708267

gerritbot added a project: Patch-For-Review.Jul 27 2021, 10:27 AM

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 27 2021, 3:10 PM

Change 708267 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: inject source into ApiEntitySearchHelper

https://gerrit.wikimedia.org/r/708267

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2021, 4:10 PM

Jakob_WMDE mentioned this in T287572: Show the correct concept URI in search results.Jul 28 2021, 11:21 AM

Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM