Page MenuHomePhabricator
Create Task
Maniphest T286917

Wrap TypeDispatchingEntitySearchHelper in a service
Closed, ResolvedPublic
Actions

Description

See parent task's comment.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FP: Start using EntitySearchHelper in SearchEntitiesmediawiki/extensions/Wikibasemaster+2 -6
FP: Introduce EntitySearchHelper servicemediawiki/extensions/Wikibasemaster+94 -0
FP: Introduce FedPropertiesTypeDispatchingEntitySearchHelpermediawiki/extensions/Wikibasemaster+152 -0
FP: Introduce EntitySerchHelper servicemediawiki/extensions/Wikibasemaster+70 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Jul 19 2021, 2:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2021, 2:29 PM
• Tonina_Zhelyazkova_WMDE claimed this task.Jul 19 2021, 4:15 PM
• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.
• Tonina_Zhelyazkova_WMDE renamed this task from Create a CombinedEntitySearchHelper to Create a CombinedEntityTermSearchHelper.Jul 20 2021, 8:36 AM
• Tonina_Zhelyazkova_WMDE renamed this task from Create a CombinedEntityTermSearchHelper to Wrap TypeDispatchingEntitySearchHelper in a service.Jul 20 2021, 1:12 PM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jul 21 2021, 1:01 PM

Change 705870 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Introduce EntitySerchHelper service

https://gerrit.wikimedia.org/r/705870

gerritbot added a project: Patch-For-Review.Jul 21 2021, 1:01 PM
gerritbot added a comment.Jul 22 2021, 8:51 AM

Change 705870 abandoned by Tonina Zhelyazkova:

[mediawiki/extensions/Wikibase@master] FP: Introduce EntitySerchHelper service

Reason:

we'll have a different solution

https://gerrit.wikimedia.org/r/705870

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2021, 9:10 AM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 3); removed Wikibase - Federated Properties (Federation v2 - Sprint 2).Jul 22 2021, 11:18 AM
• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.
gerritbot added a comment.Jul 22 2021, 4:03 PM

Change 706317 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Introduce FedPropertiesTypeDispatchingEntitySearchHelper

https://gerrit.wikimedia.org/r/706317

gerritbot added a project: Patch-For-Review.Jul 22 2021, 4:03 PM
gerritbot added a comment.Jul 22 2021, 4:10 PM

Change 706567 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Introduce EntitySearchHelper service

https://gerrit.wikimedia.org/r/706567

gerritbot added a comment.Jul 22 2021, 4:31 PM

Change 706575 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Start using EntitySearchHelper is SearchEntities

https://gerrit.wikimedia.org/r/706575

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 23 2021, 8:31 AM
gerritbot added a comment.Jul 23 2021, 2:03 PM

Change 706317 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Introduce FedPropertiesTypeDispatchingEntitySearchHelper

https://gerrit.wikimedia.org/r/706317

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 23 2021, 3:00 PM
gerritbot added a comment.Jul 26 2021, 8:54 AM

Change 706567 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Introduce EntitySearchHelper service

https://gerrit.wikimedia.org/r/706567

gerritbot added a comment.Jul 26 2021, 8:57 AM

Change 706575 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Start using EntitySearchHelper in SearchEntities

https://gerrit.wikimedia.org/r/706575

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 26 2021, 9:39 AM
Jakob_WMDE mentioned this in T287572: Show the correct concept URI in search results.Jul 28 2021, 11:21 AM
Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits