Page MenuHomePhabricator
Create Task
Maniphest T286929

[minor-wmf.14] MediaSearch - "Did you mean" displays html code when page reloads
Closed, ResolvedPublic
Actions

Description

  1. On Special:MediaSearch enter search terms that would display "Did you mean", e.g. "pika"
  2. When Did you mean: pike will be displayed, refresh the page.

The html text will flash (on a slow network connection, it is quite noticeable):
Did you mean: <a href="/w/index.php?title=Special:MediaSearch&go=Go&type=image&search=pike">pike</a>

Screen Shot 2021-07-14 at 4.31.29 PM.png (1×2 px, 2 MB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MediaSearch - "Did you mean" displays html code when page reloadsmediawiki/extensions/MediaSearchmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jul 19 2021, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2021, 4:46 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jul 26 2021, 4:36 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
SimoneThisDot claimed this task.Jul 27 2021, 8:16 AM
SimoneThisDot moved this task from Ready for Estimation to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Jul 27 2021, 8:17 AM

Change 708245 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] MediaSearch - \"Did you mean\" displays html code when page reloads

https://gerrit.wikimedia.org/r/708245

gerritbot added a project: Patch-For-Review.Jul 27 2021, 8:17 AM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jul 27 2021, 8:18 AM
Meow moved this task from Incoming to Thumbnail and file renderings on the Commons board.Jul 28 2021, 9:00 AM
Meow moved this task from Thumbnail and file renderings to Incoming on the Commons board.Jul 28 2021, 9:03 AM
Seddon moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Aug 2 2021, 12:08 PM
gerritbot added a comment.Aug 2 2021, 12:28 PM

Change 708245 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] MediaSearch - \"Did you mean\" displays html code when page reloads

https://gerrit.wikimedia.org/r/708245

SimoneThisDot mentioned this in rEMED6301c9ced5cf: MediaSearch - "Did you mean" displays html code when page reloads.Aug 2 2021, 12:29 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 2 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2021, 1:10 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Aug 3 2021, 4:40 PM
Etonkovidova closed this task as Resolved.Aug 4 2021, 9:09 PM

Checked on`commons wmf.17` - the fix is in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits