Page MenuHomePhabricator

WatchlistUtils wrongly overrides sorts new pages
Closed, ResolvedPublic2 Estimated Story Points

Description

I noticed while testing something else on patchdemo that the order of new page creations was wrong, and figured out that we are currently overwriting the revid and old_revid for new page creations with 0 instead of using the real values that exist (originally I added the setting to 0 because I didn't realize that the values were already there during T257428: Refactor utils to avoid duplicate rows for new pages with edits)

I originally thought it was because the logic to sort edits uses timestamps and we are truncating the timestamps before sorting, but that falls back the rev id and thus the problem above; both should be fixed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 705472 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/GlobalWatchlist@master] WatchlistUtils: fix new page handling and timestamp sorting

https://gerrit.wikimedia.org/r/705472

DannyS712 set the point value for this task to 2.

Change 705472 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] WatchlistUtils: fix new page handling and timestamp sorting

https://gerrit.wikimedia.org/r/705472

DannyS712 claimed this task.
DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.
DannyS712 set Final Story Points to 3.