Page MenuHomePhabricator
Create Task
Maniphest T286979

Account name not identified in "get edits" in CheckUser results
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to Special:CheckUser and do a check (go to the "get edits" page after getting the IP)
  • Look for the user creation part of the log

What happens?:
You will notice the result not displaying the correct username of the user being checked. Example (with name generalized) of what it says:
"User account Unknown user was created"

What should have happened instead?:
It should have the username instead.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Considering the problem has happened for usernames from July 13 onward, I assume it is related to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684142?

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+31 -15RCDatabaseLogEntry: Stop returning an unknown actor if rc_user is given
Customize query in gerrit

Related Objects

Event Timeline

Bsadowski1 created this task.Jul 20 2021, 6:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2021, 6:18 AM
DannyS712 added projects: CheckUser, Regression.Jul 20 2021, 6:52 AM
DannyS712 added a subscriber: DannyS712.Jul 20 2021, 7:06 AM
Bsadowski1 renamed this task from Account name not identified in "get users" in CheckUser results to Account name not identified in "get edits" in CheckUser results.Jul 20 2021, 8:10 AM
Zabe added a subscriber: Zabe.Jul 20 2021, 3:55 PM
MarcoAurelio added a subscriber: MarcoAurelio.Jul 20 2021, 6:55 PM
Stanglavine added a subscriber: Stanglavine.Sep 14 2021, 8:52 PM
Tks4Fish added a subscriber: Tks4Fish.Sep 14 2021, 8:56 PM
Stanglavine added a comment.Sep 14 2021, 9:04 PM

I saw the same situation on ptwiki, but for page move log, thanks log and abuse filter log too.

RhinosF1 added a project: MW-1.37-release.Oct 13 2021, 9:58 PM
Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptOct 13 2021, 9:58 PM
Universal_Omega added a subscriber: Universal_Omega.Oct 13 2021, 11:34 PM
dmehus added a project: User-RhinosF1.Oct 14 2021, 1:44 AM
dmehus moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.
dmehus added a subscriber: dmehus.
Reedy moved this task from Blocker to Not a blocker on the MW-1.37-release board.Oct 19 2021, 4:37 PM
gerritbot added a comment.Oct 23 2021, 6:16 AM

Change 729525 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/core@master] RCDatabaseLogEntry: Stop returning an unknown actor if rc_user is given

https://gerrit.wikimedia.org/r/729525

gerritbot added a project: Patch-For-Review.Oct 23 2021, 6:16 AM
Lens0021 added a subscriber: Lens0021.Oct 23 2021, 6:21 AM

Same issue on a third-party extension, DiscordRCFeed. https://github.com/femiwiki/DiscordRCFeed/issues/46

Lens0021 claimed this task.Oct 23 2021, 6:21 AM
Lens0021 added a project: MediaWiki-Recent-changes.Oct 23 2021, 6:50 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 23 2021, 6:50 AM
Tgr moved this task from Inbox to Upcoming Work on the Growth-Team board.Oct 26 2021, 12:27 AM
Tgr edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Tgr moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Urbanecm_WMF changed the task status from Open to In Progress.Jan 31 2022, 11:33 AM
Tks4Fish merged a task: T300671: User creation logs in CheckUser show "Unknown user" instead of the username.Feb 5 2022, 4:53 PM
Tks4Fish added subscribers: Huji, Ladsgroup.
Ladsgroup added a comment.Feb 5 2022, 5:01 PM

I reviewed and +2'd the patch, please let me know next week to close this ticket.

gerritbot added a comment.Feb 5 2022, 5:12 PM

Change 729525 merged by jenkins-bot:

[mediawiki/core@master] RCDatabaseLogEntry: Stop returning an unknown actor if rc_user is given

https://gerrit.wikimedia.org/r/729525

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 5 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 5 2022, 6:10 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Feb 7 2022, 10:43 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Current Sprint) board.Feb 8 2022, 1:26 AM
Etonkovidova added subscribers: dom_walden, Etonkovidova.Feb 11 2022, 10:15 PM
In T286979#7353405, @Stanglavine wrote:

I saw the same situation on ptwiki, but for page move log, thanks log and abuse filter log too.

I checked the following log pages and the corresponding pages on ptwiki wmf.21 - usernames are displayed:
https://test.wikipedia.org/wiki/Special:Log?type=move&user=&page=&wpdate=&tagfilter=
https://test.wikipedia.org/wiki/Special:Log?type=thanks&user=&page=&wpdate=&tagfilter=&subtype=
https://test.wikipedia.org/wiki/Special:Log?type=abusefilter&user=&page=&wpdate=&tagfilter=

@dom_walden can you check for Special:CheckUser on testwiki wmf.21? I don't have checkuser permission.

Huji added a comment.EditedFeb 12 2022, 2:48 AM

Still an issue on fawiki. Can see it in account creation logs as of Feb 8, in AbuseFilter related CU logs as of Feb 10.

Or was this moved to production after Feb 10?

Urbanecm added a subscriber: Urbanecm.Feb 12 2022, 11:36 AM
In T286979#7705381, @Huji wrote:

Still an issue on fawiki. Can see it in account creation logs as of Feb 8, in AbuseFilter related CU logs as of Feb 10.

Or was this moved to production after Feb 10?

This was pushed to fawiki (and all other wikis) with https://sal.toolforge.org/log/v55A5X4B1jz_IcWubjDr, ie. at 2022-02-10T20:08 UTC.

I tested at testwiki and it looks good to me:

image.png (341×902 px, 33 KB)

Etonkovidova closed this task as Resolved.Feb 14 2022, 4:45 PM
Etonkovidova added a subscriber: Urbanecm_WMF.
In T286979#7705458, @Urbanecm wrote:
In T286979#7705381, @Huji wrote:

Still an issue on fawiki. Can see it in account creation logs as of Feb 8, in AbuseFilter related CU logs as of Feb 10.

Or was this moved to production after Feb 10?

This was pushed to fawiki (and all other wikis) with https://sal.toolforge.org/log/v55A5X4B1jz_IcWubjDr, ie. at 2022-02-10T20:08 UTC.

I tested at testwiki and it looks good to me:

image.png (341×902 px, 33 KB)

Thx, @Urbanecm_WMF - closing the task as Resolved.

Restricted Application removed a subscriber: Urbanecm. · View Herald TranscriptFeb 14 2022, 4:45 PM
Maintenance_bot moved this task from Miraheze-Linked to Done on the User-RhinosF1 board.Feb 14 2022, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL