Regression: More menu dropdown font-size is too big in legacy Vector
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 20 2021, 10:19 PM

Description

Due to the icon changes in T191021 there has been a slight regression in legacy Vector that must be fixed before 1.37.0-wmf.16

Currently beta cluster only
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector&useskinversion=1

Screen Shot 2021-07-20 at 3.17.30 PM.png (364×298 px, 33 KB)

Expected:

Screen Shot 2021-07-20 at 3.16.52 PM.png (230×158 px, 10 KB)

QA steps

In Vector legacy, log in as an admin (might need additional permissions from Jon)
Click the more button.
Verify the font-size on beta cluster is consistent with production

This can skip QA in prod as it's a regression that hasn't happened in production.

QA Results - Beta

AC	Status	Details
1	✅	T287052#7229114

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	master	+4 -0	Fix dropdown font sizing in legacy vector

Customize query in gerrit

Related Objects

Mentioned In: T288367: More menu items are too large in modern Vector skin
T288336: Tab font-size is not applied to menu item links
Mentioned Here: T191021: User links: Standardize `.mw-ui-icon` to overhauled icon canvas size 20x20

Event Timeline

Jdlrobson created this task.Jul 20 2021, 10:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2021, 10:19 PM

Jdlrobson triaged this task as High priority.Jul 20 2021, 10:19 PM

Jdlrobson set the point value for this task to 0.

Jdlrobson moved this task from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson added a parent task: T281158: 1.37.0-wmf.17 deployment blockers.Jul 21 2021, 1:21 AM

bwang removed bwang as the assignee of this task.Jul 21 2021, 2:26 PM

bwang moved this task from Ready for Development to Code Review on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

bwang added a subscriber: bwang.

Change 705897 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix dropdown font sizing in legacy vector

https://gerrit.wikimedia.org/r/705897

gerritbot added a project: Patch-For-Review.Jul 21 2021, 2:29 PM

Jdlrobson updated the task description. (Show Details)Jul 21 2021, 3:55 PM

Change 705897 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix dropdown font sizing in legacy vector

https://gerrit.wikimedia.org/r/705897

Jdlrobson assigned this task to Edtadros.Jul 21 2021, 4:20 PM

Jdlrobson moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Jul 21 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2021, 5:10 PM

Jdlrobson removed a parent task: T281158: 1.37.0-wmf.17 deployment blockers.Jul 21 2021, 11:42 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In Vector legacy, log in as an admin (might need additional permissions from Jon)
Click the more button.
✅ AC1: Verify the font-size on beta cluster is consistent with production

Beta	Prod

Edtadros updated the task description. (Show Details)Jul 22 2021, 12:31 AM

Looks good, resolving!

Jdlrobson merged a task: T287794: Display issue regarding the font size.Aug 2 2021, 7:23 PM

Jdlrobson added subscribers: Jean-Mahmood, Pcoombe.

BrandonXLF mentioned this in T288336: Tab font-size is not applied to menu item links.Aug 6 2021, 9:04 AM

I may be mistaken but I think this caused T287052

	F34559297: Screen Shot 2021-07-21 at 5.05.03 PM.png
	Jul 22 2021, 12:29 AM

	F34559295: Screen Shot 2021-07-21 at 5.04.54 PM.png
	Jul 22 2021, 12:29 AM

	F34558126: Screen Shot 2021-07-20 at 3.16.52 PM.png
	Jul 20 2021, 10:19 PM

	F34558127: Screen Shot 2021-07-20 at 3.17.30 PM.png
	Jul 20 2021, 10:19 PM

Regression: More menu dropdown font-size is too big in legacy VectorClosed, ResolvedPublic0 Estimated Story PointsActions