Page MenuHomePhabricator

Regression: More menu dropdown font-size is too big in legacy Vector
Closed, ResolvedPublic0 Estimated Story Points

Description

Due to the icon changes in T191021 there has been a slight regression in legacy Vector that must be fixed before 1.37.0-wmf.16

Currently beta cluster only
https://en.wikipedia.beta.wmflabs.org/wiki/Spain?useskin=vector&useskinversion=1

Screen Shot 2021-07-20 at 3.17.30 PM.png (364×298 px, 33 KB)

Expected:

Screen Shot 2021-07-20 at 3.16.52 PM.png (230×158 px, 10 KB)

QA steps

  • In Vector legacy, log in as an admin (might need additional permissions from Jon)
  • Click the more button.
  • Verify the font-size on beta cluster is consistent with production

This can skip QA in prod as it's a regression that hasn't happened in production.

QA Results - Beta

ACStatusDetails
1T287052#7229114

Event Timeline

Jdlrobson set the point value for this task to 0.
bwang removed bwang as the assignee of this task.Jul 21 2021, 2:26 PM
bwang added a subscriber: bwang.

Change 705897 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix dropdown font sizing in legacy vector

https://gerrit.wikimedia.org/r/705897

Change 705897 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix dropdown font sizing in legacy vector

https://gerrit.wikimedia.org/r/705897

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

In Vector legacy, log in as an admin (might need additional permissions from Jon)
Click the more button.
✅ AC1: Verify the font-size on beta cluster is consistent with production

BetaProd
Screen Shot 2021-07-21 at 5.04.54 PM.png (1×706 px, 400 KB)
Screen Shot 2021-07-21 at 5.05.03 PM.png (1×739 px, 394 KB)

Looks good, resolving!