Page MenuHomePhabricator
Create Task
Maniphest T287059

[wmf.14 - minor] mobile - small screens do not displaye three-dot menu fully
Closed, ResolvedPublic
Actions

Description

This tiny bug is displayed on mobile devices with the viewport 360 (and lower). The screenshot is taken on Samung Galaxy 360x740

  1. Go to an article with link recommendation.
  2. Answer 'no' - the three-dot menu will display only two dots. Note: a browser simulator would display one dot.

Screenshot_20210720-152701_Chrome.jpg (2×1 px, 487 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add a link: Take into account the reopen rejection dialog button in updateActionButtonsModemediawiki/extensions/GrowthExperimentsmaster+9 -2
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Jul 20 2021, 11:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2021, 11:30 PM
Etonkovidova renamed this task from [wmf.14 -minor] mobile - small screens do not displaye three-dot menu fully to [wmf.14 - minor] mobile - small screens do not displaye three-dot menu fully.Jul 21 2021, 12:14 AM
• mewoph claimed this task.Jul 21 2021, 6:59 PM
• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Currently the calculation to determine whether the buttons should be on a separate line doesn't take into account the ellipsis button.

gerritbot added a comment.Jul 21 2021, 7:37 PM

Change 706022 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Take into account the reopen rejection dialog button in updateActionButtonsMode

https://gerrit.wikimedia.org/r/706022

gerritbot added a project: Patch-For-Review.Jul 21 2021, 7:37 PM
• mewoph added a comment.Jul 21 2021, 7:39 PM

With latest changes:

addlink_mobileEllipsis.gif (1×692 px, 914 KB)

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 21 2021, 7:39 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 2 2021, 10:46 AM
gerritbot added a comment.Aug 2 2021, 11:03 AM

Change 706022 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Take into account the reopen rejection dialog button in updateActionButtonsMode

https://gerrit.wikimedia.org/r/706022

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2021, 11:10 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 2 2021, 12:00 PM
Etonkovidova updated the task description. (Show Details)Aug 2 2021, 9:32 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 2 2021, 9:56 PM

Checked in betalabs - looks good; moved to Test in Production.

Etonkovidova closed this task as Resolved.Aug 3 2021, 9:33 PM
Urbanecm_WMF added a project: GrowthExperiments-NewcomerTasks.Wed, Jan 21, 2:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits