Page MenuHomePhabricator

[Regression wmf.14] Reply link doesn't work on production after clicking on a notification from within Echo, shows error "Uncaught TypeError: Cannot read property 'id' of undefined"
Closed, InvalidPublic

Description

Steps to reproduce:

  1. Go to this page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:Fourteenthuser/Kladblok using a user account "A".
  1. Subscribe to the first section "new topic".
  1. Post a reply for this topic using another user account "B".
  1. Log back in using user account A and check Echo notification panel.
  1. Click on the notification you received as a result of step 3.

Observed Result:

It takes you to the newly posted comment and highlights the comment from the other user. But if you click on any reply link it shows the following error and does not open the Reply tool.

Uncaught TypeError: Cannot read property 'id' of undefined

Expected Result: It should fade the highlight away and open the reply tool.

Screenshot/Screen capture:

Screen Shot 2021-07-21 at 2.49.39 PM.png (535×1 px, 198 KB)

Browser: Chrome

Wiki: nl wiki

Page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:Fourteenthuser/Kladblok

Environment: Production

Event Timeline

Great spot, @Ryasmeen. Although, I have not yet been able to reproduce the issue you encountered. See: https://youtu.be/fN5V7vb6-Os.

I cannot trigger this error.

I think we wouldn't expect the highlight to be removed yet, anyway, as that's in wmf.15 which hasn't reached nlwiki yet.

For testing, here's a link that will trigger the highlight on the referenced nlwiki page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:Fourteenthuser/Kladblok#c-73.162.172.164-2021-07-21T22:53:00.000Z-73.162.172.164-2021-07-21T22:47:00.000Z

And also on beta: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:TemplateUsageArticle587#c-Helppaneltest-2019-06-19T14:19:00.000Z-test

It looks like you're viewing the page through Google Translate, that's probably the cause of the problem.

It looks like you're viewing the page through Google Translate, that's probably the cause of the problem.

ah, you are right @matmarex! It does not happen when I disable Google Translate. Well..let's close this then :) Thanks for looking into it @ppelberg, @DLynch and @matmarex.