Page MenuHomePhabricator
Create Task
Maniphest T287156

Move Content::preSaveTransform method that don't belong in Content to ContentHandler
Closed, ResolvedPublic
Actions

Description

These methods need to move to new corresponding methods in ContentHandler. Here's a patch that does the first part of the work for Content::preSaveTransform.

The signature of the ContentHandler method should be:

  • ContentHandler::preSaveTransform( Content, PageReference, UserIdentity, ParserOptions )

The process:

  • Do the same as in the referenced patch for all the methods.
  • In all extensions where Content overriding classes override the method - override the ContentHandler method instead
    • JsonContent
    • WikiLambda
    • CollaborationKit
    • ProofreadPage
    • MediaUploader
    • TEI
    • SemanticMediaWiki -> Issue, PR (not-deployed)
  • Replace all callers. Use ContentTransformer to obtain a ContentHandler::preSaveTransform, not the Content::getContentHandler method
  • Once all callers and overrides in extensions is done, do some hard deprecations.

Details

SubjectRepoBranchLines +/-
Hard-deprecate Content::preSaveTransform.mediawiki/coremaster+12 -103
Bump parsoid to 0.14.0-a16mediawiki/vendormaster+9 K -8 K
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/coremaster+75 -16
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/EventLoggingmaster+5 -2
Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.mediawiki/extensions/ProofreadPagemaster+161 -102
Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.mediawiki/extensions/CollaborationKitmaster+215 -204
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/TemplateSandboxmaster+23 -6
Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.mediawiki/extensions/TEImaster+73 -60
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/vendormaster+11 -3
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/VisualEditormaster+18 -9
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/services/parsoidmaster+15 -11
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/Flowmaster+8 -7
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/FileImportermaster+10 -2
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/TwoColConflictmaster+11 -2
Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.mediawiki/extensions/MediaUploadermaster+41 -31
Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.mediawiki/extensions/JsonConfigmaster+23 -19
Replace Content::preSaveTransform call to ContentTransformer::preSaveTransformmediawiki/extensions/MassMessagemaster+8 -3
Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.mediawiki/extensions/WikiLambdamaster+24 -21
Move Content::preSaveTransform to ContentHandlermediawiki/coremaster+397 -145
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

roman-stolar created this task.Jul 22 2021, 1:59 PM
roman-stolar moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.Jul 22 2021, 2:11 PM
gerritbot added a comment.Jul 22 2021, 2:49 PM

Change 705780 had a related patch set uploaded (by Roman Stolar; author: Ppchelko):

[mediawiki/core@master] Move Content::preSaveTransform to ContentHandler

https://gerrit.wikimedia.org/r/705780

gerritbot added a project: Patch-For-Review.Jul 22 2021, 2:49 PM
gerritbot added a comment.Jul 26 2021, 10:33 AM

Change 708083 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/ProofreadPage@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/708083

gerritbot added a comment.Jul 26 2021, 1:55 PM

Change 708117 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/JsonConfig@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/708117

gerritbot added a comment.Jul 29 2021, 7:25 PM

Change 705780 merged by jenkins-bot:

[mediawiki/core@master] Move Content::preSaveTransform to ContentHandler

https://gerrit.wikimedia.org/r/705780

gerritbot added a comment.Jul 30 2021, 9:07 AM

Change 708980 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/708980

gerritbot added a comment.Jul 30 2021, 2:00 PM

Change 708980 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/708980

roman-stolar updated the task description. (Show Details)Aug 2 2021, 9:02 AM
roman-stolar updated the task description. (Show Details)Aug 2 2021, 10:08 AM
gerritbot added a comment.Aug 2 2021, 12:58 PM

Change 709433 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/TwoColConflict@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709433

gerritbot added a comment.Aug 2 2021, 1:11 PM

Change 709467 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/MassMessage@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709467

gerritbot added a comment.Aug 2 2021, 2:38 PM

Change 709467 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709467

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 2 2021, 3:00 PM
gerritbot added a comment.Aug 3 2021, 1:55 PM

Change 709710 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/EventLogging@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709710

gerritbot added a comment.Aug 3 2021, 1:59 PM

Change 709714 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/FileImporter@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709714

gerritbot added a comment.Aug 3 2021, 2:08 PM

Change 709716 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Flow@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709716

gerritbot added a comment.Aug 3 2021, 2:23 PM

Change 708117 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/708117

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 3 2021, 3:00 PM
Jdforrester-WMF updated the task description. (Show Details)Aug 3 2021, 3:00 PM
gerritbot added a comment.Aug 4 2021, 12:10 PM

Change 710014 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/CollaborationKit@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/710014

gerritbot added a comment.Aug 4 2021, 1:39 PM

Change 710038 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/MediaUploader@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/710038

gerritbot added a comment.Aug 4 2021, 3:01 PM

Change 710038 merged by jenkins-bot:

[mediawiki/extensions/MediaUploader@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/710038

roman-stolar mentioned this in rEMEU94eddc2c5338: Override ContentHandler::preSaveTransform instead of Content::preSaveTransform..Aug 4 2021, 3:01 PM
DannyS712 added a project: MediaWiki-ContentHandler.Aug 5 2021, 5:10 AM
DannyS712 mentioned this in T288191: substituting {{#tag:ref}} tags and templates; and pipe tricks fail in Page namespace.
Billinghurst subscribed.Aug 5 2021, 5:53 AM

This has broken the Wikisources who were neither notified nor tagged. Bit ugly.

gerritbot added a comment.Aug 5 2021, 8:51 AM

Change 710220 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/TEI@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/710220

gerritbot added a comment.Aug 5 2021, 2:27 PM

Change 710270 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/TemplateSandbox@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710270

roman-stolar updated the task description. (Show Details)Aug 6 2021, 12:20 PM
gerritbot added a comment.Aug 6 2021, 12:36 PM

Change 710533 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/VisualEditor@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710533

roman-stolar updated the task description. (Show Details)Aug 6 2021, 1:39 PM
gerritbot added a comment.Aug 9 2021, 9:40 AM

Change 709433 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709433

roman-stolar mentioned this in rESCCc7a6fff4bf70: Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform.Aug 9 2021, 9:45 AM
gerritbot added a comment.Aug 9 2021, 10:12 AM

Change 710935 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/services/parsoid@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710935

gerritbot added a comment.Aug 9 2021, 10:22 AM

Change 710937 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/vendor@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710937

gerritbot added a comment.Aug 9 2021, 10:27 AM

Change 709714 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709714

roman-stolar updated the task description. (Show Details)Aug 10 2021, 12:47 PM
gerritbot added a comment.Aug 11 2021, 4:04 AM

Change 709716 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709716

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.19; 2021-08-16); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 11 2021, 5:00 AM
gerritbot added a comment.Aug 11 2021, 7:48 PM

Change 710935 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710935

gerritbot added a comment.Aug 11 2021, 8:07 PM

Change 710533 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710533

gerritbot added a comment.Aug 12 2021, 8:58 AM

Change 710937 abandoned by Roman Stolar:

[mediawiki/vendor@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

Reason:

vendor will be updated automatically when we bump parsoid version

https://gerrit.wikimedia.org/r/710937

gerritbot added a comment.Aug 12 2021, 12:26 PM

Change 710220 merged by jenkins-bot:

[mediawiki/extensions/TEI@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/710220

roman-stolar mentioned this in rETEIec8ad0548bdf: Override ContentHandler::preSaveTransform instead of Content::preSaveTransform..Aug 12 2021, 12:27 PM
roman-stolar updated the task description. (Show Details)Aug 13 2021, 11:51 AM
gerritbot added a comment.Aug 16 2021, 2:44 PM

Change 710270 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/710270

roman-stolar mentioned this in rETSAfe11c91544b6: Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform.Aug 16 2021, 2:51 PM
gerritbot added a comment.Aug 16 2021, 2:51 PM

Change 710014 merged by jenkins-bot:

[mediawiki/extensions/CollaborationKit@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/710014

roman-stolar updated the task description. (Show Details)Aug 17 2021, 9:13 AM
gerritbot added a comment.Aug 17 2021, 3:37 PM

Change 708083 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Override ContentHandler::preSaveTransform instead of Content::preSaveTransform.

https://gerrit.wikimedia.org/r/708083

roman-stolar updated the task description. (Show Details)Aug 17 2021, 3:44 PM
gerritbot added a comment.Aug 17 2021, 3:49 PM

Change 709710 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/709710

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.20; 2021-08-23); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 17 2021, 4:00 PM
roman-stolar updated the task description. (Show Details)Aug 18 2021, 9:38 AM
roman-stolar updated the task description. (Show Details)
gerritbot added a comment.Aug 19 2021, 9:46 AM

Change 713822 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/713822

gerritbot added a comment.Aug 19 2021, 10:18 AM

Change 713826 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Hard-deprecate Content::preSaveTransform.

https://gerrit.wikimedia.org/r/713826

roman-stolar updated the task description. (Show Details)Aug 19 2021, 10:26 AM
gerritbot added a comment.Aug 23 2021, 4:09 PM

Change 713822 merged by jenkins-bot:

[mediawiki/core@master] Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform

https://gerrit.wikimedia.org/r/713822

gerritbot added a comment.Aug 23 2021, 9:55 PM

Change 714425 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump parsoid to 0.14.0-a16

https://gerrit.wikimedia.org/r/714425

gerritbot added a comment.Aug 23 2021, 11:00 PM

Change 714425 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.14.0-a16

https://gerrit.wikimedia.org/r/714425

roman-stolar updated the task description. (Show Details)Aug 24 2021, 8:28 AM
gerritbot added a comment.Aug 25 2021, 3:19 PM

Change 713826 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Content::preSaveTransform.

https://gerrit.wikimedia.org/r/713826

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.21; 2021-08-30); removed MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 25 2021, 4:00 PM
roman-stolar updated the task description. (Show Details)Aug 26 2021, 9:58 AM
roman-stolar moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.
• Pchelolo closed this task as Resolved.Sep 9 2021, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits