T256571: Since Gerrit 3.2, gitiles monospaced text is bold appears to have regressed.
I see font-weight: 500 in the CSS, causing the bold.
Example (might need to force refresh due to caching): https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/refs/heads/master/w/static.php
Did we lose @QChris's patch https://gerrit-review.googlesource.com/c/gitiles/+/273661 that was merged upstream?
It is a regression from T256571
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T287189 Gitiles monospaced text is bolded again | |||
| Resolved | hashar | T307334 Upgrade to Gerrit 3.5 | |||
| Resolved | hashar | T315445 Update Gerrit CI result table CSS style | |||
| Open | hashar | T317412 Automate Gerrit deployment steps | |||
| Resolved | hashar | T323097 Fix up Gerrit usernames having upper case character(s) | |||
| Resolved | hashar | T323135 Fix up Gerrit duplicate LDAP external ids |
The gitiles dependency is listed in Gerrit:
WORKSPACE:GITILES_VERS = "0.4" WORKSPACE: artifact = "com.google.gitiles:blame-cache:" + GITILES_VERS, WORKSPACE: artifact = "com.google.gitiles:gitiles-servlet:" + GITILES_VERS,
Version 0.4 does not contain the fix and I have no idea how to change that :\
I have asked upstream whether a new version can be cut, then it would be all about setting GITILES_VERS = "0.5" and adjust the checksum.
An alternative is to build our own gitiles and publish it to Archiva, add an entry for it:
REPO_ROOTS = {
+ 'WIKIMEDIA': 'https://archiva.wikimedia.org/repository/releases',
'ECLIPSE': 'https://repo.eclipse.org/content/groups/releases',
'GERRIT': 'https://gerrit-maven.storage.googleapis.com',
'GERRIT_API': 'https://gerrit-api.commondatastorage.googleapis.com/release',
'MAVEN_CENTRAL': 'https://repo1.maven.org/maven2',
'MAVEN_LOCAL': 'file://' + path.expanduser('~/.m2/repository'),
'MAVEN_SNAPSHOT': 'https://oss.sonatype.org/content/repositories/snapshots',
}And:
- GITILES_VERS = "0.4" + GITILES_VERS = "0.5" - GITILES_REPO = GERRIT + GITILES_REPO = WIKIMEDIA
But I would rather not have to maintain a fork of gitiles.
Upstream has cut a v0.4-1 which includes Christian patch. We could then try :
We have upgraded to Gerrit 3.5.4 (T307334) which upgrades the gitiles plugin which does have @QChris fix.
https://www.gerritcodereview.com/3.5.html#plugin-changes
Plugin changes
- gitiles
- Change 273661: Drop u-pre’s font-weight in CSS.