Page MenuHomePhabricator
Create Task
Maniphest T287215

Enable WVUI search on commons
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The new WVUI search in Vector is currently disabled on Wikidata and Wikimedia Commons. Enabling it on WIkidata.org is blocked on T275251 but there is no longer any reason to disable it on Wikimedia Commons.

Required configuration change

  • Drop the wgVectorUseWvuiSearch entry for Commons
  • Set the required descriptions / thumbnail options in wgVectorWvuiSearchOptions
  • Config: no images, no descriptions

QA

QA Results - Beta

ACStatusDetails
1✅T287215#7348431
2✅T287215#7348431
3✅T287215#7348431

QA Results - Prod

ACStatusDetails
1✅T287215#7368963
2✅T287215#7368963
3✅T287215#7368963

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enable WVUI search on Wikimedia Commonsoperations/mediawiki-configmaster+4 -1
Enable WVUI search on Wikimedia Commonsoperations/mediawiki-configmaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 22 2021, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2021, 9:54 PM
Jdlrobson triaged this task as Medium priority.Jul 22 2021, 10:23 PM
ovasileva updated the task description. (Show Details)Jul 26 2021, 7:09 PM
gerritbot added a comment.Jul 26 2021, 7:10 PM

Change 708156 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable WVUI search on Wikimedia Commons

https://gerrit.wikimedia.org/r/708156

gerritbot added a project: Patch-For-Review.Jul 26 2021, 7:10 PM
Jdlrobson claimed this task.Jul 26 2021, 7:10 PM
ovasileva updated the task description. (Show Details)Jul 26 2021, 10:48 PM
Jdlrobson updated the task description. (Show Details)Jul 27 2021, 5:44 PM
LGoto set the point value for this task to 2.Jul 27 2021, 5:45 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 27 2021, 6:25 PM
gerritbot added a comment.Jul 27 2021, 11:26 PM

Change 708156 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable WVUI search on Wikimedia Commons

https://gerrit.wikimedia.org/r/708156

Jdlrobson mentioned this in T287540: MediaSearch not compatible with new WVUI search widget on Wikimedia Commons.Jul 27 2021, 11:46 PM
Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

Tried to deploy this but found a bug in our implementation.
Blocked on T287540

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2021, 12:10 AM
LGoto edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived (Kanbanana-FY-2020-21).Aug 2 2021, 9:27 PM
LGoto moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Volker_E moved this task from Blocked on Others to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Aug 27 2021, 5:02 AM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Aug 30 2021, 5:22 PM

This can be deployed on Wednesday earliest, when the new WVUI has rolled out to Commons

gerritbot added a comment.Aug 30 2021, 7:25 PM

Change 715586 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable WVUI search on Wikimedia Commons

https://gerrit.wikimedia.org/r/715586

gerritbot added a project: Patch-For-Review.Aug 30 2021, 7:25 PM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Aug 31 2021, 4:56 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Sep 1 2021, 4:37 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Sep 1 2021, 11:08 PM

Change 715586 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable WVUI search on Wikimedia Commons

https://gerrit.wikimedia.org/r/715586

Jdlrobson assigned this task to Edtadros.Sep 1 2021, 11:10 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
Stashbot added a comment.Sep 1 2021, 11:11 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:11:51Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: bb7d92c48edf48b94fd628e9e0b5fd6682460373: Enable WVUI search on Wikimedia Commons (T287215) (duration: 01m 07s)

ovasileva closed subtask T287540: MediaSearch not compatible with new WVUI search widget on Wikimedia Commons as Resolved.Sep 7 2021, 3:44 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.EditedSep 13 2021, 1:53 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://commons.wikimedia.org/wiki/Main_Page?useskinversion=2
✅ AC1: The new Vue search should be shown
✅ AC2: No descriptions or thumbnails should show on search results
✅ AC3: Hitting enter should take user to Special:MediaSearch

Screen Recording 2021-09-10 at 1.59.38 PM.mov.gif (822×1 px, 349 KB)

Edtadros updated the task description. (Show Details)Sep 13 2021, 1:54 PM
Edtadros reassigned this task from Edtadros to ovasileva.Sep 21 2021, 1:27 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://commons.wikimedia.org/wiki/Main_Page?useskinversion=2
✅ AC1: The new Vue search should be shown
✅ AC2: No descriptions or thumbnails should show on search results
✅ AC3: Hitting enter should take user to Special:MediaSearch

Screen Recording 2021-09-21 at 6.26.24 AM.mov.gif (750×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Sep 21 2021, 1:32 PM
ovasileva closed this task as Resolved.Sep 21 2021, 4:44 PM

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits