[Design bug] Replace non-standard coloured icon with correct colour on the mobile homepage navigation menu
Closed, ResolvedPublicDesign
Actions

Assigned To

Authored By

	RHo
	Jul 23 2021, 10:40 AM

Description

In T280666#7087963, @Volker_E wrote:

Note that MediaWiki currently already provides an ability to define color variants for specific icons via ResourceLoaderImageModule.
While GrowthExperiments has already defined certain icons itself, and also features a non-guideline default color #4A4F53 for the 'newspaper' icon(?!), it doesn't define further variants.

Per @Volker_E's note on T280666#7087963 - the colour #4A4F53 should be removed from the 'newspaper' icon as it's not a defined colour in the palette. The navigation menu item (not part of the newcomer features) which should just use the same icon colours as the rest of the mobile side nav, which is Base20 or #54595d.

icon in question with incorrect colour is the newpaper icon for the "Main page" nav item

Details

	Subject	Repo	Branch	Lines +/-
	Change the default color for ext.growthExperiments.mobileMenu.icons to base20	mediawiki/extensions/GrowthExperiments	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T280666: Extend color and size guidelines of the Wikimedia Design System icon set

Event Timeline

RHo created this task.Jul 23 2021, 10:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2021, 10:40 AM

@RHo: Assuming this task is about GrowthExperiments, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. (Please set appropriate project tags when possible. Thanks!)

Tgr moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 27 2021, 7:59 AM

Change 761076 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Change the default color for ext.growthExperiments.mobileMenu.icons to base20

https://gerrit.wikimedia.org/r/761076

gerritbot added a project: Patch-For-Review.Feb 8 2022, 11:51 PM

Screen Shot 2022-02-08 at 3.52.49 PM.png (194×636 px, 13 KB)

• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 8 2022, 11:53 PM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 9 2022, 8:14 AM

Change 761076 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change the default color for ext.growthExperiments.mobileMenu.icons to base20

https://gerrit.wikimedia.org/r/761076

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 9 2022, 9:00 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 18 2022, 2:00 AM

Checked in wmf.22 (iOS and Android) - the icon looks as per the screenshot in the comment above - https://phabricator.wikimedia.org/T287239#7695632

	F34946015: Screen Shot 2022-02-08 at 3.52.49 PM.png
	Feb 8 2022, 11:53 PM

[Design bug] Replace non-standard coloured icon with correct colour on the mobile homepage navigation menuClosed, ResolvedPublicDesignActions

Description

Details

Related Objects

Event Timeline

[Design bug] Replace non-standard coloured icon with correct colour on the mobile homepage navigation menu
Closed, ResolvedPublicDesign
Actions