Page MenuHomePhabricator

[Design bug] Replace non-standard coloured icon with correct colour on the mobile homepage navigation menu
Closed, ResolvedPublicDesign

Description

Note that MediaWiki currently already provides an ability to define color variants for specific icons via ResourceLoaderImageModule.
While GrowthExperiments has already defined certain icons itself, and also features a non-guideline default color #4A4F53 for the 'newspaper' icon(?!), it doesn't define further variants.

Per @Volker_E's note on T280666#7087963 - the colour #4A4F53 should be removed from the 'newspaper' icon as it's not a defined colour in the palette. The navigation menu item (not part of the newcomer features) which should just use the same icon colours as the rest of the mobile side nav, which is Base20 or #54595d.

image.png (282×492 px, 10 KB)

icon in question with incorrect colour is the newpaper icon for the "Main page" nav item

Event Timeline

@RHo: Assuming this task is about GrowthExperiments, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. (Please set appropriate project tags when possible. Thanks!)

Change 761076 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Change the default color for ext.growthExperiments.mobileMenu.icons to base20

https://gerrit.wikimedia.org/r/761076

Change 761076 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Change the default color for ext.growthExperiments.mobileMenu.icons to base20

https://gerrit.wikimedia.org/r/761076

Etonkovidova added a subscriber: Etonkovidova.

Checked in wmf.22 (iOS and Android) - the icon looks as per the screenshot in the comment above - https://phabricator.wikimedia.org/T287239#7695632