Page MenuHomePhabricator

Create a source dispatching PropertyDataTypeLookup
Closed, ResolvedPublic

Description

With the combined fed props + local props EntitySearchHelper we started using recently, search for local and federated properties almost worked. We overlooked that the EntitySearchHelper for local properties also uses a DataTypeLookup which currently always gets a lookup that *only* works on federated properties. Instead of returning one or the other, we should create a SourceDispatchingPropertyDataTypeLookup that delegates to the right implementation based on the given property id.

Event Timeline

Change 708131 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Introduce SourceDispatchingPropertyDataTypeLookup

https://gerrit.wikimedia.org/r/708131

Change 708251 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Change service PropertyDataTypeLookup to use source dispatching

https://gerrit.wikimedia.org/r/708251

Change 708131 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Introduce SourceDispatchingPropertyDataTypeLookup

https://gerrit.wikimedia.org/r/708131

Change 708251 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change service PropertyDataTypeLookup to use source dispatching

https://gerrit.wikimedia.org/r/708251