With the combined fed props + local props EntitySearchHelper we started using recently, search for local and federated properties almost worked. We overlooked that the EntitySearchHelper for local properties also uses a DataTypeLookup which currently always gets a lookup that *only* works on federated properties. Instead of returning one or the other, we should create a SourceDispatchingPropertyDataTypeLookup that delegates to the right implementation based on the given property id.
Description
Description
Details
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T286276 Make wbsearchentities API work with local and remote properties | |||
Resolved | Addshore | T286719 Make wbsearchentities work for search by term | |||
Resolved | • Tonina_Zhelyazkova_WMDE | T287249 Create a source dispatching PropertyDataTypeLookup |
Event Timeline
Comment Actions
Change 708131 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Introduce SourceDispatchingPropertyDataTypeLookup
Comment Actions
Change 708251 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Change service PropertyDataTypeLookup to use source dispatching
Comment Actions
Change 708131 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Introduce SourceDispatchingPropertyDataTypeLookup
Comment Actions
Change 708251 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change service PropertyDataTypeLookup to use source dispatching