Page MenuHomePhabricator
Create Task
Maniphest T287250

Fix ApiEntityTitleTextLookup for federated properties
Closed, ResolvedPublic
Actions

Description

"title text" refers to the mediawiki concept of a "title" (page name) prefixed with the namespace. This currently contains a concept URI for federated properties which makes no sense and causes wbformatentities to have an invalid URL for federated properties.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FP: add FederatedPropertyId::getRemoteIdSerializationmediawiki/extensions/Wikibasemaster+84 -39
FP: fix ApiEntityTitleTextLookupmediawiki/extensions/Wikibasemaster+6 -10
FP: throw for non-FedPropIds in Api* servicesmediawiki/extensions/Wikibasemaster+112 -15
FP: use getRemoteIdSerialization in ApiEntityLookupmediawiki/extensions/Wikibasemaster+46 -139
Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Jul 23 2021, 1:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2021, 1:28 PM
Jakob_WMDE claimed this task.Jul 23 2021, 1:28 PM
gerritbot added a comment.Jul 26 2021, 9:57 AM

Change 708077 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: add method for getting unprefixed fed prop id

https://gerrit.wikimedia.org/r/708077

gerritbot added a project: Patch-For-Review.Jul 26 2021, 9:57 AM
gerritbot added a comment.Jul 26 2021, 10:09 AM

Change 708080 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: use unprefix method in ApiEntityLookup

https://gerrit.wikimedia.org/r/708080

gerritbot added a comment.Jul 26 2021, 10:22 AM

Change 708082 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: fix ApiEntityTitleTextLookup

https://gerrit.wikimedia.org/r/708082

gerritbot added a comment.Jul 26 2021, 1:22 PM

Change 708113 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: throw for non-FedPropIds in Api* services

https://gerrit.wikimedia.org/r/708113

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 27 2021, 10:30 AM
gerritbot added a comment.Jul 28 2021, 10:26 AM

Change 708077 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: add FederatedPropertyId::getRemoteIdSerialization

https://gerrit.wikimedia.org/r/708077

gerritbot added a comment.Jul 28 2021, 10:29 AM

Change 708113 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: throw for non-FedPropIds in Api* services

https://gerrit.wikimedia.org/r/708113

gerritbot added a comment.Jul 28 2021, 10:29 AM

Change 708080 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: use getRemoteIdSerialization in ApiEntityLookup

https://gerrit.wikimedia.org/r/708080

gerritbot added a comment.Jul 28 2021, 10:30 AM

Change 708082 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: fix ApiEntityTitleTextLookup

https://gerrit.wikimedia.org/r/708082

Tarrow moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 28 2021, 10:54 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 28 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 28 2021, 11:10 AM
Jakob_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 3) board.Jul 30 2021, 11:02 AM
Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits