Page MenuHomePhabricator

The new interlanguage link does not display visited links in a different colour
Closed, DuplicatePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • The link from ptwiki to eswiki appears in the same colour as the other links

What should have happened instead?:

  • The colour should change to be a visited link - the same as the link on eswiki to ptwiki changes colour

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:e

  • Using Firefox 90.0.2 on Mac OS 11.5.

On eswiki:

image.png (178×186 px, 11 KB)

On ptwiki:

image.png (501×407 px, 28 KB)

Event Timeline

Jdlrobson subscribed.

Yep it seems like we might want to remove that style. I'm not sure if it's needed as the color is the same as the default. Language team can you advise?

Yep it seems like we might want to remove that style. I'm not sure if it's needed as the color is the same as the default. Language team can you advise?

In general, selectors expose multiple options for users to pick. Although these options are interactive, normally they are not presented as links. You can check as reference drop-downs, menus, date pickers, and other usual UI components (in Wikimedia and on other common design systems). The idea for the new version of the language selector (T287860) is to converge into that approach and use black text instead for the options. Note that this is already the case on the mobile version for the selector on Wikimedia products already.

On the current selector on desktop, options were presented as links to align with the previous state. The standard blue from the standard palette (#36c) was used, which is not the current color used for links on Wikipedia (#0645ad, which has not aligned to the standard yet).

Since the current selector is intended to be replaced, I'd leave it as is and concentrate the efforts on the new one. In particular, I'd like to understand more about the usecase this supports in order to make sure the new language selector can be useful in that context too. Currently it already supports to provide access to frequent languages, but if that is not enough for some activities we may need to explore what can be done about those.

Per T287323#7344280
Focusing on the new implementation.

Per T287323#7344280
Focusing on the new implementation.

Could you expand on that please? What/where?

Re-opening due to the lack of a reply above.

Jdlrobson claimed this task.

Since the current selector is intended to be replaced, I'd leave it as is and concentrate the efforts on the new one.

We're rebuilding the language feature in T287860. and we are converging towards black text.

From T287323#7344280:

" The idea for the new version of the language selector (T287860) is to converge into that approach and use black text instead for the options. Note that this is already the case on the mobile version for the selector on Wikimedia products already".

There is also an invite in that comment to drive the new design to consider this: "I'd like to understand more about the usecase this supports in order to make sure the new language selector can be useful in that context too."

e.g. write on the talk page of https://commons.wikimedia.org/wiki/File:Language_Selector_Designs.pdf or T287860

Since the current selector is intended to be replaced, I'd leave it as is and concentrate the efforts on the new one.

We're rebuilding the language feature in T287860. and we are converging towards black text.

From T287323#7344280:

" The idea for the new version of the language selector (T287860) is to converge into that approach and use black text instead for the options. Note that this is already the case on the mobile version for the selector on Wikimedia products already".

There is also an invite in that comment to drive the new design to consider this: "I'd like to understand more about the usecase this supports in order to make sure the new language selector can be useful in that context too."

e.g. write on the talk page of https://commons.wikimedia.org/wiki/File:Language_Selector_Designs.pdf or T287860

Thanks, I'll follow up there.

stjn subscribed.

Re-opening this given that 1) this is a bug with Vector 2022 skin using ULS by default, 2) almost 3 years later we still have no ‘rebuilded ULS’. The ticket can be closed when the issue is actually resolved.

Weirdly enough, the link gets to be the right colour on hover, so this seems to be more easily fixable without waiting for full ULS rewrite.

The rule .uls-language-block a is in ULS codebase.

Jdlrobson unsubscribed.