Page MenuHomePhabricator

Minerva hides create new page block on Special:Search, it should not do that
Closed, DuplicatePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What should have happened instead?:
I suppose this was done because English Wikipedia does not allow anonymous users to create new pages. English Wikipedia, however, is not the only Wikimedia wiki to exist. There should be a clear way to create a new page on mobile version, and this is the most clear way for a potential editor already familiar with desktop version.

Event Timeline

@Jdlrobson: I would’ve preferred this being a separate task, since removing that rule at least for some editors (with AMC maybe?) would be better than designing something for a long time and doing nothing in a meanwhile, but ¯\_(ツ)_/¯ I guess.

@stjn this conversation comes up time and time again, and there have been many conversations around the workflow and the order this should happen, so I think it makes sense to have the conversation in one place. From what I understand this is just waiting for someone (either volunteer or WMF as part of a project) to actually implement the agreed solution. I think displaying the link in AMC is not controversial and would happily review a patch if was pushed :)

Sorry for late response, but how would one go around this? As far as I can see, AMC mode does not have any classes or anything that differs it from non-AMC users, and these styles are stored in Minerva skin itself.

I can see 2 ways of doing this. Both would involve removing the Minerva code.

Method 1:

  1. Expand MFRemovableClasses to apply in the AMC mode, and then add a CSS selector there .mw-special-Search .search to handle the hiding

Method 2:

  1. Add a class inside onSpecialPageBeforeExecute for mf-special-AMC.
  2. Add a rule to mobile.special.styles scoped to the mw-special-Search class to override the display: none.

I think both would be a suitable way to solve this problem, given its temporary (I hope)