Page MenuHomePhabricator

ResourceLoaderSkinModule: Skins should not use the legacy styling feature
Closed, ResolvedPublic3 Estimated Story Points

Description

In T89981 we split out the legacy feature (ResourceLoaderSkinModule) into multiple parts.

Now we will mark it as legacy, and remove the legacy feature in all Wikimedia deployed skins that use it.
We will start with Vector T278896, which should tease out any remaining issues.

On doing that, we can proceed to remove it from all Wikimedia deployed skins that were making use of it.

When we are happy that the new features provide an adequate substitution for the legacy

As part of the change we should also deprecate the content feature and content-thumbnails feature which currently act as aliases for other modules.

TODO

The legacy feature should no longer apply to skins using ResourceLoaderSkinModule which do not define a features value.

Part 1

  • Replace legacy feature in Modern, CologneBlue, MonoBook

Part 2

  • Replace legacy feature in Vector (legacy) - leaving a week space between the above deploys.

Developer notes

For each skin we'll use
https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature as a guide to make the migration.

Note, we may encounter bugs as we roll out so we should focus on smaller less-widely used skins first.

"legacy": true

can be replaced with the options on the wiki page above.

Note when disabling the legacy feature, this you'll also need to consider whether it makes sense to copy across any of the ruels in resources/src/mediawiki.skinning/commonPrint.less stylesheet. If in doubt, do not copy them over, they are likely not needed.

/* Various content classes, in alphabetical order */
.mw-cite-backlink,
.mw-redirectedfrom,
.patrollink,
/* Various content ids, in alphabetical order */
#column-one,
#footer-places,
#mw-navigation,
/* Deprecated, changed in core */
#f-poweredbyico,
#f-copyrightico,
li#about,
li#disclaimer,
li#mobileview,
li#privacy {
        display: none;
}

/**
 * Generic HTML elements
 */
body {
        background: #fff;
        color: #000;
        margin: 0;
        padding: 0;
}
/* Prevent citations and subscripts from interfering with the line-height */
sup,
sub {
        line-height: 1;
}

/**
 * MediaWiki-specific elements
 */
#globalWrapper {
        width: 100% !important; /* stylelint-disable-line declaration-no-important */
        min-width: 0 !important; /* stylelint-disable-line declaration-no-important */
}

.mw-body {
        background: #fff;
        color: #000;
        border: 0 !important; /* stylelint-disable-line declaration-no-important */
        padding: 0 !important; /* stylelint-disable-line declaration-no-important */
        margin: 0 !important; /* stylelint-disable-line declaration-no-important */
        direction: ltr;
}

#column-content {
        margin: 0 !important; /* stylelint-disable-line declaration-no-important */
}

#column-content .mw-body {
        padding: 1em;
        margin: 0 !important; /* stylelint-disable-line declaration-no-important */
}

/**
 * Footer
 */
.printfooter {
        padding: 1em 0;
}

#footer {
        background: #fff;
        color: #000;
        margin-top: 1em;
        border-top: 1pt solid #aaa;
        padding-top: 5px;
        direction: ltr;
}

QA steps

NOTE: This QA is time sensitive, please DM Edward when it's ready, ideally merging after branch cut to maximize his time for testing.

Run the following tests 4 times for the different skins Monobook, Vector (classic), CologneBlue and Modern.

Please compare several pages in production (en.wikipedia.org) to beta cluster (https://en.wikipedia.beta.wmflabs.org/)

Sign off steps

QA Results - Beta

https://phabricator.wikimedia.org/T287410#7313974

QA Results - Beta

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson removed the point value for this task.
Jdlrobson updated the task description. (Show Details)

@Jdlrobson I'm getting an error for the 'interface-message-boxes' feature, which isn't defined in core as far as I can tell. Is this documentation just outdated or am I missing something?

Change 708572 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MonoBook@master] Remove 'legacy' feature

https://gerrit.wikimedia.org/r/708572

Change 708573 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Modern@master] Remove 'legacy' feature

https://gerrit.wikimedia.org/r/708573

Change 708576 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/CologneBlue@master] Remove 'legacy' feature

https://gerrit.wikimedia.org/r/708576

Change 708573 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Remove soon to be deprecated 'legacy' feature

https://gerrit.wikimedia.org/r/708573

Jdlrobson set the point value for this task to 3.Jul 29 2021, 5:13 PM

Change 708576 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Remove 'legacy' feature

https://gerrit.wikimedia.org/r/708576

Change 708572 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Remove 'legacy' feature, simplify skins.monobook.mobile module

https://gerrit.wikimedia.org/r/708572

We've addressed this in Modern, CologneBlue and Modern.
We'll let those changes ride the train next week, and then do the final skin Vector classic next week, making sure not to merge any sooner than Tuesday 3rd. The reason for this is to maximize the chance of bugs getting reported before we serve to where most of our traffic is. A user notice has also gone out for the issue we discovered in Vector modern (T287701)

Almost there! :D

Change 709082 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove 'legacy' feature

https://gerrit.wikimedia.org/r/709082

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: bwang.

Change 709082 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove 'legacy' feature

https://gerrit.wikimedia.org/r/709082

This also caused T288739 but we can QA that as part of that task. Sorry for the confusion Edward.

I’m pretty sure T288907 is also because of this.

Jdlrobson added a subscriber: Krinkle.

Flagged by @Krinkle :

We are sending deprecation warnings for skins.vector.styles.legacy:

  • [1.37] The use of the content feature with ResourceLoaderSkinModule is deprecated. Use content-media instead. [1.37]
  • The use of the content-thumbnails feature with ResourceLoaderSkinModule is deprecated. Use content-media instead.

Change 655170 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoaderSkinModule: `content`, `content-thumbnails` and `legacy` features are deprecated

https://gerrit.wikimedia.org/r/655170

The above is to be (partly) reverted or fixed by wmf.20.

I'm on latest mediawiki/core and skins/Vector, and all page views during development get:

This page is using the deprecated ResourceLoader module "skins.vector.styles.legacy". [1.37] The use of the content feature with ResourceLoaderSkinModule is deprecated. Use content-media instead. [1.37] The use of the content-thumbnails feature with ResourceLoaderSkinModule is deprecated. Use content-media instead. More information can be found at [[mw:Manual:ResourceLoaderSkinModule]].

The same is true in Beta and production as well. It is not unheard of deprecate in such visible way something that is used in production, for example of the feature in question has rare use cases that are difficult to find in search. But there are only a handful of skins, and which SkinModule attributes they use is trivially found in Codesearch so presumably that's not the rationale. As such, I assume it was a mistake to deprecate this and that it was probably thought that these are no longer used by production skins. If not, who is the deprecation meant to be seen by to act on. If for third-parties, it should perhaps be merged closer to the end of the release cycle, after the production uses are fixed.

Tentatively blocking next train per policy, especially since it's trivial to remove the deprecation line.

Change 713673 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Replace deprecated 'content' and 'content-thumbnail' features with 'content-media'

https://gerrit.wikimedia.org/r/713673

Change 713677 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/MonoBook@master] Replace deprecated 'content' and 'content-thumbnail' features with 'content-media'

https://gerrit.wikimedia.org/r/713677

Change 713677 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Replace deprecated 'content' and 'content-thumbnail' features with 'content-media'

https://gerrit.wikimedia.org/r/713677

Change 713673 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Replace deprecated 'content' and 'content-thumbnail' features with 'content-media'

https://gerrit.wikimedia.org/r/713673

Test Result - Beta

Status:
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Run the following tests 4 times for the different skins Monobook, Vector (classic), CologneBlue and Modern.

✅ AC1: Check categories at bottom of the page render identically

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 10.41.13 AM.png (737×1 px, 296 KB)
Screen Shot 2021-08-18 at 10.41.29 AM.png (737×1 px, 262 KB)
Screen Shot 2021-08-18 at 10.41.46 AM.png (737×1 px, 355 KB)
Screen Shot 2021-08-18 at 10.42.10 AM.png (737×1 px, 271 KB)

✅ AC2: Please check headings in page render identically

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 10.46.07 AM.png (977×1 px, 505 KB)
Screen Shot 2021-08-18 at 10.46.28 AM.png (977×1 px, 542 KB)
Screen Shot 2021-08-18 at 10.46.46 AM.png (977×1 px, 549 KB)
Screen Shot 2021-08-18 at 10.47.03 AM.png (977×1 px, 500 KB)

✅ AC3: Please check thumbnails in page render identically

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 11.09.59 AM.png (977×1 px, 626 KB)
Screen Shot 2021-08-18 at 11.10.20 AM.png (977×1 px, 632 KB)
Screen Shot 2021-08-18 at 11.30.58 AM.png (977×1 px, 721 KB)
Screen Shot 2021-08-18 at 11.36.10 AM.png (977×1 px, 626 KB)

✅ AC4: Please check any lists in page render identically (make sure to test numbered lists as well as unordered lists)

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 11.58.00 AM.png (977×1 px, 287 KB)
Screen Shot 2021-08-18 at 11.57.45 AM.png (977×1 px, 325 KB)
Screen Shot 2021-08-18 at 11.57.31 AM.png (977×1 px, 372 KB)
Screen Shot 2021-08-18 at 11.57.12 AM.png (977×1 px, 300 KB)

✅ AC5: Visit Special:Version and confirm the table in the "Installed software" section is identical

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 12.00.38 PM.png (977×1 px, 273 KB)
Screen Shot 2021-08-18 at 12.00.23 PM.png (977×1 px, 268 KB)
Screen Shot 2021-08-18 at 12.00.13 PM.png (977×1 px, 277 KB)
Screen Shot 2021-08-18 at 11.59.59 AM.png (977×1 px, 221 KB)

✅ AC6: Compare link colors in https://en.wikipedia.org/wiki/User:Jdlrobson/sandboxLinkTest and https://en.wikipedia.org/wiki/User:Jdlrobson/sandboxLinkTest

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 12.05.16 PM.png (540×692 px, 126 KB)
Screen Shot 2021-08-18 at 12.12.57 PM.png (540×692 px, 145 KB)
Screen Shot 2021-08-18 at 12.16.30 PM.png (540×692 px, 144 KB)
Screen Shot 2021-08-18 at 12.18.17 PM.png (540×692 px, 101 KB)
Screen Shot 2021-08-18 at 12.05.33 PM.png (540×692 px, 119 KB)
Screen Shot 2021-08-18 at 12.13.05 PM.png (540×692 px, 129 KB)
Screen Shot 2021-08-18 at 12.16.38 PM.png (540×692 px, 130 KB)
Screen Shot 2021-08-18 at 12.18.32 PM.png (540×692 px, 98 KB)
Screen Shot 2021-08-18 at 12.08.26 PM.png (540×692 px, 116 KB)
Screen Shot 2021-08-18 at 12.13.10 PM.png (540×692 px, 143 KB)
Screen Shot 2021-08-18 at 12.16.49 PM.png (540×692 px, 139 KB)
Screen Shot 2021-08-18 at 12.18.32 PM.png (540×692 px, 98 KB)
Screen Shot 2021-08-18 at 12.08.11 PM.png (540×692 px, 124 KB)
Screen Shot 2021-08-18 at 12.13.14 PM.png (540×692 px, 126 KB)
Screen Shot 2021-08-18 at 12.16.57 PM.png (540×692 px, 131 KB)
Screen Shot 2021-08-18 at 12.18.37 PM.png (540×692 px, 102 KB)
Screen Shot 2021-08-18 at 12.08.31 PM.png (540×692 px, 118 KB)
Screen Shot 2021-08-18 at 12.13.20 PM.png (540×692 px, 140 KB)
Screen Shot 2021-08-18 at 12.17.05 PM.png (540×692 px, 135 KB)
Screen Shot 2021-08-18 at 12.18.43 PM.png (540×692 px, 99 KB)
Screen Shot 2021-08-18 at 12.08.15 PM.png (540×692 px, 123 KB)
Screen Shot 2021-08-18 at 12.13.25 PM.png (540×692 px, 124 KB)
Screen Shot 2021-08-18 at 12.17.13 PM.png (540×692 px, 126 KB)
Screen Shot 2021-08-18 at 12.18.49 PM.png (540×692 px, 90 KB)

❌ AC7: Please check any message boxes in the display e.g. the old revision box at the top of https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Conflict-title-0.6711461392091387-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&oldid=406886
There is a red box around part of the message.

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-18 at 12.24.21 PM.png (654×1 px, 290 KB)
Screen Shot 2021-08-18 at 12.26.12 PM.png (654×1 px, 240 KB)
Screen Shot 2021-08-18 at 12.27.15 PM.png (654×1 px, 263 KB)
Screen Shot 2021-08-18 at 12.27.34 PM.png (654×1 px, 240 KB)
Screen Shot 2021-08-18 at 12.24.26 PM.png (654×1 px, 294 KB)
Screen Shot 2021-08-18 at 12.26.18 PM.png (654×1 px, 259 KB)
Screen Shot 2021-08-18 at 12.27.19 PM.png (654×1 px, 378 KB)
Screen Shot 2021-08-18 at 12.27.45 PM.png (654×1 px, 237 KB)

❌ AC8: Please check all the above in the print version
There is a red box around part of the message. See the Albert Einstein PDFs

MonobookVector ClassicCologneBlueModern

❌ AC7: Please check any message boxes in the display e.g. the old revision box at the top of https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Conflict-title-0.6711461392091387-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&oldid=406886

❌ AC8: Please check all the above in the print version

I think the acceptance criteria are wrong here, not the software. Compare https://en.wikipedia.org/w/index.php?title=MediaWiki:Revision-info&action=edit with https://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Revision-info&action=edit – simply the interface messages are different. (Maybe the current version of the production message should be copied over to the beta cluster, and then this task would pass the QA.)

Thanks @Tacsipacsi for pointing that out! I've adjusted the message on the beta cluster [1]. The red box should be gone now and this should pass.

[1] https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Revision-info

This is currently listed as a train blocker for 1.37.0-wmf.20 (T281161). Looking over the scrollback, I suspect it probably shouldn't be blocking any longer, but could we get confirmation on that?

Test Result - Prod

Status:
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Run the following tests 4 times for the different skins Monobook, Vector (classic), CologneBlue and Modern.

✅ AC1: Check categories at bottom of the page render identically

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 6.06.36 PM.png (1×1 px, 444 KB)
Screen Shot 2021-08-26 at 6.07.32 PM.png (1×1 px, 418 KB)
Screen Shot 2021-08-26 at 6.08.08 PM.png (1×1 px, 790 KB)
Screen Shot 2021-08-26 at 6.08.30 PM.png (1×968 px, 359 KB)

✅ AC2: Please check headings in page render identically

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 6.10.02 PM.png (1×1 px, 749 KB)
Screen Shot 2021-08-26 at 6.10.02 PM.png (1×1 px, 749 KB)
Screen Shot 2021-08-26 at 6.10.11 PM.png (1×1 px, 784 KB)
Screen Shot 2021-08-26 at 6.10.59 PM.png (1×1 px, 718 KB)

❓ AC3: Please check thumbnails in page render identically
@Jdlrobson I am assuming here that the thumbnails are the images on the right of the page as well as what appears in popups. I am flagging this one because if you look at the images in the popup, some are cropped. If you're okay with this I'll move to ready for signoff.

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 6.12.16 PM.png (1×1 px, 831 KB)
Screen Shot 2021-08-26 at 6.12.25 PM.png (1×1 px, 850 KB)
Screen Shot 2021-08-26 at 6.13.20 PM.png (1×1 px, 855 KB)
Screen Shot 2021-08-26 at 6.14.24 PM.png (1×1 px, 768 KB)

✅ AC4: Please check any lists in page render identically (make sure to test numbered lists as well as unordered lists)

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 6.18.59 PM.png (1×1 px, 524 KB)
Screen Shot 2021-08-26 at 6.19.15 PM.png (1×1 px, 499 KB)
Screen Shot 2021-08-26 at 6.20.15 PM.png (1×1 px, 480 KB)
Screen Shot 2021-08-26 at 6.19.45 PM.png (1×1 px, 543 KB)

✅ AC5: Visit Special:Version and confirm the table in the "Installed software" section is identical

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 6.22.09 PM.png (1×1 px, 421 KB)
Screen Shot 2021-08-26 at 6.22.24 PM.png (1×1 px, 402 KB)
Screen Shot 2021-08-26 at 6.22.41 PM.png (1×1 px, 435 KB)
Screen Shot 2021-08-26 at 6.22.52 PM.png (1×1 px, 357 KB)

✅ AC6: Compare link colors in https://en.wikipedia.org/wiki/User:Jdlrobson/sandboxLinkTest and https://en.wikipedia.org/wiki/User:Jdlrobson/sandboxLinkTest
expected over actual in the table below.

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 6.27.52 PM.png (1×1 px, 383 KB)
Screen Shot 2021-08-26 at 6.28.30 PM.png (1×1 px, 414 KB)
Screen Shot 2021-08-26 at 6.29.03 PM.png (1×1 px, 418 KB)
Screen Shot 2021-08-26 at 6.27.09 PM.png (1×1 px, 352 KB)
Screen Shot 2021-08-18 at 12.05.33 PM.png (540×692 px, 119 KB)
Screen Shot 2021-08-18 at 12.13.05 PM.png (540×692 px, 129 KB)
Screen Shot 2021-08-18 at 12.16.38 PM.png (540×692 px, 130 KB)
Screen Shot 2021-08-26 at 6.27.59 PM.png (1×1 px, 386 KB)
Screen Shot 2021-08-26 at 6.28.35 PM.png (1×1 px, 412 KB)
Screen Shot 2021-08-26 at 6.29.09 PM.png (1×1 px, 421 KB)
Screen Shot 2021-08-26 at 6.27.13 PM.png (1×1 px, 355 KB)
Screen Shot 2021-08-18 at 12.08.11 PM.png (540×692 px, 124 KB)
Screen Shot 2021-08-18 at 12.13.14 PM.png (540×692 px, 126 KB)
Screen Shot 2021-08-18 at 12.16.57 PM.png (540×692 px, 131 KB)
Screen Shot 2021-08-18 at 12.18.37 PM.png (540×692 px, 102 KB)
Screen Shot 2021-08-26 at 6.28.07 PM.png (1×1 px, 385 KB)
Screen Shot 2021-08-26 at 6.28.39 PM.png (1×1 px, 411 KB)
Screen Shot 2021-08-26 at 6.29.13 PM.png (1×1 px, 417 KB)
Screen Shot 2021-08-26 at 6.27.20 PM.png (1×1 px, 342 KB)
Screen Shot 2021-08-18 at 12.08.15 PM.png (540×692 px, 123 KB)
Screen Shot 2021-08-18 at 12.13.25 PM.png (540×692 px, 124 KB)
Screen Shot 2021-08-18 at 12.17.13 PM.png (540×692 px, 126 KB)
Screen Shot 2021-08-18 at 12.18.49 PM.png (540×692 px, 90 KB)

✅ AC7: Please check any message boxes in the display e.g. the old revision box
actual over expected in the table below

MonobookVector ClassicCologneBlueModern
Screen Shot 2021-08-26 at 8.18.52 PM.png (996×1 px, 524 KB)
Screen Shot 2021-08-26 at 8.19.19 PM.png (996×1 px, 519 KB)
Screen Shot 2021-08-26 at 8.20.01 PM.png (952×1 px, 487 KB)
Screen Shot 2021-08-26 at 8.20.21 PM.png (996×1 px, 478 KB)
Screen Shot 2021-08-18 at 12.24.26 PM.png (654×1 px, 294 KB)
Screen Shot 2021-08-18 at 12.26.18 PM.png (654×1 px, 259 KB)
Screen Shot 2021-08-18 at 12.27.19 PM.png (654×1 px, 378 KB)
Screen Shot 2021-08-18 at 12.27.45 PM.png (654×1 px, 237 KB)

✅ AC8: Please check all the above in the print version
There is a red box around part of the message. See the Albert Einstein PDFs

MonobookVector ClassicCologneBlueModern

@Jdlrobson Hi! I suspect that due to recent changes the font for .oo-ui-windowManager has decreased very much. Can we fix it?
I am not creating a new task because I don’t know how it should be.

image.png (309×787 px, 41 KB)

You can check it with this link on ruwiki:
image.png (283×193 px, 9 KB)

I had to do the following to restore the size: https://ru.wikipedia.org/w/index.php?diff=116346364

This looks unrelated to this bug @Iniquity I can't see any legacy styles that would have impacted this element in MonoBook.

I've opened T290013 to continue this discussion.