In T89981 we split out the legacy feature (ResourceLoaderSkinModule) into multiple parts.
Now we will mark it as legacy, and remove the legacy feature in all Wikimedia deployed skins that use it.
We will start with Vector T278896, which should tease out any remaining issues.
On doing that, we can proceed to remove it from all Wikimedia deployed skins that were making use of it.
When we are happy that the new features provide an adequate substitution for the legacy
As part of the change we should also deprecate the content feature and content-thumbnails feature which currently act as aliases for other modules.
TODO
The legacy feature should no longer apply to skins using ResourceLoaderSkinModule which do not define a features value.
Part 1
- Replace legacy feature in Modern, CologneBlue, MonoBook
Part 2
- Replace legacy feature in Vector (legacy) - leaving a week space between the above deploys.
Developer notes
For each skin we'll use
https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature as a guide to make the migration.
Note, we may encounter bugs as we roll out so we should focus on smaller less-widely used skins first.
"legacy": true
can be replaced with the options on the wiki page above.
Note when disabling the legacy feature, this you'll also need to consider whether it makes sense to copy across any of the ruels in resources/src/mediawiki.skinning/commonPrint.less stylesheet. If in doubt, do not copy them over, they are likely not needed.
/* Various content classes, in alphabetical order */
.mw-cite-backlink,
.mw-redirectedfrom,
.patrollink,
/* Various content ids, in alphabetical order */
#column-one,
#footer-places,
#mw-navigation,
/* Deprecated, changed in core */
#f-poweredbyico,
#f-copyrightico,
li#about,
li#disclaimer,
li#mobileview,
li#privacy {
display: none;
}
/**
* Generic HTML elements
*/
body {
background: #fff;
color: #000;
margin: 0;
padding: 0;
}
/* Prevent citations and subscripts from interfering with the line-height */
sup,
sub {
line-height: 1;
}
/**
* MediaWiki-specific elements
*/
#globalWrapper {
width: 100% !important; /* stylelint-disable-line declaration-no-important */
min-width: 0 !important; /* stylelint-disable-line declaration-no-important */
}
.mw-body {
background: #fff;
color: #000;
border: 0 !important; /* stylelint-disable-line declaration-no-important */
padding: 0 !important; /* stylelint-disable-line declaration-no-important */
margin: 0 !important; /* stylelint-disable-line declaration-no-important */
direction: ltr;
}
#column-content {
margin: 0 !important; /* stylelint-disable-line declaration-no-important */
}
#column-content .mw-body {
padding: 1em;
margin: 0 !important; /* stylelint-disable-line declaration-no-important */
}
/**
* Footer
*/
.printfooter {
padding: 1em 0;
}
#footer {
background: #fff;
color: #000;
margin-top: 1em;
border-top: 1pt solid #aaa;
padding-top: 5px;
direction: ltr;
}QA steps
Run the following tests 4 times for the different skins Monobook, Vector (classic), CologneBlue and Modern.
Please compare several pages in production (en.wikipedia.org) to beta cluster (https://en.wikipedia.beta.wmflabs.org/)
- Check categories at bottom of the page render identically
- Please check headings in page render identically
- Please check thumbnails in page render identically
- Please check any lists in page render identically (make sure to test numbered lists as well as unordered lists)
- Visit Special:Version and confirm the table in the "Installed software" section is identical
- Compare link colors in https://en.wikipedia.org/wiki/User:Jdlrobson/sandboxLinkTest and https://en.wikipedia.org/wiki/User:Jdlrobson/sandboxLinkTest
- Please check any message boxes in the display e.g. the old revision box at the top of https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Conflict-title-0.6711461392091387-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n&oldid=406886
- Please check all the above in the print version
Sign off steps
- Verify if there was any performance impact on beta cluster or production https://grafana.wikimedia.org/d/000000205/reading-web-performance?viewPanel=108&orgId=1&from=now-30d&to=now
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T287410#7292910 |
| 2 | ✅ | T287410#7292910 |
| 3 | ✅ | T287410#7292910 |
| 4 | ✅ | T287410#7292910 |
| 5 | ✅ | T287410#7292910 |
| 6 | ✅ | T287410#7292910 |
| 7 | ❌ | T287410#7292910 |
| 8 | ❌ | T287410#7292910 |
https://phabricator.wikimedia.org/T287410#7313974
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T287410#7313974 |
| 2 | ✅ | T287410#7313974 |
| 3 | ❓ | T287410#7313974 |
| 4 | ✅ | T287410#7313974 |
| 5 | ✅ | T287410#7313974 |
| 6 | ✅ | T287410#7313974 |
| 7 | ✅ | T287410#7313974 |
| 8 | ✅ | T287410#7313974 |
