Page MenuHomePhabricator

Update dns_to_ipset to not use domain name as key for set
Closed, ResolvedPublic

Description

When doing T287406 we ran across an issue. ipset has a hard limit for how long a set Name can be (31 characters). When adding in Adyen domains that were longer, it would cause the script to error when creating the -temp list for comparison. In the script we currently set the set name to the hostname specified in the config.

  • update dns_to_ipset to use the section name in config instead of the hostname when setting the set name
  • document the config and code to reference this limitation
  • add in duplicate configs for the existing sets so that we can transition
  • after testing heavily, update the puppet config for the transition
  • update the iptables rules to reference the appropriate new sets
  • remove the old hostname based sets

Event Timeline

Dwisehaupt moved this task from Triage to In Progress on the fundraising-tech-ops board.
commit ba5840fc8873fbdf0efb7ceefa547a431fbc70d6
Author: Dallas Wisehaupt <dwisehaupt@wikimedia.org>
Date:   Tue Jul 27 09:35:04 2021 -0700

    Update dns_to_ipset to handle ruleset name limit

[frack::puppet] fd69f847 Add new ipset rules with shorter names

Dwisehaupt moved this task from In Progress to Done on the fundraising-tech-ops board.
[frack::puppet::private] fbea8c3 Remove duplicate ipset rulenames civicrm, payments, payments_listener

This is complete. Closing.